App\Http\Controllers\TaskController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	144
Duplicated Lines	27.08 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	6
Bugs	0	Features	1

11 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	11	1
A	create()	0	3	1
A	store()	0	5	1
A	show()	19	19	2
A	edit()	0	3	1
A	update()	20	20	2
A	destroy()	0	3	1
A	transformCollection()	0	3	1
A	transform()	0	7	1
A	saveTask()	0	6	1
A	__construct()	0	3	1

<?php

namespace App\Http\Controllers;

use App\Task;
use Illuminate\Http\Request;

use App\Http\Requests;
use App\Http\Controllers\Controller;
use Response;

class TaskController extends Controller {
    /**
     * TaskController constructor.
     */
    public function __construct(){
        //$this->middleware('auth:api');

86% of this comment could be valid code. Did you maybe forget this after debugging?

    }


    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index() {
        // 1. No es retorna: paginacion
        //return Task::all();

63% of this comment could be valid code. Did you maybe forget this after debugging?

        $task = Task::all();

        return Response::json([
            'data' => $this->transformCollection($task)
            //'data' => $task->toArray()

67% of this comment could be valid code. Did you maybe forget this after debugging?

        ],200);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create() {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request) {
        $task = new Task();

        $this->saveTask($request, $task);
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id) {

This method seems to be duplicated in your project.

        //return $tag = Task::findOrFail($id);

54% of this comment could be valid code. Did you maybe forget this after debugging?

        $task = Task::find($id);

        if (!$task) {
            return Response::json([
                'error' => [
                    'message' => 'Task does not exist',
                    'code' => 195
                 ]
            ], 404);
        }

        return Response::json([
            'data' => $this->transform($task->toArray())
            //'data' => $task->toArray()

67% of this comment could be valid code. Did you maybe forget this after debugging?

        ],200);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id) {

The parameter $id is not used and could be removed.

        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id) {

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

        //$task = Task::findOrFail($id);

55% of this comment could be valid code. Did you maybe forget this after debugging?

        $task = Task::find($id);

        if (!$task) {
            return Response::json([
                'error' => [
                    'message' => 'Task does not exist',
                    'code' => 195
                ]
            ], 404);
        }

        return Response::json([
            'data' => $task->toArray()
        ],200);

        $this->saveTask($request, $task);

$this->saveTask($request, $task); does not seem to be reachable.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id) {
        Task::destroy($id);
    }

    public function transformCollection($task) {
        return array_map([$this, 'transform'], $task->toArray());
    }

    private function transform($task){
        return [
            'name' => $task['name'],
            'priority' => (boolean) $task['priority'],
            'done' => $task['done']
        ];
    }

    /**
     * @param Request $request
     * @param $tag
     */
    public function saveTask(Request $request, $task) {
        $task->name = $request->name;

The property name does not seem to exist in Illuminate\Http\Request.

        $task->priority = $request->priority;

The property priority does not seem to exist in Illuminate\Http\Request.

        $task->done = $request->done;

The property done does not seem to exist in Illuminate\Http\Request.

        $task->save();
    }
}