Pcelta\Doctrine\Cache\Factory\MemcacheFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getModuleName()	0	4	1
A	getMemcacheAdapter()	0	4	1
A	decorateWithConnectable()	0	10	1
A	isValidConfig()	0	13	3

<?php

namespace Pcelta\Doctrine\Cache\Factory;

use Doctrine\Common\Cache\CacheProvider;
use Pcelta\Doctrine\Cache\Entity\Config;

class MemcacheFactory extends AbstractFactory
{
    const MODULE_NAME = 'memcache';

    public function getModuleName()
    {
        return self::MODULE_NAME;
    }

    /**
     * @return \Memcache
     */
    public function getMemcacheAdapter()
    {
        return new \Memcache();
    }

    /**
     * @param CacheProvider $cacheProvider
     *
     * @return CacheProvider
     */
    protected function decorateWithConnectable(CacheProvider $cacheProvider)
    {
        $memcache = $this->getMemcacheAdapter();
        $settings = $this->config->getSettings();
        $memcache->connect($settings['host'], $settings['port']);

        $cacheProvider->setMemcache($memcache);

It seems like you code against a specific sub-type and not the parent class Doctrine\Common\Cache\CacheProvider as the method setMemcache() does only exist in the following sub-classes of Doctrine\Common\Cache\CacheProvider: Doctrine\Common\Cache\MemcacheCache. Maybe you want to instanceof check for one of these explicitly?

        return $cacheProvider;
    }

    /**
     * @param Config $config
     *
     * @return bool
     */
    protected function isValidConfig(Config $config)
    {
        $settings = $config->getSettings();
        if (!isset($settings['host'])) {
            return false;
        }

        if (!isset($settings['port'])) {
            return false;
        }

        return true;
    }
}