Payever\ExternalIntegration\Payments\Http\RequestEntity\CancelItemsPaymentRequest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	isValid()	0	3	3

<?php

/**
 * PHP version 5.4 and 8
 *
 * @category  RequestEntity
 * @package   Payever\Payments
 * @author    payever GmbH <service@payever.de>
 * @copyright 2017-2021 payever GmbH
 * @license   MIT <https://opensource.org/licenses/MIT>
 * @link      https://docs.payever.org/shopsystems/api/getting-started
 */

namespace Payever\ExternalIntegration\Payments\Http\RequestEntity;

use Payever\ExternalIntegration\Core\Http\RequestEntity;

/**
 * This class represents Refund Payment items RequestInterface Entity
 *
 * @method float getDeliveryFee()
 * @method self  setDeliveryFee(float $deliveryFee)
 * @method float getPaymentItems()
 * @method self  setPaymentItems(array $paymentItems)
 */
class CancelItemsPaymentRequest extends RequestEntity
{
    /** @var float $deliveryFee */
    protected $deliveryFee;

    /** @var PaymentItemEntity[] $paymentItems */
    protected $paymentItems;

    /**
     * {@inheritdoc}
     */
    public function isValid()
    {
        return parent::isValid() && (!$this->paymentItems || is_array($this->paymentItems));

The expression $this->paymentItems of type Payever\ExternalIntegration\Payments\Http\RequestEntity\PaymentItemEntity[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

    }
}