Payever\ExternalIntegration\Payments\Http\RequestEntity\ShippingGoodsPaymentRequest

Complexity

Total Complexity

17

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	isValid()	0	11	7
A	setPaymentItems()	0	21	5
A	setShippingDetails()	0	17	5

<?php

/**
 * PHP version 5.4 and 8
 *
 * @category  RequestEntity
 * @package   Payever\Payments
 * @author    payever GmbH <service@payever.de>
 * @copyright 2017-2021 payever GmbH
 * @license   MIT <https://opensource.org/licenses/MIT>
 * @link      https://docs.payever.org/shopsystems/api/getting-started
 */

namespace Payever\ExternalIntegration\Payments\Http\RequestEntity;

use Payever\ExternalIntegration\Core\Http\RequestEntity;

/**
 * This class represents Shipping Goods Payment RequestInterface Entity
 *
 * @method float                 getAmount()
 * @method self                  setAmount(float $amount)
 * @method float                 getDeliveryFee()
 * @method self                  setDeliveryFee(float $deliveryFee)
 * @method string                getReason()
 * @method self                  setReason(string $reason)
 * @method array                 getPaymentItems()
 * @method ShippingDetailsEntity getShippingDetails()
 * @method string                getInvoiceId()
 * @method self                  setInvoiceId(string $invoiceId)
 * @method string                getInvoiceUrl()
 * @method self                  setInvoiceUrl(string $invoiceUrl)
 * @method string                getPoNumber()
 * @method self                  setPoNumber(string $poNumber)
 */
class ShippingGoodsPaymentRequest extends RequestEntity
{
    /** @var string $reason */
    protected $reason;

    /** @var float $amount */
    protected $amount;

    /** @var float $deliveryFee */
    protected $deliveryFee;

    /** @var PaymentItemEntity[] $paymentItems */
    protected $paymentItems;

    /** @var ShippingDetailsEntity $shippingDetails */
    protected $shippingDetails;

    /** @var string $invoiceId */
    protected $invoiceId;

    /** @var string $invoiceUrl */
    protected $invoiceUrl;

    /** @var string $poNumber */
    protected $poNumber;

    /**
     * Sets Payment Items
     *
     * @param array|string $paymentItems
     *
     * @return $this
     */
    public function setPaymentItems($paymentItems)
    {
        if (!$paymentItems) {
            return $this;
        }

        if (is_string($paymentItems)) {
            $paymentItems = json_decode($paymentItems);
        }

        if (!is_array($paymentItems)) {
            return $this;
        }

        $this->paymentItems = [];

        foreach ($paymentItems as $item) {
            $this->paymentItems[] = new PaymentItemEntity($item);
        }

        return $this;
    }

    /**
     * Sets shipping details
     *
     * @param ShippingDetailsEntity|string $shippingDetails
     *
     * @return $this
     */
    public function setShippingDetails($shippingDetails)
    {
        if (!$shippingDetails) {
            return $this;
        }

        if (is_string($shippingDetails)) {
            $shippingDetails = json_decode($shippingDetails);
        }

        if (!is_array($shippingDetails) && !is_object($shippingDetails)) {
            return $this;
        }

        $this->shippingDetails = new ShippingDetailsEntity($shippingDetails);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function isValid()
    {
        if (is_array($this->paymentItems)) {

The condition is_array($this->paymentItems) is always true.

            foreach ($this->paymentItems as $item) {
                if (!$item instanceof PaymentItemEntity || !$item->isValid()) {
                    return false;
                }
            }
        }

        return parent::isValid() && (!$this->paymentItems || is_array($this->paymentItems));

The expression $this->paymentItems of type Payever\ExternalIntegration\Payments\Http\RequestEntity\PaymentItemEntity[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

    }
}