for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace PavelMironchik\BackupPanel\Http\Middleware;
use Closure;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use PavelMironchik\BackupPanel\BackupPanel;
class Authenticate
{
/**
* Handle the incoming request.
*
* @param Request $request
* @param Closure $next
* @return Response|void
*/
public function handle($request, $next)
return BackupPanel::check($request) ? $next($request) : abort(403);
abort(403)
null
This check looks for function or method calls that always return null and whose return value is used.
class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) {
The method getObject() can return nothing but null, so it makes no sense to use the return value.
getObject()
The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.
}
pavel-mironchik /
laravel-backup-panel
This check looks for function or method calls that always return null and whose return value is used.
The method
getObject()can return nothing but null, so it makes no sense to use the return value.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.