AlNiTest - Code Metrics - paulzi/yii2-auto-tree - Measure and Improve Code Quality continuously with Scrutinizer

AlNiTest A
last analyzed 2018-08-09 21:36 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	124
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	12
lcom	1
cbo	3
dl	124
loc	124
rs	10
c	0
b	0
f	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	getDataSet()	4	4	1
A	getModelClass()	4	4	1
A	testMakeRootInsert()	11	11	1
A	testMakeRootUpdate()	11	11	1
A	testPrependTo()	11	11	1
A	testPrependToAnotherTree()	11	11	1
A	testAppendTo()	11	11	1
A	testInsertBefore()	11	11	1
A	testInsertAfter()	11	11	1
A	testInsertAfterAnotherTree()	11	11	1
A	testDelete()	5	5	1
A	testDeleteWithChildren()	6	6	1

How to fix Duplicated Code

<?php
/**
 * @link https://github.com/paulzi/yii2-auto-tree
 * @copyright Copyright (c) 2015 PaulZi <[email protected]>
 * @license MIT (https://github.com/paulzi/yii2-auto-tree/blob/master/LICENSE)
 */

namespace paulzi\autotree\tests;

use paulzi\autotree\tests\models\NodeAlNi;
use Yii;

/**
 * @author PaulZi <[email protected]>
 * @group AlNi
 */
class AlNiTest extends AutoTreeTraitTestCase

{
    /**
     * @inheritdoc
     */
    public function getDataSet()
    {
        return new \PHPUnit_Extensions_Database_DataSet_ArrayDataSet(require(__DIR__ . '/data/data-ni.php'));
    }

    public function getModelClass()
    {
        return NodeAlNi::className();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function testMakeRootInsert()
    {
        $node = new NodeAlNi(['slug' => 'r']);
        $this->assertTrue($node->makeRoot()->save());

        $node->refresh();
        $this->assertEquals(null,       $node->parent_id);
        $this->assertEquals(0,          $node->lft);
        $this->assertEquals(2147483647, $node->rgt);
        $this->assertEquals(0,          $node->depth);
    }

    public function testMakeRootUpdate()
    {
        $node = NodeAlNi::findOne(9);

        $this->assertTrue($node->makeRoot()->save());

        $node->refresh();
        $this->assertEquals(null,       $node->parent_id);
        $this->assertEquals(0,          $node->lft);
        $this->assertEquals(2147483647, $node->rgt);
        $this->assertEquals(0,          $node->depth);
    }

    public function testPrependTo()
    {
        $node = new NodeAlNi(['slug' => 'new']);
        $this->assertTrue($node->prependTo(NodeAlNi::findOne(1))->save());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $node->refresh();
        $this->assertEquals(1, $node->parent_id);
        $this->assertEquals(1, $node->lft);
        $this->assertEquals(2, $node->rgt);
        $this->assertEquals(1, $node->depth);
    }

    public function testPrependToAnotherTree()
    {
        $node = NodeAlNi::findOne(30);

        $this->assertTrue($node->prependTo(NodeAlNi::findOne(4))->save());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $node->refresh();
        $this->assertEquals(4, $node->parent_id);
        $this->assertEquals(1091940810, $node->lft);
        $this->assertEquals(1419523107, $node->rgt);
        $this->assertEquals(2, $node->depth);
    }

    public function testAppendTo()
    {
        $node = NodeAlNi::findOne(10);

        $this->assertTrue($node->appendTo(NodeAlNi::findOne(18))->save());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $node->refresh();
        $this->assertEquals(18, $node->parent_id);
        $this->assertEquals(1000013, $node->lft);
        $this->assertEquals(1000024, $node->rgt);
        $this->assertEquals(4, $node->depth);
    }

    public function testInsertBefore()
    {
        $node = new NodeAlNi(['slug' => 'new']);
        $this->assertTrue($node->insertBefore(NodeAlNi::findOne(22))->save());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $node->refresh();
        $this->assertEquals(9, $node->parent_id);
        $this->assertEquals(300000005, $node->lft);
        $this->assertEquals(300000006, $node->rgt);
        $this->assertEquals(3, $node->depth);
    }

    public function testInsertAfter()
    {
        $node = NodeAlNi::findOne(32);

        $this->assertTrue($node->insertAfter(NodeAlNi::findOne(30))->save());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $node->refresh();
        $this->assertEquals(26, $node->parent_id);
        $this->assertEquals(2147483644, $node->lft);
        $this->assertEquals(2147483646, $node->rgt);
        $this->assertEquals(1, $node->depth);
    }

    public function testInsertAfterAnotherTree()
    {
        $node = NodeAlNi::findOne(26);

        $this->assertTrue($node->insertAfter(NodeAlNi::findOne(21))->save());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        $node->refresh();
        $this->assertEquals(9, $node->parent_id);
        $this->assertEquals(1031907726, $node->lft);
        $this->assertEquals(1784921473, $node->rgt);
        $this->assertEquals(3, $node->depth);
    }

    public function testDelete()
    {
        $this->assertEquals(1, NodeAlNi::findOne(30)->delete());

        $this->assertEquals(null, NodeAlNi::findOne(30));

    }

    public function testDeleteWithChildren()
    {
        $this->assertEquals(10, NodeAlNi::findOne(4)->deleteWithChildren());

        $this->assertEquals(null, NodeAlNi::findOne(24));

        $this->assertEquals(15, NodeAlNi::findOne(1)->deleteWithChildren());

    }
}

1		<?php
2		/**
3		* @link https://github.com/paulzi/yii2-auto-tree
4		* @copyright Copyright (c) 2015 PaulZi <[email protected]>
5		* @license MIT (https://github.com/paulzi/yii2-auto-tree/blob/master/LICENSE)
6		*/
7
8		namespace paulzi\autotree\tests;
9
10		use paulzi\autotree\tests\models\NodeAlNi;
11		use Yii;
12
13		/**
14		* @author PaulZi <[email protected]>
15		* @group AlNi
16		*/
17	View Code Duplication	class AlNiTest extends AutoTreeTraitTestCase
		0 ignored issues – show Duplication introduced 2015-12-11 17:02 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		/**
20		* @inheritdoc
21		*/
22		public function getDataSet()
23		{
24		return new \PHPUnit_Extensions_Database_DataSet_ArrayDataSet(require(__DIR__ . '/data/data-ni.php'));
25		}
26
27		public function getModelClass()
28		{
29		return NodeAlNi::className();
		0 ignored issues – show Bug Best Practice introduced 2015-12-11 17:02 UTC by Report Bug Copy Issue Report The return type of `return \paulzi\autotree\...\NodeAlNi::className();` (`string`) is incompatible with the return type of the parent method `paulzi\autotree\tests\Au...TestCase::getModelClass` of type `yii\db\BaseActiveRecord\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
30		}
31
32		public function testMakeRootInsert()
33		{
34		$node = new NodeAlNi(['slug' => 'r']);
35		$this->assertTrue($node->makeRoot()->save());
36
37		$node->refresh();
38		$this->assertEquals(null, $node->parent_id);

paulzi / yii2-auto-tree

AlNiTest A last analyzed 2018-08-09 21:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

AlNiTest A
last analyzed 2018-08-09 21:36 UTC