paul999\tfa\ucp\tfa_module

Complexity

Total Complexity

16

Size/Duplication

Total Lines	172
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	21
Bugs	3	Features	5

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setup()	0	7	1
A	main()	0	13	1
A	register_security_key()	0	22	3
B	createPage()	0	48	6
B	delete_keys()	0	21	5

<?php
/**
 *
 * 2FA extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2015 Paul Sohier
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */

namespace paul999\tfa\ucp;

use paul999\tfa\helper\registration_helper;
use paul999\tfa\helper\session_helper;
use paul999\u2f\Exceptions\U2fError;
use paul999\u2f\U2F;
use phpbb\db\driver\driver_interface;
use phpbb\request\request_interface;
use phpbb\template\template;
use phpbb\user;

class tfa_module
{
	/**
	 * @var string
	 */
	public $u_action;

	/**
	 * @var  string
	 */
	public $page_title;

	/**
	 * @var string
	 */
	public $tpl_name;

	/**
	 * @var user
	 */
	private $user;

	/**
	 * @var template
	 */
	private $template;

	/**
	 * @var request_interface
	 */
	private $request;

	/**
	 * @var session_helper
	 */
	private $session_helper;

	/**
	 * @param user $user
	 * @param template $template
	 * @param request_interface $request
	 * @param session_helper $session_helper
	 */
	private function setup(user $user, template $template, request_interface $request, session_helper $session_helper)
	{
		$this->user 				= $user;
		$this->template 			= $template;
		$this->request 				= $request;
		$this->session_helper 		= $session_helper;
	}

	/**
	 * @param $id
	 * @param $mode
	 */
	public function main($id, $mode)
	{
		global $user, $template;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

		global $request, $phpbb_container;

		$user->add_lang('posting');
		$user->add_lang_ext('paul999/tfa', 'ucp_tfa');
		$user->add_lang_ext('paul999/tfa', 'common');

		$this->setup($user, $template, $request, $phpbb_container->get('paul999.2fa.sessionHelper'));

		$this->createPage();
	}

	/**
	 * @param array $error
	 */
	private function register_security_key(&$error)
	{
		try {
			$class = $this->request->variable('class', '');
			$module = $this->session_helper->findModule($class);

			if ($module != null) {
				$module->register();

				meta_refresh(3, $this->u_action);
				$message = $this->user->lang['TFA_KEY_ADDED'] . '<br /><br />' . sprintf($this->user->lang['RETURN_UCP'], '<a href="' . $this->u_action . '">', '</a>');
				trigger_error($message);
			}
			else
			{
				$error[] = $this->user->lang('TFA_MODULE_NOT_FOUND', $class);
			}
		}
		catch (\Exception $e) {
			$error[] = $e->getMessage();
		}
	}

	/**
	 *
	 */
	private function createPage()
	{
		$submit = $this->request->variable('md', false, false, \phpbb\request\request_interface::POST);
		$error = array();
		$s_hidden_fields = '';

		add_form_key('ucp_tfa_keys');

		if ($submit)
		{
			$mode = $this->request->variable('md', '');
			if (!check_form_key('ucp_tfa_keys'))
			{
				$error[] = 'FORM_INVALID';
			}
			else
			{
				switch ($mode)
				{
					case 'delete':
						$this->delete_keys();
						break;

					case 'register':
						$this->register_security_key($error);
					break;

					default:
						$error[] = 'TFA_NO_MODE';
				}
			}

			// Replace "error" strings with their real, localised form
			$error = array_map(array($this->user, 'lang'), $error);
		}


		$this->template->assign_vars(array(
			'ERROR' 			=> (sizeof($error)) ? implode('<br />', $error) : '',
			'L_TITLE' 			=> $this->user->lang['UCP_TFA'],
			'S_HIDDEN_FIELDS' 	=> $s_hidden_fields,
			'S_UCP_ACTION' 		=> $this->u_action,
		));

		// Set desired template
		$this->tpl_name = 'ucp_tfa';
		$this->page_title = 'UCP_TFA';
	}

	/**
	 *
	 */
	private function delete_keys()
	{
		$keys = $this->request->variable('keys', array(''));
		if (!empty($keys))
		{
			foreach ($keys as $row)
			{
				if (isset($row['class']))
				{
					$module = $this->session_helper->findModule($row['class']);
					if ($module != null)
					{
						$module->delete($row);
					}
				}
			}
			meta_refresh(3, $this->u_action);
			$message = $this->user->lang['TFA_KEYS_DELETED'] . '<br /><br />' . sprintf($this->user->lang['RETURN_UCP'], '<a href="' . $this->u_action . '">', '</a>');
			trigger_error($message);
		}
	}
}