@@ -162,8 +162,7 @@ |
||
| 162 | 162 | // We simply return and continue the login procedure (The normal way :)), |
| 163 | 163 | // and will disable all pages untill he has added a 2FA key. |
| 164 | 164 | return; |
| 165 | - } |
|
| 166 | - else |
|
| 165 | + } else |
|
| 167 | 166 | { |
| 168 | 167 | $redirect = $this->request->variable('redirect', "{$this->root_path}index.{$this->php_ext}"); |
| 169 | 168 | if ($event['admin']) |
@@ -127,8 +127,7 @@ |
||
| 127 | 127 | if (!empty($default)) |
| 128 | 128 | { |
| 129 | 129 | $module = $this->session_helper->findModule($class); |
| 130 | - } |
|
| 131 | - else |
|
| 130 | + } else |
|
| 132 | 131 | { |
| 133 | 132 | foreach ($modules as $row) |
| 134 | 133 | { |
@@ -215,10 +215,12 @@ discard block |
||
| 215 | 215 | |
| 216 | 216 | if (property_exists($response, 'errorCode')) |
| 217 | 217 | { |
| 218 | - if ($response->errorCode == 4) // errorCode 4 means that this device wasn't registered |
|
| 218 | + if ($response->errorCode == 4) { |
|
| 219 | + // errorCode 4 means that this device wasn't registered |
|
| 219 | 220 | { |
| 220 | 221 | throw new AccessDeniedHttpException($this->user->lang('TFA_NOT_REGISTERED')); |
| 221 | 222 | } |
| 223 | + } |
|
| 222 | 224 | throw new BadRequestHttpException($this->user->lang('TFA_SOMETHING_WENT_WRONG')); |
| 223 | 225 | } |
| 224 | 226 | $result = new AuthenticationResponse($response->signatureData, $response->clientData, $response->keyHandle, $response->errorCode); |
@@ -232,12 +234,10 @@ discard block |
||
| 232 | 234 | |
| 233 | 235 | $sql = 'UPDATE ' . $this->registration_table . ' SET ' . $this->db->sql_build_array('UPDATE', $sql_ary) . ' WHERE registration_id = ' . (int)$reg->id; |
| 234 | 236 | $this->db->sql_query($sql); |
| 235 | - } |
|
| 236 | - catch (U2fError $error) |
|
| 237 | + } catch (U2fError $error) |
|
| 237 | 238 | { |
| 238 | 239 | $this->createError($error); |
| 239 | - } |
|
| 240 | - catch (\InvalidArgumentException $invalid) |
|
| 240 | + } catch (\InvalidArgumentException $invalid) |
|
| 241 | 241 | { |
| 242 | 242 | throw new BadRequestHttpException($this->user->lang('TFA_SOMETHING_WENT_WRONG') . '<br />' . $invalid->getMessage(), $invalid); |
| 243 | 243 | } |
@@ -274,8 +274,7 @@ discard block |
||
| 274 | 274 | if ($count == 0) |
| 275 | 275 | { |
| 276 | 276 | trigger_error('TFA_UNABLE_TO_UPDATE_SESSION'); |
| 277 | - } |
|
| 278 | - else if ($count > 1) |
|
| 277 | + } else if ($count > 1) |
|
| 279 | 278 | { |
| 280 | 279 | // Reset sessions table. We had multiple sessions with same ID!!! |
| 281 | 280 | $sql_ary['u2f_request'] = ''; |
@@ -319,8 +318,7 @@ discard block |
||
| 319 | 318 | ); |
| 320 | 319 | |
| 321 | 320 | $this->update_session($sql_ary); |
| 322 | - } |
|
| 323 | - catch (U2fError $err) |
|
| 321 | + } catch (U2fError $err) |
|
| 324 | 322 | { |
| 325 | 323 | $this->createError($err); |
| 326 | 324 | } |
@@ -101,13 +101,11 @@ discard block |
||
| 101 | 101 | meta_refresh(3, $this->u_action); |
| 102 | 102 | $message = $this->user->lang['TFA_KEY_ADDED'] . '<br /><br />' . sprintf($this->user->lang['RETURN_UCP'], '<a href="' . $this->u_action . '">', '</a>'); |
| 103 | 103 | trigger_error($message); |
| 104 | - } |
|
| 105 | - else |
|
| 104 | + } else |
|
| 106 | 105 | { |
| 107 | 106 | $error[] = $this->user->lang('TFA_MODULE_NOT_FOUND', $class); |
| 108 | 107 | } |
| 109 | - } |
|
| 110 | - catch (\Exception $e) |
|
| 108 | + } catch (\Exception $e) |
|
| 111 | 109 | { |
| 112 | 110 | $error[] = $e->getMessage(); |
| 113 | 111 | } |
@@ -130,8 +128,7 @@ discard block |
||
| 130 | 128 | if (!check_form_key('ucp_tfa_keys')) |
| 131 | 129 | { |
| 132 | 130 | $error[] = 'FORM_INVALID'; |
| 133 | - } |
|
| 134 | - else |
|
| 131 | + } else |
|
| 135 | 132 | { |
| 136 | 133 | switch ($mode) |
| 137 | 134 | { |