PhpUnitGen\Parser\NodeParserTrait\VisibilityTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	parseVisibility()	0	12	4

<?php

namespace PhpUnitGen\Parser\NodeParserTrait;

use PhpParser\Node;
use PhpUnitGen\Model\PropertyInterface\VisibilityInterface;

/**
 * Trait VisibilityTrait.
 *
 * @author     Paul Thébaud <paul.thebaud29@gmail.com>.
 * @copyright  2017-2018 Paul Thébaud <paul.thebaud29@gmail.com>.
 * @license    https://opensource.org/licenses/MIT The MIT license.
 * @link       https://github.com/paul-thebaud/phpunit-generator
 * @since      Class available since Release 2.0.0.
 */
trait VisibilityTrait
{
    /**
     * Retrieve the visibility of a node.
     *
     * @param Node $node The node.
     *
     * @return int The visibility as an integer.
     */
    protected function parseVisibility(Node $node): int
    {
        if (! method_exists($node, 'isPrivate')) {
            return VisibilityInterface::UNKNOWN;

The expression return PhpUnitGen\Model\PropertyInterface\VisibilityInterface::UNKNOWN returns the type null which is incompatible with the type-hinted return integer.

        }
        if ($node->isPrivate()) {
            return VisibilityInterface::PRIVATE;
        }
        if ($node->isProtected()) {

The method isProtected() does not exist on PhpParser\Node. It seems like you code against a sub-type of PhpParser\Node such as PhpParser\Node\Stmt\Property or PhpParser\Node\Stmt\ClassMethod or PhpParser\Node\Stmt\ClassConst or PhpParser\Node\Stmt\ClassMethod.

            return VisibilityInterface::PROTECTED;
        }
        return VisibilityInterface::PUBLIC;
    }
}