Completed
Push — master ( 25c559...a6b7ae )
by Tolan
02:24
created
lib/AbstractViewComponent.php 2 patches
Braces   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         if ($execMethodName) { // Used to test for null but it could easily be an empty string
172 172
             $this->log( "Rendering with exec: {$execMethodName}, args:".var_export($execArgs, true ), LogLevel::DEBUG );
173 173
             $out = $this->execMethod( $execMethodName, $execArgs );
174
-        }else {
174
+        } else {
175 175
             $this->log( "Rendering without exec", LogLevel::DEBUG );
176 176
             $out = $this->template->render( $this->state, $this->props );
177 177
             if (!( $out instanceof ViewComponentResponse )) {
@@ -197,12 +197,12 @@  discard block
 block discarded – undo
197 197
         if (count( $methodName ) == 1) {
198 198
             $methodName = $methodName[ 0 ] . 'Handler';
199 199
             $out = $this->$methodName( $args );
200
-        }else {
200
+        } else {
201 201
             $childName = array_shift( $methodName );
202 202
             $child = $this->childComponents[ $childName ];
203 203
             if ($child instanceof AbstractViewComponent) {
204 204
                 $out = $child->execMethod( $methodName, $args );
205
-            }else {
205
+            } else {
206 206
                 throw new \Exception( implode( ".", $methodName ) . " is not a valid method." );
207 207
             }
208 208
         }
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
         }
284 284
         if (null !== ( $pPath = $this->parent->getPath() )) {
285 285
             return $pPath . '.' . $this->handle;
286
-        }else {
286
+        } else {
287 287
             return $this->handle;
288 288
         }
289 289
     }
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
             }
307 307
             $child = new $type( $handle, $this, $this->exec, $this->logger );
308 308
             $this->childComponents[ $handle ] = $child;
309
-        }else {
309
+        } else {
310 310
             // exec, di and logger are set recursively in rehydrate()
311 311
             $child = $this->childComponents[ $handle ];
312 312
         }
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
     }
143 143
 
144 144
     /**
145
-     * @return array
145
+     * @return string[]
146 146
      */
147 147
     public function __sleep()
148 148
     {
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     /**
185 185
      * Execute a component method within the page or component.
186 186
      * Called first on a top level component which then passes the call down to the appropriate sub-component (or executes on itself if appropriate).
187
-     * @param array|string $methodName A methodname in the format subComponent.anotherSubComponent.methodName. Either dotted string as described, or parts in an array. The top level page component shouldn't be included
187
+     * @param string $methodName A methodname in the format subComponent.anotherSubComponent.methodName. Either dotted string as described, or parts in an array. The top level page component shouldn't be included
188 188
      * @param array $args
189 189
      * @throws \Exception
190 190
      * @return Response
@@ -213,6 +213,9 @@  discard block
 block discarded – undo
213 213
         return $out;
214 214
     }
215 215
 
216
+    /**
217
+     * @param string $execMethod
218
+     */
216 219
     public function getExecPath( $execMethod )
217 220
     {
218 221
         $path = $this->getPath();
@@ -318,7 +321,7 @@  discard block
 block discarded – undo
318 321
      * Render a child component.
319 322
      *
320 323
      * @param $handle
321
-     * @return Response
324
+     * @return string
322 325
      * @throws \Exception
323 326
      */
324 327
     public function renderChild( $handle )
Please login to merge, or discard this patch.
lib/Template/TwigTemplate.php 2 patches
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
 
101 101
         if (class_exists( "Puli\\TwigExtension\\PuliExtension" ) && null !== $this->repo) {
102 102
             $loader = new \Twig_Loader_Chain( [ new PuliTemplateLoader( $this->repo ), new Twig_Loader_String() ] );
103
-        }else {
103
+        } else {
104 104
             $loader = new Twig_Loader_String();
105 105
         }
106 106
         return $loader;
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,9 +69,9 @@
 block discarded – undo
69 69
     }
70 70
 
71 71
     /**
72
-     * @param array|ViewState $state
72
+     * @param ViewState $state
73 73
      * @param array $props
74
-     * @return string
74
+     * @return Response
75 75
      */
76 76
     protected function doRender( ViewState $state, array $props = [] )
77 77
     {
Please login to merge, or discard this patch.
lib/Response.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,8 +27,8 @@
 block discarded – undo
27 27
     public $content;
28 28
 
29 29
     /**
30
-     * @param $type
31
-     * @param $content
30
+     * @param string $type
31
+     * @param string $content
32 32
      * @param null $responseCode
33 33
      */
34 34
     function __construct( $type, $content, $responseCode = null )
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
         if( null == $responseCode ){
41 41
             if( $type == "redirect" ){
42 42
                 $responseCode = 301;
43
-            }else{
43
+            } else{
44 44
                 $responseCode = 200;
45 45
             }
46 46
         }
Please login to merge, or discard this patch.