Response - Code Metrics - Inspection of "Merge branch 'release/1.0.0'" - patternseek/componentview - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e1c899...25c559 )

by Tolan

created 2016-02-22 13:03 UTC

Response A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	0
cbo	0
dl	0
loc	34
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	3

<?php
/*
 * This file is part of the Patternseek ComponentView library.
 *
 * (c) 2014 Tolan Blundell <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace PatternSeek\ComponentView;

/**
 * Class ViewComponentResponse
 */
class Response
{

    /**
     * Currently one of "redirect" or a valid MIME type.
     * @var string
     */
    public $type;
    /**
     * @var string
     */
    public $content;

    /**
     * @param $type
     * @param $content
     * @param null $responseCode
     */
    function __construct( $type, $content, $responseCode = null )

    {
        $this->type = $type;
        $this->content = $content;
        
        // Response code defaults
        if( null == $responseCode ){
            if( $type == "redirect" ){
                $responseCode = 301;
            }else{
                $responseCode = 200;
            }
        }
        $this->responseCode = $responseCode;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2			/*
3			* This file is part of the Patternseek ComponentView library.
4			*
5			* (c) 2014 Tolan Blundell <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace PatternSeek\ComponentView;
12
13			/**
14			* Class ViewComponentResponse
15			*/
16			class Response
17			{
18
19			/**
20			* Currently one of "redirect" or a valid MIME type.
21			* @var string
22			*/
23			public $type;
24			/**
25			* @var string
26			*/
27			public $content;
28
29			/**
30			* @param $type
31			* @param $content
32			* @param null $responseCode
33			*/
34			function __construct( $type, $content, $responseCode = null )
			0 ignored issues – show Best Practice introduced 2016-02-22 13:05 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
35			{
36			$this->type = $type;
37			$this->content = $content;
38
39			// Response code defaults
40			if( null == $responseCode ){
41			if( $type == "redirect" ){
42			$responseCode = 301;
43			}else{
44			$responseCode = 200;
45			}
46			}
47			$this->responseCode = $responseCode;
			0 ignored issues – show Bug introduced 2016-02-22 13:05 UTC by Report Bug Copy Issue Report The property `responseCode` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
48			}
49			}
50

patternseek / componentview

Push — master ( e1c899...25c559 )

Response A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like