Passed
Push — master ( 6228a9...3cc130 )
by Patrick
01:58
created
library/Trapdirector/TrapsActions/UIDatabase.php 1 patch
Spacing   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -24,10 +24,10 @@  discard block
 block discarded – undo
24 24
      * @param int $code
25 25
      * @param Exception $previous
26 26
      */
27
-    public function __construct(array $retarray, string $message = null, int $code = 0, Exception $previous = null)
27
+    public function __construct(array $retarray, string $message=null, int $code=0, Exception $previous=null)
28 28
     {
29
-        parent::__construct($message,$code,$previous);
30
-        $this->returnArray = $retarray;
29
+        parent::__construct($message, $code, $previous);
30
+        $this->returnArray=$retarray;
31 31
     }
32 32
     
33 33
     /**
@@ -83,19 +83,19 @@  discard block
 block discarded – undo
83 83
      * @return bool true if OK, false if version < min version
84 84
      * @throws Exception if error and test = true
85 85
      */
86
-    protected function testDbVersion($dbAdapter,int $min,bool $test, string $DBname)
86
+    protected function testDbVersion($dbAdapter, int $min, bool $test, string $DBname)
87 87
     {
88 88
         try
89 89
         {
90
-            $query = $dbAdapter->select()
91
-            ->from($this->trapController->getModuleConfig()->getDbConfigTableName(),'value')
90
+            $query=$dbAdapter->select()
91
+            ->from($this->trapController->getModuleConfig()->getDbConfigTableName(), 'value')
92 92
             ->where('name=\'db_version\'');
93 93
             $version=$dbAdapter->fetchRow($query);
94
-            if ( ($version == null) || ! property_exists($version,'value') )
94
+            if (($version == null) || !property_exists($version, 'value'))
95 95
             {
96 96
                 if ($test === true) 
97 97
                 {
98
-                    $this->testResult = array(4,$DBname);
98
+                    $this->testResult=array(4, $DBname);
99 99
                     return false;
100 100
                 }
101 101
                 $this->trapController->redirectNow('trapdirector/settings?dberror=4');
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
             {
106 106
                 if ($test === true) 
107 107
                 {
108
-                    $this->testResult = array(5,$version->value,$min);
108
+                    $this->testResult=array(5, $version->value, $min);
109 109
                     return false;
110 110
                 }
111 111
                 $this->trapController->redirectNow('trapdirector/settings?dberror=5');
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
         {
117 117
             if ($test === true) 
118 118
             {
119
-                $this->testResult = array(3,$DBname,$e->getMessage());
119
+                $this->testResult=array(3, $DBname, $e->getMessage());
120 120
                 return false;
121 121
             }
122 122
             $this->trapController->redirectNow('trapdirector/settings?dberror=4');
@@ -132,17 +132,17 @@  discard block
 block discarded – undo
132 132
      *  @throws DBException if test = true and error
133 133
      *	@return Zend_Db_Adapter_Abstract|null : if test=false, returns DB connexion, else array(error_num,message) or null on error.
134 134
      */
135
-    protected function getDbByName($DBname , $test = false , $test_version = true)
135
+    protected function getDbByName($DBname, $test=false, $test_version=true)
136 136
     {
137 137
         try
138 138
         {
139
-            $dbconn = IcingaDbConnection::fromResourceName($DBname);
139
+            $dbconn=IcingaDbConnection::fromResourceName($DBname);
140 140
         }
141 141
         catch (Exception $e)
142 142
         {
143 143
             if ($test === true) 
144 144
             {
145
-                throw new DBException(array(2,$DBname));
145
+                throw new DBException(array(2, $DBname));
146 146
             }
147 147
             $this->trapController->redirectNow('trapdirector/settings?dberror=2');
148 148
             return null;
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
         {
158 158
             if ($test === true)
159 159
             {
160
-                throw new DBException(array(3,$DBname,$e->getMessage()));
160
+                throw new DBException(array(3, $DBname, $e->getMessage()));
161 161
             }
162 162
             $this->trapController->redirectNow('trapdirector/settings?dberror=3');
163 163
             return null;
@@ -181,18 +181,18 @@  discard block
 block discarded – undo
181 181
      */
182 182
     public function getDb()
183 183
     {
184
-        if ( $this->trapDB != null ) return $this->trapDB;
184
+        if ($this->trapDB != null) return $this->trapDB;
185 185
         
186 186
         $dbresource=$this->trapController->Config()->get('config', 'database');
187 187
         
188
-        if ( ! $dbresource )
188
+        if (!$dbresource)
189 189
         {
190 190
             $this->trapController->redirectNow('trapdirector/settings?dberror=1');
191 191
             return null;
192 192
         }
193 193
 
194 194
         try {
195
-            $this->trapDB = $this->getDbByName($dbresource,false,true);
195
+            $this->trapDB=$this->getDbByName($dbresource, false, true);
196 196
         } catch (DBException $e) {
197 197
             return null; // Should not happen as test = false
198 198
         }
@@ -210,12 +210,12 @@  discard block
 block discarded – undo
210 210
     {       
211 211
         $dbresource=$this->trapController->Config()->get('config', 'database');
212 212
         
213
-        if ( ! $dbresource )
213
+        if (!$dbresource)
214 214
         {
215
-                throw new DBException(array(1,''));
215
+                throw new DBException(array(1, ''));
216 216
         }
217 217
         
218
-        $this->trapDB = $this->getDbByName($dbresource,true,true);       
218
+        $this->trapDB=$this->getDbByName($dbresource, true, true);       
219 219
         return;
220 220
     }
221 221
     
@@ -228,9 +228,9 @@  discard block
 block discarded – undo
228 228
     {
229 229
         if ($this->idoDB != null && $test === false) return $this->idoDB;
230 230
         // TODO : get ido database directly from icingaweb2 config -> (or not if using only API)
231
-        $dbresource=$this->trapController->Config()->get('config', 'IDOdatabase');;
231
+        $dbresource=$this->trapController->Config()->get('config', 'IDOdatabase'); ;
232 232
         
233
-        if ( ! $dbresource )
233
+        if (!$dbresource)
234 234
         {
235 235
             $this->redirectNow('trapdirector/settings?idodberror=1');
236 236
             return null;
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
         
239 239
         try
240 240
         {
241
-            $dbconn = IcingaDbConnection::fromResourceName($dbresource);
241
+            $dbconn=IcingaDbConnection::fromResourceName($dbresource);
242 242
         }
243 243
         catch (Exception $e)
244 244
         {
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
             return null;
247 247
         }
248 248
 
249
-        $this->idoDB = $dbconn->getDbAdapter();
249
+        $this->idoDB=$dbconn->getDbAdapter();
250 250
         return $this->idoDB;
251 251
     }
252 252
 
@@ -258,35 +258,35 @@  discard block
 block discarded – undo
258 258
     public function testGetIdoDb()
259 259
     {
260 260
         // TODO : get ido database directly from icingaweb2 config -> (or not if using only API)
261
-        $dbresource=$this->trapController->Config()->get('config', 'IDOdatabase');;
261
+        $dbresource=$this->trapController->Config()->get('config', 'IDOdatabase'); ;
262 262
         
263
-        if ( ! $dbresource )
263
+        if (!$dbresource)
264 264
         {
265
-            throw new DBException(array(1,'No database in config.ini'));
265
+            throw new DBException(array(1, 'No database in config.ini'));
266 266
         }
267 267
         
268 268
         try
269 269
         {
270
-            $dbconn = IcingaDbConnection::fromResourceName($dbresource);
270
+            $dbconn=IcingaDbConnection::fromResourceName($dbresource);
271 271
         }
272 272
         catch (Exception $e)
273 273
         {
274
-            throw new DBException( array(2,"Database $dbresource does not exists in IcingaWeb2") );
274
+            throw new DBException(array(2, "Database $dbresource does not exists in IcingaWeb2"));
275 275
         }
276 276
                
277 277
         try
278 278
         {
279
-            $query = $dbconn->select()
280
-            ->from('icinga_dbversion',array('version'));
279
+            $query=$dbconn->select()
280
+            ->from('icinga_dbversion', array('version'));
281 281
             $version=$dbconn->fetchRow($query);
282
-            if ( ($version == null) || ! property_exists($version,'version') )
282
+            if (($version == null) || !property_exists($version, 'version'))
283 283
             {
284
-                throw new DBException( array(4,"$dbresource does not look like an IDO database"));
284
+                throw new DBException(array(4, "$dbresource does not look like an IDO database"));
285 285
             }
286 286
         }
287 287
         catch (Exception $e)
288 288
         {
289
-            throw new DBException( array(3,"Error connecting to $dbresource : " . $e->getMessage()));
289
+            throw new DBException(array(3, "Error connecting to $dbresource : ".$e->getMessage()));
290 290
         }
291 291
         
292 292
         return;
Please login to merge, or discard this patch.