patrickpr / trapdirector

bin/trap_class.php

Braces +122 added lines, -78 removed lines

@@ -96,8 +96,7 @@ 
 	        }
 	        $this->trapLog($message,$log_level,'syslog');
 	        return false;
-	    }
-	    else
+	    } else
 	    {
 	        $option_var=$option_array[$option_category][$option_name];
 	        return true;
@@ -144,7 +143,9 @@ 
 	protected function getDBConfigIfSet($element,&$variable)
 	{
 		$value=$this->getDBConfig($element);
-		if ($value != 'null') $variable=$value;
+		if ($value != 'null') {
+			$variable=$value;
+		}
 	}
 	
 	/** Get data from db_config
@@ -180,8 +181,11 @@ 
 			$message = '['.  date("Y/m/d H:i:s") . '] ' .
 				'['. basename(__FILE__) . '] ['.$this->debug_text[$level].']: ' .$message . "\n";
 			
-			if ( $destination != '' ) $output=$destination;
-			else $output=$this->alert_output;
+			if ( $destination != '' ) {
+				$output=$destination;
+			} else {
+				$output=$this->alert_output;
+			}
 			switch ($output)
 			{
 				case 'file':
@@ -216,7 +220,9 @@ 
 		switch ($output_type)
 		{
 			case 'file':
-			    if ($output_option == null) throw new Exception("File logging without file !");
+			    if ($output_option == null) {
+			    	throw new Exception("File logging without file !");
+			    }
 				$this->debug_file=$output_option;
 				$this->alert_output='file';
 				break;
@@ -311,16 +317,14 @@ 
 				$this->trapLog("No Config/database in config file: ".$this->trap_module_config,ERROR,''); 
 			}
 			$db_name=$trap_config['config']['database'];
-		} 
-		else if ($database == 'ido')
+		} else if ($database == 'ido')
 		{
 			if (!isset($trap_config['config']['IDOdatabase'])) 
 			{
 				$this->trapLog("No Config/IDOdatabase in config file: ".$this->trap_module_config,ERROR,''); 
 			}
 			$db_name=$trap_config['config']['IDOdatabase'];		
-		}
-		else
+		} else
 		{
 			$this->trapLog("Unknown database type : ".$database,ERROR,''); 		
 		}	
@@ -339,8 +343,12 @@ 
 		$db_sql_name=$db_config[$db_name]['dbname'];
 		$db_user=$db_config[$db_name]['username'];
 		$db_pass=$db_config[$db_name]['password'];
-		if ($database == 'traps') $this->trapDBType = $db_type;
-		if ($database == 'ido') $this->idoDBType = $db_type;
+		if ($database == 'traps') {
+			$this->trapDBType = $db_type;
+		}
+		if ($database == 'ido') {
+			$this->idoDBType = $db_type;
+		}
 		
 		$this->trapLog( "DB selected : $db_type $db_host $db_sql_name $db_user",3,''); 
 		return array($db_type,$db_host,$db_sql_name,$db_user,$db_pass);
@@ -381,8 +389,7 @@ 
 		{
 		    $this->writeTrapErrorToDB("Error parsing trap (code 2/IP)");
 			$this->trapLog('Error parsing IP : '.$IP,ERROR,'');
-		} 
-		else 
+		} else 
 		{		
 			$this->trap_data['source_ip']=$matches[1];
 			$this->trap_data['destination_ip']=$matches[3];
@@ -396,14 +403,12 @@ 
 			if ($ret_code===0 || $ret_code===false) 
 			{
 				$this->trapLog('No match on trap data : '.$vars,WARN,'');
-			}
-			else 
+			} else 
 			{
 			    if (($matches[1]=='.1.3.6.1.6.3.1.1.4.1.0') || ($matches[1]=='.1.3.6.1.6.3.1.1.4.1'))
 				{
 					$this->trap_data['trap_oid']=$matches[2];				
-				}
-				else
+				} else
 				{
 					$object= new stdClass;
 					$object->oid =$matches[1];
@@ -574,7 +579,9 @@ 
 	            }
 	            
 	            $inserted_id=$ret_code->fetch(PDO::FETCH_ASSOC)['LAST_INSERT_ID()'];
-	            if ($inserted_id==false) throw new Exception("Weird SQL error : last_insert_id returned false : open issue");
+	            if ($inserted_id==false) {
+	            	throw new Exception("Weird SQL error : last_insert_id returned false : open issue");
+	            }
 	            $this->trap_id=$inserted_id;
 	            break;
 	        default:
@@ -590,7 +597,9 @@ 
 	{
 		
 		// If action is ignore -> don't send t DB
-		if ($this->trap_to_db == false) return;
+		if ($this->trap_to_db == false) {
+			return;
+		}
 		
 		
 		$db_conn=$this->db_connect_trap();
@@ -647,7 +656,9 @@ 
 				}
 
 				$inserted_id=$ret_code->fetch(PDO::FETCH_ASSOC)['LAST_INSERT_ID()'];
-				if ($inserted_id==false) throw new Exception("Weird SQL error : last_insert_id returned false : open issue");
+				if ($inserted_id==false) {
+					throw new Exception("Weird SQL error : last_insert_id returned false : open issue");
+				}
 				$this->trap_id=$inserted_id;
 			break;
 			default: 
@@ -776,8 +787,7 @@ 
     		// TODO : file_put_contents & fopen (,'w' or 'a') does not work. See why. Or not as using API will be by default....
     		exec('echo "'.$send.'" > ' .$this->icinga2cmd);
     		return true;
-	    }
-	    else
+	    } else
 	    {
 	        $api = $this->getAPI();
 	        $api->setCredentials($this->api_username, $this->api_password);
@@ -786,8 +796,7 @@ 
 	        {
 	            $this->trapLog( "Error sending result : " .$retmessage,WARN,'');
 	            return false;
-	        }
-	        else 
+	        } else 
 	        {
 	            $this->trapLog( "Sent result : " .$retmessage,3,'');
 	            return true;
@@ -847,7 +856,9 @@ 
 	/***************** Eval & tokenizer functions ****************/
 	protected function eval_getElement($rule,&$item)
 	{
-		while ($rule[$item]==' ') $item++;
+		while ($rule[$item]==' ') {
+			$item++;
+		}
 		if (preg_match('/[0-9\.]/',$rule[$item]))
 		{ // number
 	
@@ -874,14 +885,15 @@ 
 			$start=$item;
 			$parenthesis_count=0; 
 			while (($item < strlen($rule)) // Not end of string AND
-			      && ( ($rule[$item] != ')' ) || $parenthesis_count > 0) ) // Closing ')' or embeded ()
+			      && ( ($rule[$item] != ')' ) || $parenthesis_count > 0) ) {
+				// Closing ')' or embeded ()
 			{ 
 				if ($rule[$item] == '"' )
 				{ // pass through string
 					$item++;
+			}
 					$item=$this->eval_getNext($rule,$item,'"');
-				} 
-				else{
+				} else{
 				    if ($rule[$item] == '(')
 				    {
 				        $parenthesis_count++;
@@ -909,13 +921,17 @@ 
 	protected function eval_getNext($rule,$item,$tok)
 	{
 		while (($rule[$item] != $tok ) && ($item < strlen($rule))) { $item++;}
-		if ($item==strlen($rule)) throw new Exception("closing '".$tok."' not found in ".$rule ." at " .$item);
+		if ($item==strlen($rule)) {
+			throw new Exception("closing '".$tok."' not found in ".$rule ." at " .$item);
+		}
 		return $item+1;
 	}
 	
 	protected function eval_getOper($rule,&$item)
 	{
-		while ($rule[$item]==' ') $item++;
+		while ($rule[$item]==' ') {
+			$item++;
+		}
 		switch ($rule[$item])
 		{
 			case '<':
@@ -951,12 +967,13 @@ 
 	public function evaluation($rule,&$item)
 	{
 	    //echo "Evaluation of ".substr($rule,$item)."\n";
-		if ( $rule[$item] == '!') // If '!' found, negate next expression.
+		if ( $rule[$item] == '!') {
+			// If '!' found, negate next expression.
 		{
 		    $negate=true;
-		    $item++;
 		}
-		else
+		    $item++;
+		} else
 		{
 		    $negate=false;
 		}
@@ -964,10 +981,14 @@ 
 		list($type1,$val1) = $this->eval_getElement($rule,$item);
 		//echo "Elmt1: ".$val1."/".$type1." : ".substr($rule,$item)."\n";
 		
-		if ($item==strlen($rule)) // If only element, return value, but only boolean
+		if ($item==strlen($rule)) {
+			// If only element, return value, but only boolean
 		{
 		  if ($type1 != 2) throw new Exception("Cannot use num/string as boolean : ".$rule);
-		  if ($negate == true) $val1= ! $val1;
+		}
+		  if ($negate == true) {
+		  	$val1= ! $val1;
+		  }
 		  return $val1;
 		}  
 		
@@ -976,27 +997,34 @@ 
 		//echo "Comp : ".$comp." : ".substr($rule,$item)."\n";
         
 		// Third element : number, string or ()
-		if ( $rule[$item] == '!') // starts with a ! so evaluate whats next
+		if ( $rule[$item] == '!') {
+			// starts with a ! so evaluate whats next
 		{
 		    $item++;
-		    if ($typec != 1) throw new Exception("Mixing boolean and comparison : ".$rule);
+		}
+		    if ($typec != 1) {
+		    	throw new Exception("Mixing boolean and comparison : ".$rule);
+		    }
 		    $val2= ! $this->evaluation($rule,$item);
 		    $type2=2; // result is a boolean 
-		}
-		else 
+		} else 
 		{
 		    list($type2,$val2) = $this->eval_getElement($rule,$item);
 		}
 		//echo "Elmt2: ".$val2."/".$type2." : ".substr($rule,$item)."\n";
 		
-		if ($type1!=$type2)  // cannot compare different types
+		if ($type1!=$type2) {
+			// cannot compare different types
 		{ 
 		    throw new Exception("Cannot compare string & number : ".$rule);
 		}
-		if ($typec==1 && $type1 !=2) // cannot use & or | with string/number
+		}
+		if ($typec==1 && $type1 !=2) {
+			// cannot use & or | with string/number
 		{
 		    throw new Exception("Cannot use boolean operators with string & number : ".$rule);
 		}
+		}
 		
 		switch ($comp){
 			case '<':	$retVal= ($val1 < $val2); break;
@@ -1010,9 +1038,15 @@ 
 			case '&':	$retVal= ($val1 && $val2); break;
 			default:  throw new Exception("Error in expression - unknown comp : ".$comp);
 		}
-		if ($negate == true) $retVal = ! $retVal; // Inverse result if negate before expression
+		if ($negate == true) {
+			$retVal = ! $retVal;
+		}
+		// Inverse result if negate before expression
 		
-		if ($item==strlen($rule)) return $retVal; // End of string : return evaluation
+		if ($item==strlen($rule)) {
+			return $retVal;
+		}
+		// End of string : return evaluation
 		// check for logical operator :
 		switch ($rule[$item])
 		{
@@ -1039,7 +1073,9 @@ 
 					$rule2.=$rule[$item];
 					$item++;
 				}
-				if ($item == strlen ($rule)) throw new Exception("closing '\"' not found in ".$rule ." at " .$item);
+				if ($item == strlen ($rule)) {
+					throw new Exception("closing '\"' not found in ".$rule ." at " .$item);
+				}
 				$rule2.=$rule[$item];
 				$item++;
 				continue;
@@ -1059,10 +1095,12 @@ 
 	
 	protected function eval_rule($rule)
 	{
-		if ($rule==null || $rule == '') // Empty rule is always true
+		if ($rule==null || $rule == '') {
+			// Empty rule is always true
 		{
 			return true;
 		}
+		}
 		$matches=array();
 		while (preg_match('/_OID\(([0-9\.\*]+)\)/',$rule,$matches) == 1)
 		{
@@ -1149,20 +1187,17 @@ 
 						if ($this->serviceCheckResult($host_name,$service_name,$action,$display) == false)
 						{
 						    $this->trap_action.='Error sending status : check cmd/API';
-						}
-						else
+						} else
 						{
 						    $this->add_rule_match($rule['id'],$rule['num_match']+1);
 						    $this->trap_action.='Status '.$action.' to '.$host_name.'/'.$service_name;
 						}
-					}
-					else
+					} else
 					{
 						$this->add_rule_match($rule['id'],$rule['num_match']+1);
 					}
 					$this->trap_to_db=($action==-2)?false:true;
-				}
-				else
+				} else
 				{
 					//$this->trapLog('rules KOO : '.print_r($rule),3,'');
 					
@@ -1173,14 +1208,12 @@ 
 					    if ($this->serviceCheckResult($host_name,$service_name,$action,$display)==false)
 					    {
 					        $this->trap_action.='Error sending status : check cmd/API';
-					    }
-					    else
+					    } else
 					    {
     						$this->add_rule_match($rule['id'],$rule['num_match']+1);
     						$this->trap_action.='Status '.$action.' to '.$host_name.'/'.$service_name;
 					    }
-					}
-					else
+					} else
 					{
 						$this->add_rule_match($rule['id'],$rule['num_match']+1);
 					}
@@ -1190,16 +1223,14 @@ 
 				if (!isset($this->trap_data['source_name']))
 				{
 					$this->trap_data['source_name']=$rule['host_name'];
-				}
-				else
+				} else
 				{
 					if (!preg_match('/'.$rule['host_name'].'/',$this->trap_data['source_name']))
 					{ // only add if not present
 						$this->trap_data['source_name'].=','.$rule['host_name'];
 					}
 				}
-			}
-			catch (Exception $e) 
+			} catch (Exception $e) 
 			{ 
 			    $this->trapLog('Error in rule eval : '.$e->getMessage(),WARN,'');
 			    $this->trap_action.=' ERR : '.$e->getMessage();
@@ -1210,8 +1241,7 @@ 
 		if ($this->trap_data['status']=='error')
 		{
 		  $this->trap_to_db=true; // Always put errors in DB for the use can see
-		}
-		else
+		} else
 		{
 		  $this->trap_data['status']='done';
 		}
@@ -1265,8 +1295,7 @@ 
                 if (preg_match('/^ *CREATE TABLE ([^ ]+)/',$newline,$cur_table_array))
                 {
                     $cur_table='table '.$cur_table_array[1];
-                }
-                else
+                } else
                 {
                     $cur_table='secret SQL stuff :-)';
                 }
@@ -1310,8 +1339,7 @@ 
 	    if ($this->trapDBType == 'pgsql')
 	    {
 	        $prefix .= 'update_pgsql/schema_';
-	    }
-	    else
+	    } else
 	    {
 	        $prefix .= 'update_sql/schema_';
 	    }
@@ -1357,7 +1385,10 @@ 
 	       $db_conn->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
 	       while (($line=fgets($input_stream)) != FALSE)
 	       {
-	           if (preg_match('/^#/', $line)) continue; // ignore comment lines
+	           if (preg_match('/^#/', $line)) {
+	           	continue;
+	           }
+	           // ignore comment lines
 	           $newline.=chop(preg_replace('/#PREFIX#/',$table_prefix,$line));
 	           if (preg_match('/; *$/', $newline))
 	           {
@@ -1369,8 +1400,7 @@ 
 	               if (preg_match('/^ *([^ ]+) TABLE ([^ ]+)/',$newline,$cur_table_array))
 	               {
 	                   $cur_table=$cur_table_array[1] . ' SQL table '.$cur_table_array[2];
-	               }
-	               else
+	               } else
 	               {
 	                   $cur_table='secret SQL stuff :-)';
 	                   $cur_table=$newline;
@@ -1508,8 +1538,7 @@ 
 			    }
 			    $this->trapLog('Trap updated : '.$name . ' / OID : '.$oid,4,'');
 				return 1;
-			}
-			else
+			} else
 			{
 			    $this->trapLog('Trap unchanged : '.$name . ' / OID : '.$oid,4,'');
 			    return 0;
@@ -1525,7 +1554,9 @@ 
               'values (:oid, :name , :type ,:mib ,:tc , :display_hint'.
               ', :syntax, :type_enum, :description )';
         
-		if ($this->trapDBType == 'pgsql') $sql .= 'RETURNING id';
+		if ($this->trapDBType == 'pgsql') {
+			$sql .= 'RETURNING id';
+		}
 		
 		$sqlQuery=$db_conn->prepare($sql);
 		
@@ -1565,7 +1596,9 @@ 
 		        }
 		        
 		        $inserted_id=$ret_code->fetch(PDO::FETCH_ASSOC)['LAST_INSERT_ID()'];
-		        if ($inserted_id==false) throw new Exception("Weird SQL error : last_insert_id returned false : open issue");
+		        if ($inserted_id==false) {
+		        	throw new Exception("Weird SQL error : last_insert_id returned false : open issue");
+		        }
 		        $this->dbOidIndex[$oid]['id']=$inserted_id;
 		        break;
 		    default:
@@ -1818,12 +1851,14 @@ 
 			$name=$match[1]; // Name 
 			$type=$match[2]; // type (21=trap, 0: may be trap, else : not trap
 			
-			if ($type==0) // object type=0 : check if v1 trap
+			if ($type==0) {
+				// object type=0 : check if v1 trap
 			{
 				// Check if next is suboid -> in that case is cannot be a trap
 				if (preg_match("/^$oid/",$this->objectsAll[$curElement+1]))
 				{
 				    $time_check2 += microtime(true) - $time_1;
+			}
 				    $time_check2N++;
 					continue;
 				}		
@@ -1840,9 +1875,11 @@ 
 				// Force as trap.
 				$type=21;
 			}
-			if ($onlyTraps==true && $type!=21) // if only traps and not a trap, continue
+			if ($onlyTraps==true && $type!=21) {
+				// if only traps and not a trap, continue
 			{
 			    $time_check3 += microtime(true) - $time_1;
+			}
 				$time_check3N++;
 				continue;
 			}
@@ -1850,7 +1887,10 @@ 
 			$time_num_traps++;
 			
 			$this->trapLog('Found trap : '.$match[1] . ' / OID : '.$oid,3,'');
-			if ($display_progress) echo '#'; // echo a # when trap found
+			if ($display_progress) {
+				echo '#';
+			}
+			// echo a # when trap found
 				
 			// get trap objects & source MIB
 			unset($snmptrans);
@@ -1868,7 +1908,9 @@ 
 			$trapMib=$match[1];
 			
 			$numLine=1;$trapDesc='';
-			while (isset($snmptrans[$numLine]) && !preg_match('/^[\t ]+DESCRIPTION[\t ]+"(.*)/',$snmptrans[$numLine],$match)) $numLine++;
+			while (isset($snmptrans[$numLine]) && !preg_match('/^[\t ]+DESCRIPTION[\t ]+"(.*)/',$snmptrans[$numLine],$match)) {
+				$numLine++;
+			}
 			if (isset($snmptrans[$numLine]))
 			{
 			    $snmptrans[$numLine] = preg_replace('/^[\t ]+DESCRIPTION[\t ]+"/','',$snmptrans[$numLine]);
@@ -1890,7 +1932,9 @@ 
 			if (($update==0) && ($check_change==false))
 			{ // Trapd didn't change & force check disabled
 			    $time_objects += microtime(true) - $time_1;
-			    if ($display_progress) echo "C";
+			    if ($display_progress) {
+			    	echo "C";
+			    }
 			    continue;
 			}