Trapdirector\Mib::update_mib_database()

Complexity

Conditions	34
Paths	> 20000

Size

Total Lines	207
Code Lines	118

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function update_mib_database($display_progress=false,$check_change=false,$onlyTraps=true,$startOID='.1')

The parameter $startOID is not used and could be removed.

    {
        // Timing
        $timeTaken = microtime(true);
        $retVal=0;
        // Get all mib objects from all mibs
        $snmpCommand=$this->snmptranslate . ' -m ALL -M +'.$this->snmptranslate_dirs.' -On -Tto 2>/dev/null';

The property snmptranslate_dirs does not exist on Trapdirector\Mib. Did you maybe forget to declare it?

The property snmptranslate does not exist on Trapdirector\Mib. Did you maybe forget to declare it?

        $this->logging->log('Getting all traps : '.$snmpCommand,DEBUG );
        unset($this->objectsAll);

The property objectsAll does not exist on Trapdirector\Mib. Did you maybe forget to declare it?

        exec($snmpCommand,$this->objectsAll,$retVal);
        if ($retVal!=0)
        {
            $this->logging->log('error executing snmptranslate',ERROR,'');
        }
        
        // Get all mibs from databse to have a memory index
        
        $db_conn=$this->trapsDB->db_connect_trap();
        
        $sql='SELECT * from '.$this->trapsDB->dbPrefix.'mib_cache;';
        $this->logging->log('SQL query : '.$sql,DEBUG );
        if (($ret_code=$db_conn->query($sql)) === false) {
            $this->logging->log('No result in query : ' . $sql,ERROR,'');
        }
        $this->dbOidAll=$ret_code->fetchAll();

The property dbOidAll does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->dbOidIndex=array();

The property dbOidIndex does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        // Create the index for db;
        foreach($this->dbOidAll as $key=>$val)
        {
            $this->dbOidIndex[$val['oid']]['key']=$key;
            $this->dbOidIndex[$val['oid']]['id']=$val['id'];
        }
        
        // Count elements to show progress
        $numElements=count($this->objectsAll);
        $this->logging->log('Total snmp objects returned by snmptranslate : '.$numElements,INFO );
        
        $step=$basestep=$numElements/10; // output display of % done
        $num_step=0;
        $timeFiveSec = microtime(true); // Used for display a '.' every <n> seconds
        
        // Create index for trap objects
        $this->trapObjectsIndex=array();

The property trapObjectsIndex does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        
        // detailed timing (time_* vars)
        $time_parse1=$time_check1=$time_check2=$time_check3=$time_update=$time_objects=0;
        $time_parse1N=$time_check1N=$time_check2N=$time_check3N=$time_updateN=$time_objectsN=0;
        $time_num_traps=0;
        
        for ($curElement=0;$curElement < $numElements;$curElement++)
        {
            $time_1= microtime(true);
            if ((microtime(true)-$timeFiveSec) > 2 && $display_progress)
            { // echo a . every 2 sec
                echo '.';
                $timeFiveSec = microtime(true);
            }
            if ($curElement>$step)
            { // display progress
                $num_step++;
                $step+=$basestep;
                if ($display_progress)
                {
                    echo "\n" . ($num_step*10). '% : ';
                }
            }
            // Get oid or pass if not found
            if (!preg_match('/^\.[0-9\.]+$/',$this->objectsAll[$curElement]))
            {
                $time_parse1 += microtime(true) - $time_1;
                $time_parse1N ++;
                continue;
            }
            $oid=$this->objectsAll[$curElement];
            
            // get next line
            $curElement++;
            $match=$snmptrans=array();
            if (!preg_match('/ +([^\(]+)\(.+\) type=([0-9]+)( tc=([0-9]+))?( hint=(.+))?/',
                $this->objectsAll[$curElement],$match))
            {
                $time_check1 += microtime(true) - $time_1;
                $time_check1N++;
                continue;
            }
            
            $name=$match[1]; // Name
            $type=$match[2]; // type (21=trap, 0: may be trap, else : not trap
            
            if ($type==0) // object type=0 : check if v1 trap
            {
                // Check if next is suboid -> in that case is cannot be a trap
                if (preg_match("/^$oid/",$this->objectsAll[$curElement+1]))
                {
                    $time_check2 += microtime(true) - $time_1;
                    $time_check2N++;
                    continue;
                }
                unset($snmptrans);
                exec($this->snmptranslate . ' -m ALL -M +'.$this->snmptranslate_dirs.
                    ' -Td '.$oid . ' | grep OBJECTS ',$snmptrans,$retVal);
                if ($retVal!=0)
                {
                    $time_check2 += microtime(true) - $time_1;
                    $time_check2N++;
                    continue;
                }
                //echo "\n v1 trap found : $oid \n";
                // Force as trap.
                $type=21;
            }
            if ($onlyTraps===true && $type!=21) // if only traps and not a trap, continue
            {
                $time_check3 += microtime(true) - $time_1;
                $time_check3N++;
                continue;
            }
            
            $time_num_traps++;
            
            $this->logging->log('Found trap : '.$match[1] . ' / OID : '.$oid,INFO );
            if ($display_progress) echo '#'; // echo a # when trap found
            
            // get trap objects & source MIB
            unset($snmptrans);
            exec($this->snmptranslate . ' -m ALL -M +'.$this->snmptranslate_dirs.
                ' -Td '.$oid,$snmptrans,$retVal);
            if ($retVal!=0)
            {
                $this->logging->log('error executing snmptranslate',ERROR,'');
            }
            
            if (!preg_match('/^(.*)::/',$snmptrans[0],$match))
            {
                $this->logging->log('Error getting mib from trap '.$oid.' : ' . $snmptrans[0],1,'');
            }
            $trapMib=$match[1];
            
            $numLine=1;$trapDesc='';
            while (isset($snmptrans[$numLine]) && !preg_match('/^[\t ]+DESCRIPTION[\t ]+"(.*)/',$snmptrans[$numLine],$match)) $numLine++;
            if (isset($snmptrans[$numLine]))
            {
                $snmptrans[$numLine] = preg_replace('/^[\t ]+DESCRIPTION[\t ]+"/','',$snmptrans[$numLine]);
                
                while (isset($snmptrans[$numLine]) && !preg_match('/"/',$snmptrans[$numLine]))
                {
                    $trapDesc.=preg_replace('/[\t ]+/',' ',$snmptrans[$numLine]);
                    $numLine++;
                }
                if (isset($snmptrans[$numLine])) {
                    $trapDesc.=preg_replace('/".*/','',$snmptrans[$numLine]);
                    $trapDesc=preg_replace('/[\t ]+/',' ',$trapDesc);
                }
                
            }
            $update=$this->update_oid($oid,$trapMib,$name,$type,NULL,NULL,NULL,NULL,$trapDesc);
            $time_update += microtime(true) - $time_1; $time_1= microtime(true);
            
            if (($update==0) && ($check_change===false))
            { // Trapd didn't change & force check disabled
                $time_objects += microtime(true) - $time_1;
                if ($display_progress) echo "C";
                continue;
            }
            
            $synt=null;
            foreach ($snmptrans as $line)
            {
                if (preg_match('/OBJECTS.*\{([^\}]+)\}/',$line,$match))
                {
                    $synt=$match[1];
                }
            }
            if ($synt == null)
            {
                //echo "No objects for $trapOID\n";
                $time_objects += microtime(true) - $time_1;
                continue;
            }
            //echo "$synt \n";
            $trapObjects=array();
            while (preg_match('/ *([^ ,]+) *,* */',$synt,$match))
            {
                array_push($trapObjects,$match[1]);
                $synt=preg_replace('/'.$match[0].'/','',$synt);
            }
            
            $this->trap_objects($oid, $trapMib, $trapObjects, false);
            
            $time_objects += microtime(true) - $time_1;
            $time_objectsN++;
        }
        
        if ($display_progress)
        {
            echo "\nNumber of processed traps : $time_num_traps \n";
            echo "\nParsing : " . number_format($time_parse1+$time_check1,1) ." sec / " . ($time_parse1N+ $time_check1N)  . " occurences\n";
            echo "Detecting traps : " . number_format($time_check2+$time_check3,1) . " sec / " . ($time_check2N+$time_check3N) ." occurences\n";
            echo "Trap processing ($time_updateN): ".number_format($time_update,1)." sec , ";
            echo "Objects processing ($time_objectsN) : ".number_format($time_objects,1)." sec \n";
        }
        
        // Timing ends
        $timeTaken=microtime(true) - $timeTaken;
        if ($display_progress)
        {
            echo "Global time : ".round($timeTaken)." seconds\n";
        }
}