TrapDirectorTableOrder::getOrderQuery() - Code Metrics - Inspection of "DirectorTable split in traits" - patrickpr/trapdirector - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cb2842...994f5c )

by Patrick

created 2020-09-07 11:28 UTC

TrapDirectorTableOrder::getOrderQuery() A

↳ Parent: TrapDirectorTableOrder

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	11
rs	10

<?php

namespace Icinga\Module\Trapdirector\Tables;


trait TrapDirectorTableOrder
{ 
    /** @var array $order : (db column, 'ASC' | 'DESC') */
    protected $order = array();
    protected $orderQuery = '';   
    
   /***************** Ordering ********************/
    
    public function applyOrder()
    {
        if (count($this->order) == 0)
        {
            return $this;
        }
        $orderSQL='';
        foreach ($this->order as $column => $direction)
        {
            if ($orderSQL != "") $orderSQL.=',';
            
            $orderSQL .= $column . ' ' . $direction;
        }
        $this->query = $this->query->order($orderSQL);

        
        return $this;
    }
    
    public function setOrder(array $order)
    {
        $this->order = $order;
        return $this;
    }

    public function isOrderSet()
    {
        if (count($this->order) == 0) return FALSE;
        return TRUE;
    }
    
    public function getOrderQuery(array $getVars)
    {
        if (isset($getVars['o']))
        {
            $this->orderQuery = $getVars['o'];
            $match = array();
            if (preg_match('/(.*)(ASC|DESC)$/', $this->orderQuery , $match))
            {
                $orderArray=array($match[1] => $match[2]);
                echo "$match[1] => $match[2]";
                $this->setOrder($orderArray);
            }
        }
    }
    
    protected function curOrderQuery()
    {
        if ($this->orderQuery == '') return '';
        return 'o='.$this->orderQuery;
    }
        
}

1			<?php
2
3			namespace Icinga\Module\Trapdirector\Tables;
4
5
6			trait TrapDirectorTableOrder
7			{
8			/** @var array $order : (db column, 'ASC' \| 'DESC') */
9			protected $order = array();
10			protected $orderQuery = '';
11
12			/*************** Ordering ******************/
13
14			public function applyOrder()
15			{
16			if (count($this->order) == 0)
17			{
18			return $this;
19			}
20			$orderSQL='';
21			foreach ($this->order as $column => $direction)
22			{
23			if ($orderSQL != "") $orderSQL.=',';
24
25			$orderSQL .= $column . ' ' . $direction;
26			}
27			$this->query = $this->query->order($orderSQL);
			0 ignored issues – show Bug Best Practice introduced 2020-09-07 11:30 UTC by Report Bug Copy Issue Report The property `query` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
28
29			return $this;
30			}
31
32			public function setOrder(array $order)
33			{
34			$this->order = $order;
35			return $this;
36			}
37
38			public function isOrderSet()
39			{
40			if (count($this->order) == 0) return FALSE;
41			return TRUE;
42			}
43
44			public function getOrderQuery(array $getVars)
45			{
46			if (isset($getVars['o']))
47			{
48			$this->orderQuery = $getVars['o'];
49			$match = array();
50			if (preg_match('/(.*)(ASC\|DESC)$/', $this->orderQuery , $match))
51			{
52			$orderArray=array($match[1] => $match[2]);
53			echo "$match[1] => $match[2]";
54			$this->setOrder($orderArray);
55			}
56			}
57			}
58
59			protected function curOrderQuery()
60			{
61			if ($this->orderQuery == '') return '';
62			return 'o='.$this->orderQuery;
63			}
64
65			}

patrickpr / trapdirector

Push — master ( cb2842...994f5c )

TrapDirectorTableOrder::getOrderQuery() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like