ReceivedController::trapdetailAction() - Code Metrics - patrickpr/trapdirector - Measure and Improve Code Quality continuously with Scrutinizer

ReceivedController::trapdetailAction() C
last analyzed 2020-10-31 13:30 UTC

↳ Parent: ReceivedController

Complexity

Conditions	12
Paths	151

Size

Total Lines	94
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	12
eloc	54
c	1
b	0
f	0
nc	151
nop	0
dl	0
loc	94
rs	6.5416

How to fix Long Method Complexity

<?php

namespace Icinga\Module\TrapDirector\Controllers;

use Icinga\Web\Url;

use Exception;

use Icinga\Module\Trapdirector\TrapsController;

/** 
*/
class ReceivedController extends TrapsController
{
	/**
	 * List traps by date
	 */
	public function indexAction()
	{	
		$this->checkReadPermission();
		$this->prepareTabs()->activate('traps');

		$dbConn = $this->getUIDatabase()->getDb();
		if ($dbConn === null) throw new \ErrorException('uncatched db error');
		$this->getTrapListTable()->setConnection($dbConn);
		
		// Apply pagination limits
		$this->view->table=$this->applyPaginationLimits($this->getTrapListTable(),$this->getModuleConfig()->itemListDisplay());		
		
		// Set Filter
		//$postData=$this->getRequest()->getPost();
		$filter=array();
		$filter['q']=$this->params->get('q');//(isset($postData['q']))?$postData['q']:'';
		$filter['done']=$this->params->get('done');
		$this->view->filter=$filter;
		$this->view->table->updateFilter(Url::fromRequest(),$filter);
		
		//$this->view->filterEditor = $this->getTrapListTable()->getFilterEditor($this->getRequest());

	}

	/** 
	*	Trap detail page
	*/	
	public function trapdetailAction() 
	{
		
		$this->checkReadPermission();
		// set up tab
		$this->getTabs()->add('get',array(
			'active'	=> true,
			'label'		=> $this->translate('Detailed status'),
			'url'		=> Url::fromRequest()
		));
		// get id
		$trapid=$this->params->get('id');
		$this->view->trapid=$trapid;
		$queryArray=$this->getModuleConfig()->trapDetailQuery();
		
		$dbConn = $this->getUIDatabase()->getDbConn();
		if ($dbConn === null) throw new \ErrorException('uncatched db error');
		
		// URL to add a handler
		$this->view->addHandlerUrl=Url::fromPath(
			$this->getModuleConfig()->urlPath() . '/handler/add',
			array('fromid' => $trapid));
		// ***************  Get main data
		// extract columns and titles;
		$elmts=NULL;
		foreach ($queryArray as $key => $val) {
			$elmts[$key]=$val[1];
		}
		
		// Do DB query for trap. 
		try
		{
		    $query = $dbConn->select()
				->from($this->moduleConfig->getTrapTableName(),$elmts)
				->where('id=?',$trapid);
				$trapDetail=$dbConn->fetchRow($query);
			if ( $trapDetail == null) throw new Exception('No traps was found with id = '.$trapid);
		}
		catch (Exception $e)
		{
			$this->displayExitError('Trap detail',$e->getMessage());
			return;
		}

		// Store result in array (with Titles).
		foreach ($queryArray as $key => $val) {
			if ($key == 'timestamp') {
				$cval=strftime('%c',$trapDetail->$key);
			} else {
				$cval=$trapDetail->$key;
			}
			array_push($queryArray[$key],$cval);
		}
		$this->view->rowset = $queryArray;

		// **************   Check for additionnal data
		
		// extract columns and titles;
		$queryArrayData=$this->getModuleConfig()->trapDataDetailQuery();
		$data_elmts=NULL;
		foreach ($queryArrayData as $key => $val) {
			$data_elmts[$key]=$val[1];
		}
		try
		{		
		    $query = $dbConn->select()
				->from($this->moduleConfig->getTrapDataTableName(),$data_elmts)
				->where('trap_id=?',$trapid);
			$trapDetail=$dbConn->fetchAll($query);
		}
		catch (Exception $e)
		{
			$this->displayExitError('Trap detail',$e->getMessage());
		}
		// TODO : code this in a better & simpler way
		if ($trapDetail == null ) 
		{
			$this->view->data=false;
		}
		else
		{
			$this->view->data=true;
			// Store result in array.
			$trapval=array();
			foreach ($trapDetail as $key => $val) 
			{	
				$trapval[$key]=array();
				foreach (array_keys($queryArrayData) as $vkey ) 
				{
					array_push($trapval[$key],$val->$vkey);
				}
			}
			$this->view->data_val=$trapval;
			$this->view->data_title=$queryArrayData;
		}
	}

	/**
	 * List traps by hosts
	 */
	public function hostsAction()
	{
	    $this->checkReadPermission();
	    $this->prepareTabs()->activate('hosts');
	    
	    $dbConn = $this->getUIDatabase()->getDb();
	    if ($dbConn === null) throw new \ErrorException('uncatched db error');
	    
	    $this->getTrapHostListTable()->setConnection($dbConn);
	    
	    // Apply pagination limits
	    $this->view->table=$this->applyPaginationLimits($this->getTrapHostListTable(),$this->getModuleConfig()->itemListDisplay());
	    
	    // Set Filter
	    //$postData=$this->getRequest()->getPost();
	    $filter=array();
	    $filter['q']=$this->params->get('q');//(isset($postData['q']))?$postData['q']:'';
	    $filter['done']=$this->params->get('done');
	    $this->view->filter=$filter;
	    $this->view->table->updateFilter(Url::fromRequest(),$filter);
	}
	
	public function deleteAction()
	{
		$this->checkConfigPermission();
		$this->prepareTabs()->activate('delete');
				
		return;
	}
	
	/**
	 * Create tabs for /received
	 * @return object tabs
	 */
	protected function prepareTabs()
	{
		return $this->getTabs()->add('traps', array(
			'label'	=> $this->translate('Traps'),
			'url'   => $this->getModuleConfig()->urlPath() . '/received')
		    )
		    ->add('hosts', array(
		        'label' => $this->translate('Hosts'),
		        'url'   => $this->getModuleConfig()->urlPath() . '/received/hosts')
		    )
		    ->add('delete', array(
			'label' => $this->translate('Delete'),
			'url'   => $this->getModuleConfig()->urlPath() . '/received/delete')
		  );
	} 

	/**
	 * Helper to count / delete lines
	 * POST params : 
	 * - OID : partial oid of traps (if empty not used in filter)
	 * - IP : IP or partial IP of host (if empty not used in filter)
	 * - action : 
	 *     count : return JSON : status:OK, count : number of lines selected by filter
	 *     delete : delete traps selected by filter
	 */
	public function deletelinesAction()
	{
		$postData=$this->getRequest()->getPost();
		if (isset($postData['IP']) && isset($postData['OID']) && isset($postData['action']))
		{
			$ip=$postData['IP'];
			$oid=$postData['OID'];
			$action=$postData['action'];
		}
		else
		{
			$this->_helper->json(array('status'=>'Missing variables'));
			return;
		}
		if ($action =="count")
		{
			$this->_helper->json(array('status'=>'OK','count'=>$this->getUIDatabase()->countTrap($ip,$oid)));
			return;
		}
		if ($action =="delete")
		{
		    $this->_helper->json(array('status'=>'OK','count'=>$this->getUIDatabase()->deleteTrap($ip,$oid)));
			return;
		}		
		$this->_helper->json(array('status'=>'unknown action'));
	}
	
}

1			<?php
2
3			namespace Icinga\Module\TrapDirector\Controllers;
4
5			use Icinga\Web\Url;
6
7			use Exception;
8
9			use Icinga\Module\Trapdirector\TrapsController;
10
11			/**
12			*/
13			class ReceivedController extends TrapsController
14			{
15			/**
16			* List traps by date
17			*/
18			public function indexAction()
19			{
20			$this->checkReadPermission();
21			$this->prepareTabs()->activate('traps');
22
23			$dbConn = $this->getUIDatabase()->getDb();
24			if ($dbConn === null) throw new \ErrorException('uncatched db error');
25			$this->getTrapListTable()->setConnection($dbConn);
26
27			// Apply pagination limits
28			$this->view->table=$this->applyPaginationLimits($this->getTrapListTable(),$this->getModuleConfig()->itemListDisplay());
29
30			// Set Filter
31			//$postData=$this->getRequest()->getPost();
32			$filter=array();
33			$filter['q']=$this->params->get('q');//(isset($postData['q']))?$postData['q']:'';
34			$filter['done']=$this->params->get('done');
35			$this->view->filter=$filter;
36			$this->view->table->updateFilter(Url::fromRequest(),$filter);
37
38			//$this->view->filterEditor = $this->getTrapListTable()->getFilterEditor($this->getRequest());
39
40			}
41
42			/**
43			* Trap detail page
44			*/
45			public function trapdetailAction()
46			{
47
48			$this->checkReadPermission();
49			// set up tab
50			$this->getTabs()->add('get',array(
51			'active' => true,
52			'label' => $this->translate('Detailed status'),
53			'url' => Url::fromRequest()
54			));
55			// get id
56			$trapid=$this->params->get('id');
57			$this->view->trapid=$trapid;
58			$queryArray=$this->getModuleConfig()->trapDetailQuery();
59
60			$dbConn = $this->getUIDatabase()->getDbConn();
61			if ($dbConn === null) throw new \ErrorException('uncatched db error');
62
63			// URL to add a handler
64			$this->view->addHandlerUrl=Url::fromPath(
65			$this->getModuleConfig()->urlPath() . '/handler/add',
66			array('fromid' => $trapid));
67			// *************** Get main data
68			// extract columns and titles;
69			$elmts=NULL;
70			foreach ($queryArray as $key => $val) {
71			$elmts[$key]=$val[1];
72			}
73
74			// Do DB query for trap.
75			try
76			{
77			$query = $dbConn->select()
78			->from($this->moduleConfig->getTrapTableName(),$elmts)
79			->where('id=?',$trapid);
80			$trapDetail=$dbConn->fetchRow($query);
81			if ( $trapDetail == null) throw new Exception('No traps was found with id = '.$trapid);
82			}
83			catch (Exception $e)
84			{
85			$this->displayExitError('Trap detail',$e->getMessage());
86			return;
87			}
88
89			// Store result in array (with Titles).
90			foreach ($queryArray as $key => $val) {
91			if ($key == 'timestamp') {
92			$cval=strftime('%c',$trapDetail->$key);
93			} else {
94			$cval=$trapDetail->$key;
95			}
96			array_push($queryArray[$key],$cval);
97			}
98			$this->view->rowset = $queryArray;
99
100			// ************** Check for additionnal data
101
102			// extract columns and titles;
103			$queryArrayData=$this->getModuleConfig()->trapDataDetailQuery();
104			$data_elmts=NULL;
105			foreach ($queryArrayData as $key => $val) {
106			$data_elmts[$key]=$val[1];
107			}
108			try
109			{
110			$query = $dbConn->select()
111			->from($this->moduleConfig->getTrapDataTableName(),$data_elmts)
112			->where('trap_id=?',$trapid);
113			$trapDetail=$dbConn->fetchAll($query);
114			}
115			catch (Exception $e)
116			{
117			$this->displayExitError('Trap detail',$e->getMessage());
118			}
119			// TODO : code this in a better & simpler way
120			if ($trapDetail == null )
121			{
122			$this->view->data=false;
123			}
124			else
125			{
126			$this->view->data=true;
127			// Store result in array.
128			$trapval=array();
129			foreach ($trapDetail as $key => $val)
130			{
131			$trapval[$key]=array();
132			foreach (array_keys($queryArrayData) as $vkey )
133			{
134			array_push($trapval[$key],$val->$vkey);
135			}
136			}
137			$this->view->data_val=$trapval;
138			$this->view->data_title=$queryArrayData;
139			}
140			}
141
142			/**
143			* List traps by hosts
144			*/
145			public function hostsAction()
146			{
147			$this->checkReadPermission();
148			$this->prepareTabs()->activate('hosts');
149
150			$dbConn = $this->getUIDatabase()->getDb();
151			if ($dbConn === null) throw new \ErrorException('uncatched db error');
152
153			$this->getTrapHostListTable()->setConnection($dbConn);
154
155			// Apply pagination limits
156			$this->view->table=$this->applyPaginationLimits($this->getTrapHostListTable(),$this->getModuleConfig()->itemListDisplay());
157
158			// Set Filter
159			//$postData=$this->getRequest()->getPost();
160			$filter=array();
161			$filter['q']=$this->params->get('q');//(isset($postData['q']))?$postData['q']:'';
162			$filter['done']=$this->params->get('done');
163			$this->view->filter=$filter;
164			$this->view->table->updateFilter(Url::fromRequest(),$filter);
165			}
166
167			public function deleteAction()
168			{
169			$this->checkConfigPermission();
170			$this->prepareTabs()->activate('delete');
171
172			return;
173			}
174
175			/**
176			* Create tabs for /received
177			* @return object tabs
178			*/
179			protected function prepareTabs()
180			{
181			return $this->getTabs()->add('traps', array(
182			'label' => $this->translate('Traps'),
183			'url' => $this->getModuleConfig()->urlPath() . '/received')
184			)
185			->add('hosts', array(
186			'label' => $this->translate('Hosts'),
187			'url' => $this->getModuleConfig()->urlPath() . '/received/hosts')
188			)
189			->add('delete', array(
190			'label' => $this->translate('Delete'),
191			'url' => $this->getModuleConfig()->urlPath() . '/received/delete')
192			);
193			}
194
195			/**
196			* Helper to count / delete lines
197			* POST params :
198			* - OID : partial oid of traps (if empty not used in filter)
199			* - IP : IP or partial IP of host (if empty not used in filter)
200			* - action :
201			* count : return JSON : status:OK, count : number of lines selected by filter
202			* delete : delete traps selected by filter
203			*/
204			public function deletelinesAction()
205			{
206			$postData=$this->getRequest()->getPost();
207			if (isset($postData['IP']) && isset($postData['OID']) && isset($postData['action']))
208			{
209			$ip=$postData['IP'];
210			$oid=$postData['OID'];
211			$action=$postData['action'];
212			}
213			else
214			{
215			$this->_helper->json(array('status'=>'Missing variables'));
216			return;
217			}
218			if ($action =="count")
219			{
220			$this->_helper->json(array('status'=>'OK','count'=>$this->getUIDatabase()->countTrap($ip,$oid)));
221			return;
222			}
223			if ($action =="delete")
224			{
225			$this->_helper->json(array('status'=>'OK','count'=>$this->getUIDatabase()->deleteTrap($ip,$oid)));
226			return;
227			}
228			$this->_helper->json(array('status'=>'unknown action'));
229			}
230
231			}

patrickpr / trapdirector

ReceivedController::trapdetailAction() C last analyzed 2020-10-31 13:30 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

ReceivedController::trapdetailAction() C
last analyzed 2020-10-31 13:30 UTC