Icinga\Module\TrapDirector\Controllers\HandlerController::handlerformAction()

Complexity

Conditions	26
Paths	2381

Size

Total Lines	154
Code Lines	89

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
	protected function handlerformAction()
	{
		$postData=$this->getRequest()->getPost();
		//print_r($postData ).'<br>';
	
		$params=array(
			// id (also db) => 	array('post' => post id, 'val' => default val, 'db' => send to table)
			'hostgroup'		=>	array('post' => 'hostgroup',                    'db'=>false),
			'db_rule'		=>	array('post' => 'db_rule',                      'db'=>false),
			'hostid'		=>	array('post' => 'hostid',                       'db'=>false),
			'host_name'		=>	array('post' => 'hostname',      'val' => null,  'db'=>true),
			'host_group_name'=>	array('post' => null,            'val' => null,  'db'=>true),
			'serviceid'		=>	array('post' => 'serviceid',                     'db'=>false),
			'service_name'	=>	array('post' => 'serviceName',                    'db'=>true),
		    'comment'       =>  array('post' => 'comment',       'val' => '',    'db'=>true),
		    'rule_type'     =>  array('post' => 'category',       'val' => 0,    'db'=>true),
			'trap_oid'		=>	array('post' => 'oid',                            'db'=>true),
			'revert_ok'		=>	array('post' => 'revertOK',      'val' => 0,      'db'=>true),
			'display'		=>	array('post' => 'display',        'val' => '',     'db'=>true),
			'rule'			=>	array('post' => 'rule',          'val' => '',        'db'=>true),			
			'action_match'	=>	array('post' => 'ruleMatch',       'val' => -1,    'db'=>true),
			'action_nomatch'=>	array('post' => 'ruleNoMatch',    'val' => -1,    'db'=>true),					
			'ip4'			=>	array('post' => null,             'val' => null,  'db'=>true),
			'ip6'			=>	array('post' => null,             'val' => null,  'db'=>true),
		    'action_form'	=>	array('post' => 'action_form',    'val' => null, 'db'=>false)
		);
		
		if (isset($postData[$params['action_form']['post']]) 
			&& $postData[$params['action_form']['post']] == 'delete' )
		{
			try
			{
			    $this->getUIDatabase()->deleteRule($postData[$params['db_rule']['post']]);
			}
			catch (Exception $e)
			{
				$this->_helper->json(array('status'=>$e->getMessage(),'location'=>'Deleting Rule'));
				return;
			}
			//$this->Module()->
			$this->_helper->json(array(
				'status'=>'OK',
			    'redirect'=>'trapdirector/handler'
			      
			));
		}		
		foreach (array_keys($params) as $key)
		{
			if ($params[$key]['post']==null) continue; // data not sent in post vars
			if (! isset($postData[$params[$key]['post']]))
			{
				// should not happen as the js checks data
				$this->_helper->json(array('status'=>'No ' . $key));
			}
			else
			{
				$data=$postData[$params[$key]['post']];
				if ($data!=null && $data !="")
				{
					$params[$key]['val']=$postData[$params[$key]['post']];
				}
			}
		}
		$this->getIdoConn(); //Set apiMode
		try 
		{
			$isHostGroup=($params['hostgroup']['val'] == 1)?true:false;
			if (! $isHostGroup ) 
			{  // checks if selection by host 
			    $hostAddr=$this->getIdoConn()->getHostInfoByID($params['hostid']['val']);

It seems like $params['hostid']['val'] can also be of type false; however, parameter $name of Icinga\Module\Trapdirector\Icinga2API::getHostInfoByID() does only seem to accept string, maybe add an additional type check?

			    if ($hostAddr === NULL) throw new \Exception("No object found");
				$params['ip4']['val']=$hostAddr->ip4;
				$params['ip6']['val']=$hostAddr->ip6;
				$checkHostName=$hostAddr->name;
				if ($params['host_name']['val'] != $checkHostName) 
				{
					$this->_helper->json(array('status'=>"Invalid host id : Please re enter host name"));
					return;
				}
				if ($this->apiMode == TRUE)

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

				{
				    $serviceName=$this->getIdoConn()->getServiceById($params['serviceid']['val']);

The method getServiceById() does not exist on Icinga\Module\Trapdirector\TrapsActions\UIDatabase. Did you maybe mean getServicesByHostid()?

				    if (count($serviceName) == 0 )
				    {
				        $this->_helper->json(array('status'=>"Invalid service id : Please re enter service",'sent'=>$params['serviceid']['val'],'found'=>$serviceName[0]->__name));
				        return;
				    }
				}
				else
				{
    				if (!is_numeric($params['serviceid']['val']))
    				{
    				    $this->_helper->json(array('status'=>"Invalid service id ". $params['serviceid']['val']));

Are you sure $params['serviceid']['val'] of type false|string can be used in concatenation?

    				    return;
    				}
    				
    				$serviceName=$this->getUIDatabase()->getObjectNameByid($params['serviceid']['val']);

$params['serviceid']['val'] of type string is incompatible with the type integer expected by parameter $id of Icinga\Module\Trapdirector\TrapsActions\UIDatabase::getObjectNameByid().

    				if ($params['service_name']['val'] != $serviceName->name2)
    				{
    					$this->_helper->json(array('status'=>"Invalid service id : Please re enter service"));
    					return;
    				}
				}
			}
			else
			{
			    if ($this->apiMode == TRUE)

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

			    {
			        $object=$this->getIdoConn()->getHostGroupById($params['hostid']['val']);

The method getHostGroupById() does not exist on Icinga\Module\Trapdirector\TrapsActions\UIDatabase. Did you maybe mean getHostGroupByName()?

			        if (count($object) == 0 || $params['host_name']['val'] != $object->__name)
			        {
			            $this->_helper->json(array('status'=>"Invalid object group id : Please re enter service"));
			            return;
			        }
			    }
			    else 
			    {
    			    $object=$this->getUIDatabase()->getObjectNameByid($params['hostid']['val']);

$params['hostid']['val'] of type false|string is incompatible with the type integer expected by parameter $id of Icinga\Module\Trapdirector\TrapsActions\UIDatabase::getObjectNameByid().

    				if ($params['host_name']['val'] != $object->name1)
    				{
    					$this->_helper->json(array('status'=>"Invalid object group id : Please re enter service"));
    					return;					
    				}
			    }
				// Put param in correct column (group_name)
				$params['host_group_name']['val'] = $params['host_name']['val'];
				$params['host_name']['val']=null;
			}
			$dbparams=array();
			foreach ($params as $key=>$val)
			{
				if ($val['db']==true )
				{
					$dbparams[$key] = $val['val'];
				}
			}
			// echo '<br>';	print_r($dbparams);echo '<br>';
			
			if ($params['db_rule']['val'] == -1 || $params['action_form']['val'] == 'clone') 
			{  // If no rule number or action is clone, add the handler
			    $ruleID=$this->getUIDatabase()->addHandlerRule($dbparams);
			}
			else
			{
			    $this->getUIDatabase()->updateHandlerRule($dbparams,$params['db_rule']['val']);
				$ruleID=$params['db_rule']['val'];
			}
		}
		catch (Exception $e)
		{
		    $this->_helper->json(array('status'=>$e->getMessage(),'location'=>'Add/update Rule','line'=>$e->getLine(),'file'=>$e->getFile()));
			return;
		}
		$this->_helper->json(array('status'=>'OK', 'id' => $ruleID));
		
}