Router::resolve() - Code Metrics - Inspection of "Fixed psalm errors" - patoui/router - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2f9e73...76a949 )

by Patrique

created 2019-12-22 14:42 UTC

Router::resolve() A

↳ Parent: Router

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

declare(strict_types=1);

namespace Patoui\Router;

use Psr\Http\Message\ServerRequestInterface;

class Router
{
    /* @var array<Routable> */
    private $routes;

    public function __construct()
    {
        $this->routes = [];
    }

    public function addRoute(Routable $routable) : void
    {
        $this->routes[] = $routable;
    }

    /**
     * @return array
     */
    public function getRoutes() : array
    {
        return $this->routes;
    }

    /**
     * @param  ServerRequestInterface $serverRequest
     * @return mixed TODO: should be Routable but php-psalm throwing errors.
     * @throws RouteNotFoundException
     */
    public function resolve(ServerRequestInterface $serverRequest)
    {
        /* @var $route Routable */
        foreach ($this->routes as $route) {
            if ($route->isHttpVerbAndPathAMatch($serverRequest->getMethod(), $serverRequest->getRequestTarget())) {
                return $route;
            }
        }

        throw new RouteNotFoundException('Route not found');
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Patoui\Router;
6
7			use Psr\Http\Message\ServerRequestInterface;
8
9			class Router
10			{
11			/* @var array<Routable> */
12			private $routes;
13
14			public function __construct()
15			{
16			$this->routes = [];
17			}
18
19			public function addRoute(Routable $routable) : void
20			{
21			$this->routes[] = $routable;
22			}
23
24			/**
25			* @return array
26			*/
27			public function getRoutes() : array
28			{
29			return $this->routes;
30			}
31
32			/**
33			* @param ServerRequestInterface $serverRequest
34			* @return mixed TODO: should be Routable but php-psalm throwing errors.
35			* @throws RouteNotFoundException
36			*/
37			public function resolve(ServerRequestInterface $serverRequest)
38			{
39			/* @var $route Routable */
40			foreach ($this->routes as $route) {
41			if ($route->isHttpVerbAndPathAMatch($serverRequest->getMethod(), $serverRequest->getRequestTarget())) {
42			return $route;
43			}
44			}
45
46			throw new RouteNotFoundException('Route not found');
47			}
48			}
49

patoui / router

GitHub Access Token became invalid

Push — master ( 2f9e73...76a949 )

Router::resolve() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like