CustomOffer::getYmlAttributes() - Code Metrics - Inspection of "Update yml version" - pastuhov/yii2-yml-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#39)

unknown

created 2017-05-19 07:58 UTC

CustomOffer::getYmlAttributes() A

↳ Parent: CustomOffer

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	9
rs	9.6666
cc	1
eloc	6
nc	1
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: execut
 * Date: 4/28/17
 * Time: 10:11 AM
 */

namespace pastuhov\ymlcatalog\models;


use yii\helpers\ArrayHelper;

class CustomOffer extends Offer
{
    public $model;
    public $vendor;
    public $vendorCode;
    public $typePrefix;
    public $type = 'vendor.model';
    /**
     * @inheritdoc
     */
    public static function getTagProperties() {
        return ArrayHelper::merge(parent::getTagProperties(), [
            'type'
        ]);
    }

    public function getYmlAttributes()
    {
        return ArrayHelper::merge(parent::getYmlAttributes(), [
            'model',
            'vendor',
            'vendorCode',
            'typePrefix',
        ]);
    }
    /**
     * @inheritdoc
     */
    public function rules()

    {
        return ArrayHelper::merge(parent::rules(), [
            [['type', 'model', 'vendor'], 'required'],
            [['model', 'vendor', 'vendorCode', 'typePrefix'], 'string', 'max' => 200],
        ]);
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: execut
5		* Date: 4/28/17
6		* Time: 10:11 AM
7		*/
8
9		namespace pastuhov\ymlcatalog\models;
10
11
12		use yii\helpers\ArrayHelper;
13
14		class CustomOffer extends Offer
15		{
16		public $model;
17		public $vendor;
18		public $vendorCode;
19		public $typePrefix;
20		public $type = 'vendor.model';
21		/**
22		* @inheritdoc
23		*/
24		public static function getTagProperties() {
25		return ArrayHelper::merge(parent::getTagProperties(), [
26		'type'
27		]);
28		}
29
30		public function getYmlAttributes()
31		{
32		return ArrayHelper::merge(parent::getYmlAttributes(), [
33		'model',
34		'vendor',
35		'vendorCode',
36		'typePrefix',
37		]);
38		}
39		/**
40		* @inheritdoc
41		*/
42	View Code Duplication	public function rules()
		0 ignored issues – show Duplication introduced 2017-05-18 07:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		return ArrayHelper::merge(parent::rules(), [
45		[['type', 'model', 'vendor'], 'required'],
46		[['model', 'vendor', 'vendorCode', 'typePrefix'], 'string', 'max' => 200],
47		]);
48		}
49		}

pastuhov / yii2-yml-catalog

Pull Request — master (#39)

CustomOffer::getYmlAttributes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like