MySql::storeNewTicket() - Code Metrics - Inspection of "Update .scrutinizer.yml; includes config previousl..." - parsingphase/takeAticket - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dd13da...b61209 )

by Richard

created 2017-02-26 15:35 UTC

MySql::storeNewTicket() A

↳ Parent: MySql

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	10
nc	2
nop	2

<?php
/**
 * Created by PhpStorm.
 * User: wechsler
 * Date: 04/10/15
 * Time: 21:08
 */

namespace Phase\TakeATicket\DataSource;

class MySql extends AbstractSql
{
    /**
     * {@inheritdoc}
     */
    protected function concatenateEscapedFields($fields)
    {
        return 'CONCAT('.implode(', ', $fields).')';
    }

    /**
     * Overridden to take advantage of autoIds
     *
     * @param $title
     * @param $songId
     *
     * @return int|false
     */
    public function storeNewTicket($title, $songId)
    {
        $conn = $this->getDbConn();
        $max = $conn->fetchAssoc('SELECT max(`offset`) AS o FROM tickets');

        $maxOffset = $max['o'];
        $ticket = [
            'title' => $title,
            'offset' => $maxOffset + 1,
            'songId' => $songId,
        ];
        $res = $conn->insert(self::TICKETS_TABLE, $ticket);

        return $res ? $conn->lastInsertId() : false;

    }

    /**
     * Overridden to take advantage of autoIds
     *
     * @param $performerName
     * @param bool|false    $createMissing
     *
     * @return mixed
     */
    public function fetchPerformerIdByName($performerName, $createMissing = false)
    {
        $conn = $this->getDbConn();
        $sql = 'SELECT id FROM performers p WHERE p.name LIKE :name LIMIT 1';
        $performerId = $conn->fetchColumn($sql, ['name' => $performerName]);

        if ($createMissing && !$performerId) {
            $conn->insert(self::PERFORMERS_TABLE, ['name' => ucwords($performerName)]);
            //add new performer row
            $performerId = $conn->lastInsertId();
        }

        return $performerId;
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: wechsler
5			* Date: 04/10/15
6			* Time: 21:08
7			*/
8
9			namespace Phase\TakeATicket\DataSource;
10
11			class MySql extends AbstractSql
12			{
13			/**
14			* {@inheritdoc}
15			*/
16			protected function concatenateEscapedFields($fields)
17			{
18			return 'CONCAT('.implode(', ', $fields).')';
19			}
20
21			/**
22			* Overridden to take advantage of autoIds
23			*
24			* @param $title
25			* @param $songId
26			*
27			* @return int\|false
28			*/
29			public function storeNewTicket($title, $songId)
30			{
31			$conn = $this->getDbConn();
32			$max = $conn->fetchAssoc('SELECT max(`offset`) AS o FROM tickets');
33
34			$maxOffset = $max['o'];
35			$ticket = [
36			'title' => $title,
37			'offset' => $maxOffset + 1,
38			'songId' => $songId,
39			];
40			$res = $conn->insert(self::TICKETS_TABLE, $ticket);
41
42			return $res ? $conn->lastInsertId() : false;
			0 ignored issues – show Bug Compatibility introduced 2016-06-29 16:23 UTC by Report Bug Copy Issue Report The expression `$res ? $conn->lastInsertId() : false;` of type `string\|false` adds the type `string` to the return on line 42 which is incompatible with the return type of the parent method `Phase\TakeATicket\DataSo...ractSql::storeNewTicket` of type `integer\|false`. Loading history...
43			}
44
45			/**
46			* Overridden to take advantage of autoIds
47			*
48			* @param $performerName
49			* @param bool\|false $createMissing
50			*
51			* @return mixed
52			*/
53			public function fetchPerformerIdByName($performerName, $createMissing = false)
54			{
55			$conn = $this->getDbConn();
56			$sql = 'SELECT id FROM performers p WHERE p.name LIKE :name LIMIT 1';
57			$performerId = $conn->fetchColumn($sql, ['name' => $performerName]);
58
59			if ($createMissing && !$performerId) {
60			$conn->insert(self::PERFORMERS_TABLE, ['name' => ucwords($performerName)]);
61			//add new performer row
62			$performerId = $conn->lastInsertId();
63			}
64
65			return $performerId;
66			}
67			}
68

parsingphase / takeAticket

GitHub Access Token became invalid

Push — master ( dd13da...b61209 )

MySql::storeNewTicket() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like