Phase\TakeATicket\SongLoader\RowMapperManager

Complexity

Total Complexity

10

Size/Duplication

Total Lines	92
Duplicated Lines	11.96 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	2
A	getRowMapperByShortName()	0	5	2
A	getRowMapperClassByShortName()	0	5	2
A	getRowMapperShortNames()	0	4	1
A	getRowMappers()	0	4	1
A	validateClass()	11	11	2

<?php
/**
 * Created by PhpStorm.
 * User: wechsler
 * Date: 03/03/2017
 * Time: 20:09
 */

namespace Phase\TakeATicket\SongLoader;

use Doctrine\DBAL\Connection;
use Phase\TakeATicket\DataSource\Factory;

class RowMapperManager
{

    /**
     * @var string[]
     */
    protected $rowMapperClasses = [];

    /**
     * @var Connection
     */
    protected $dbConn;

    /**
     * @var RowMapperInterface[]
     */
    protected $rowMappers;

    /**
     * RowMapperManager constructor.
     * @param Connection $dbConn
     * @param \string[] $rowMapperClasses
     */
    public function __construct(Connection $dbConn, array $rowMapperClasses)
    {
        $this->dbConn = $dbConn;
        $dataStore = Factory::datasourceFromDbConnection($dbConn);
        $this->rowMapperClasses = $rowMapperClasses;

It seems like $rowMapperClasses of type array<integer,object<string>> is incompatible with the declared type array<integer,string> of property $rowMapperClasses.

        foreach ($rowMapperClasses as $class) {
            $this->validateClass($class);
            $mapper = new $class($dataStore);
            /** @var RowMapperInterface $mapper */
            $this->rowMappers[strtolower($mapper->getShortName())] = $mapper;
        }
    }

    /**
     * Get the registered row mapper with the specified short name
     *
     * @param $shortName
     * @return null|RowMapperInterface
     */
    public function getRowMapperByShortName($shortName)
    {
        $shortName = strtolower($shortName);
        return array_key_exists($shortName, $this->rowMappers) ? $this->rowMappers[$shortName] : null;
    }

    /**
     * Get the registered row mapper with the specified short name
     *
     * @param $shortName
     * @return null|RowMapperInterface
     */
    public function getRowMapperClassByShortName($shortName)
    {
        $mapper = $this->getRowMapperByShortName($shortName);
        return $mapper ? get_class($mapper) : null;
    }

    public function getRowMapperShortNames()
    {
        return array_keys($this->rowMappers);
    }

    /**
     * @return RowMapperInterface[]
     */
    public function getRowMappers()
    {
        return $this->rowMappers;
    }

    /**
     * Ensure that provided classname is a valid RowMapperInterface
     *
     * @param $rowMapperClass
     * @throws \InvalidArgumentException
     */
    protected function validateClass($rowMapperClass)

This method seems to be duplicated in your project.

    {
        $class = new \ReflectionClass($rowMapperClass);
        if ($class->isSubclassOf(RowMapperInterface::class)) {
            $this->rowMapperClass = $rowMapperClass;

The property rowMapperClass does not seem to exist. Did you mean rowMapperClasses?

        } else {
            throw new \InvalidArgumentException(
                "$rowMapperClass must implement " . RowMapperInterface::class
            );
        }
    }
}