RssController::upcomingRssAction() - Code Metrics - Inspection of "Make config setup part of install step" - parsingphase/takeAticket - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 23c71a...dcb9a9 )

by Richard

created 2017-02-12 15:33 UTC

RssController::upcomingRssAction() A

↳ Parent: RssController

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	7
nc	2
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: wechsler
 * Date: 28/01/2017
 * Time: 18:36
 */

namespace Phase\TakeATicketBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Response;

class RssController extends BaseController
{
    public function upcomingRssAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $viewParams = []; //$this->defaultViewParams();

        $includePrivate = false; //$this->app['security']->isGranted(self::MANAGER_REQUIRED_ROLE);

        $viewParams['tickets'] = $this->getDataStore()->fetchUpcomingTickets($includePrivate);
        $data = $this->render('default/upcoming.rss.twig', $viewParams);
        $headers = empty($_GET['nt']) ? ['Content-type' => 'application/rss+xml'] : ['Content-type' => 'text/plain'];

        return new Response($data, 200, $headers);
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: wechsler
5			* Date: 28/01/2017
6			* Time: 18:36
7			*/
8
9			namespace Phase\TakeATicketBundle\Controller;
10
11			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
12			use Symfony\Component\HttpFoundation\Response;
13
14			class RssController extends BaseController
15			{
16			public function upcomingRssAction()
			0 ignored issues – show Coding Style introduced 2017-02-12 15:44 UTC by Report Bug Copy Issue Report `upcomingRssAction` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
17			{
18			$viewParams = []; //$this->defaultViewParams();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-12 15:44 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
19			$includePrivate = false; //$this->app['security']->isGranted(self::MANAGER_REQUIRED_ROLE);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-12 15:44 UTC by Report Bug Copy Issue Report `79%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20			$viewParams['tickets'] = $this->getDataStore()->fetchUpcomingTickets($includePrivate);
21			$data = $this->render('default/upcoming.rss.twig', $viewParams);
22			$headers = empty($_GET['nt']) ? ['Content-type' => 'application/rss+xml'] : ['Content-type' => 'text/plain'];
23
24			return new Response($data, 200, $headers);
25			}
26			}
27

parsingphase / takeAticket

GitHub Access Token became invalid

Push — master ( 23c71a...dcb9a9 )

RssController::upcomingRssAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like