CssController::customCssAction() - Code Metrics - parsingphase/takeAticket - Measure and Improve Code Quality continuously with Scrutinizer

CssController::customCssAction() B
last analyzed 2017-06-14 13:44 UTC

↳ Parent: CssController

Complexity

Conditions	4
Paths	4

Size

Total Lines	25
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	15
nc	4
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: wechsler
 * Date: 24/02/2017
 * Time: 20:39
 */

namespace Phase\TakeATicketBundle\Controller;

use Symfony\Component\HttpFoundation\Response;

class CssController extends BaseController
{
    public function customCssAction()
    {
        $backgroundFilename = $this->getDataStore()->fetchSetting('backgroundFilename');
        $customCss = $this->getDataStore()->fetchSetting('customCss');
        $backgroundFullPath = dirname($this->get('kernel')->getRootDir()) . '/web/uploads/' . $backgroundFilename;

        $backgroundUrl = null;
        if ($backgroundFilename && file_exists($backgroundFullPath)) {
            $backgroundUrl = '/uploads/' . $backgroundFilename;
        }

        $headers = ['Content-type' => 'text/css'];

        $data = '';

        if ($backgroundUrl) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $data .= "body {\n\tbackground-image: url('$backgroundUrl');\n\tbackground-size: cover;\n}\n";
            $data .= "@media only screen and (max-device-width: 480px)" .
                "\n{\tbody {\n\tbackground-image: none !important;\n\t}\n}";
        }

        $data .= $customCss;

        return new Response($data, 200, $headers);
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: wechsler
5			* Date: 24/02/2017
6			* Time: 20:39
7			*/
8
9			namespace Phase\TakeATicketBundle\Controller;
10
11			use Symfony\Component\HttpFoundation\Response;
12
13			class CssController extends BaseController
14			{
15			public function customCssAction()
16			{
17			$backgroundFilename = $this->getDataStore()->fetchSetting('backgroundFilename');
18			$customCss = $this->getDataStore()->fetchSetting('customCss');
19			$backgroundFullPath = dirname($this->get('kernel')->getRootDir()) . '/web/uploads/' . $backgroundFilename;
20
21			$backgroundUrl = null;
22			if ($backgroundFilename && file_exists($backgroundFullPath)) {
23			$backgroundUrl = '/uploads/' . $backgroundFilename;
24			}
25
26			$headers = ['Content-type' => 'text/css'];
27
28			$data = '';
29
30			if ($backgroundUrl) {
			0 ignored issues – show Bug Best Practice introduced 2017-02-26 15:36 UTC by Report Bug Copy Issue Report The expression `$backgroundUrl` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
31			$data .= "body {\n\tbackground-image: url('$backgroundUrl');\n\tbackground-size: cover;\n}\n";
32			$data .= "@media only screen and (max-device-width: 480px)" .
33			"\n{\tbody {\n\tbackground-image: none !important;\n\t}\n}";
34			}
35
36			$data .= $customCss;
37
38			return new Response($data, 200, $headers);
39			}
40			}
41

parsingphase / takeAticket

GitHub Access Token became invalid

CssController::customCssAction() B last analyzed 2017-06-14 13:44 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CssController::customCssAction() B
last analyzed 2017-06-14 13:44 UTC