Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
11 | class Sqlite extends AbstractSql |
||
12 | { |
||
13 | /** |
||
14 | * @param array $fields |
||
15 | * |
||
16 | * @return string |
||
17 | */ |
||
18 | protected function concatenateEscapedFields($fields) |
||
22 | |||
23 | /** |
||
24 | * Get current value of a named setting, NULL if missing |
||
25 | * |
||
26 | * @param $key |
||
27 | * @return mixed|null |
||
28 | */ |
||
29 | View Code Duplication | public function fetchSetting($key) |
|
37 | } |
||
38 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.