ParcelValue\ApiClient\Domain\Shipments\ShipmentsCommand

Complexity

Total Complexity

2

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	test()	0	10	1
A	__construct()	0	12	1

<?php
namespace ParcelValue\ApiClient\Domain\Shipments;

use WebServCo\Framework\CliResponse;

final class ShipmentsCommand extends \ParcelValue\ApiClient\AbstractController
{
    protected $logger;
    protected $curlBrowser;

    public function __construct()
    {
        parent::__construct();

        $this->repository = new ShipmentsRepository($this->outputLoader);

        $this->logger = new \WebServCo\Framework\FileLogger(
            __FUNCTION__,
            sprintf('%svar/log/', $this->data('path/project')),

It seems like $this->data('path/project') can also be of type false; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

            $this->request()
        );
        $this->curlBrowser = new \WebServCo\Framework\CurlBrowser($this->logger);
    }

    public function test($clientId, $clientKey, $serverKey)

The parameter $clientKey is not used and could be removed.

The parameter $clientId is not used and could be removed.

The parameter $serverKey is not used and could be removed.

    {
        var_dump($this->config()->get('app'));

var_dump($this->config()->get('app')) looks like debug code. Are you sure you do not want to remove it?

        // XXX move project to github
        //XXX ? move documentation to parcelvalue/api
        //problem: since it's a public app, can't use PV FW

        //$this->outputCli('', true);
        return new CliResponse('', true);
    }
}