ParcelValue\ApiClient\Traits\ControllerTrait

Complexity

Total Complexity

2

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	2	1
A	initPaths()	0	6	1

<?php
namespace ParcelValue\ApiClient\Traits;

trait ControllerTrait
{
    abstract protected function request();
    abstract protected function setData($key, $value);

    protected function initPaths()
    {
        $this->setData('path', $this->config()->get('app/path'));

It seems like config() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->setData('url/app', $this->request()->getAppUrl());
        $this->setData('url/lang', $this->request()->getUrl(['lang']));
        $this->setData('url/current', $this->request()->getUrl());
    }

    /**
     * Called (optionally) by each method.
     */
    protected function init($action)

The parameter $action is not used and could be removed.

    {
    }
}