TagDTO::makeFromPrimitives() - Code Metrics - Inspection of "Small refactor - Added private methods for DTO" - paquettg/php-html-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 382b98...cf0bb6 )

by Gilles

created 2020-08-23 18:17 UTC

TagDTO::makeFromPrimitives() A

↳ Parent: TagDTO

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	4
dl	0
loc	7
ccs	6
cts	6
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace PHPHtmlParser\DTO;

use PHPHtmlParser\Dom\Node\HtmlNode;

final class TagDTO
{
    /**
     * @var bool
     */
    private $status;

    /**
     * @var bool
     */
    private $closing;

    /**
     * @var ?HtmlNode
     */
    private $node;

    /**
     * @var ?string
     */
    private $tag;

    private function __construct(array $values = [])
    {
        $this->status = $values['status'] ?? false;
        $this->closing = $values['closing'] ?? false;
        $this->node = $values['node'] ?? null;
        $this->tag = $values['tag'] ?? null;
    }

    public static function makeFromPrimitives(bool $status = false, bool $closing = false, ?HtmlNode $node = null, ?string $tag = null): TagDTO
    {
        return new TagDTO([
            'status'  => $status,
            'closing' => $closing,
            'node'    => $node,
            'tag'     => $tag,
        ]);
    }

    public function isStatus(): bool
    {
        return $this->status;
    }

    public function isClosing(): bool
    {
        return $this->closing;
    }

    /**
     * @return mixed
     */
    public function getNode(): ?HtmlNode
    {
        return $this->node;
    }

    /**
     * @return mixed
     */
    public function getTag(): ?string
    {
        return $this->tag;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PHPHtmlParser\DTO;
6
7		use PHPHtmlParser\Dom\Node\HtmlNode;
8
9		final class TagDTO
10		{
11		/**
12		* @var bool
13		*/
14		private $status;
15
16		/**
17		* @var bool
18		*/
19		private $closing;
20
21		/**
22		* @var ?HtmlNode
23		*/
24		private $node;
25
26		/**
27		* @var ?string
28		*/
29		private $tag;
30
31	288	private function __construct(array $values = [])
32		{
33	288	$this->status = $values['status'] ?? false;
34	288	$this->closing = $values['closing'] ?? false;
35	288	$this->node = $values['node'] ?? null;
36	288	$this->tag = $values['tag'] ?? null;
37	288	}
38
39	288	public static function makeFromPrimitives(bool $status = false, bool $closing = false, ?HtmlNode $node = null, ?string $tag = null): TagDTO
40		{
41	288	return new TagDTO([
42	288	'status' => $status,
43	288	'closing' => $closing,
44	288	'node' => $node,
45	288	'tag' => $tag,
46		]);
47		}
48
49	288	public function isStatus(): bool
50		{
51	288	return $this->status;
52		}
53
54	282	public function isClosing(): bool
55		{
56	282	return $this->closing;
57		}
58
59		/**
60		* @return mixed
61		*/
62	282	public function getNode(): ?HtmlNode
63		{
64	282	return $this->node;
65		}
66
67		/**
68		* @return mixed
69		*/
70	252	public function getTag(): ?string
71		{
72	252	return $this->tag;
73		}
74		}
75

paquettg / php-html-parser

Push — master ( 382b98...cf0bb6 )

TagDTO::makeFromPrimitives() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like