ParsedSelectorDTO::makeFromRules() - Code Metrics - Inspection of "Small refactor - Added private methods for DTO" - paquettg/php-html-parser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 382b98...cf0bb6 )

by Gilles

created 2020-08-23 18:17 UTC

ParsedSelectorDTO::makeFromRules() A

↳ Parent: ParsedSelectorDTO

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace PHPHtmlParser\DTO\Selector;

final class ParsedSelectorDTO
{
    /**
     * @var RuleDTO[]
     */
    private $rules = [];

    /**
     * @param RuleDTO[] $ruleDTOs
     */
    private function __construct(array $ruleDTOs)
    {
        foreach ($ruleDTOs as $ruleDTO) {
            if ($ruleDTO instanceof RuleDTO) {
                $this->rules[] = $ruleDTO;
            }
        }
    }

    /**
     * @param RuleDTO[] $ruleDTOs
     */
    public static function makeFromRules(array $ruleDTOs): ParsedSelectorDTO
    {
        return new ParsedSelectorDTO($ruleDTOs);
    }

    /**
     * @return RuleDTO[]
     */
    public function getRules(): array
    {
        return $this->rules;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace PHPHtmlParser\DTO\Selector;
6
7		final class ParsedSelectorDTO
8		{
9		/**
10		* @var RuleDTO[]
11		*/
12		private $rules = [];
13
14		/**
15		* @param RuleDTO[] $ruleDTOs
16		*/
17	345	private function __construct(array $ruleDTOs)
18		{
19	345	foreach ($ruleDTOs as $ruleDTO) {
20	345	if ($ruleDTO instanceof RuleDTO) {
21	345	$this->rules[] = $ruleDTO;
22		}
23		}
24	345	}
25
26		/**
27		* @param RuleDTO[] $ruleDTOs
28		*/
29	345	public static function makeFromRules(array $ruleDTOs): ParsedSelectorDTO
30		{
31	345	return new ParsedSelectorDTO($ruleDTOs);
32		}
33
34		/**
35		* @return RuleDTO[]
36		*/
37	345	public function getRules(): array
38		{
39	345	return $this->rules;
40		}
41		}
42

paquettg / php-html-parser

Push — master ( 382b98...cf0bb6 )

ParsedSelectorDTO::makeFromRules() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like