ShopUser - Code Metrics - Inspection of "Make code follow our coding standard" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — coding-style-checks ( 3cea25...3a6cef )

by Kamil

created 2017-09-12 16:16 UTC

ShopUser A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	2
dl	0
loc	67
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	getCustomer()	4	1
A	setCustomer()	17	4
A	getEmail()	4	1
A	setEmail()	4	1
A	getEmailCanonical()	4	1
A	setEmailCanonical()	4	1

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Sylius\Component\Core\Model;

use Sylius\Component\Customer\Model\CustomerInterface as BaseCustomerInterface;
use Sylius\Component\User\Model\User as BaseUser;
use Webmozart\Assert\Assert;

/**
 * @author Paweł Jędrzejewski <[email protected]>
 * @author Michał Marcinkowski <[email protected]>
 */
class ShopUser extends BaseUser implements ShopUserInterface
{
    /**
     * @var CustomerInterface
     */
    protected $customer;

    /**
     * {@inheritdoc}
     */
    public function getCustomer(): ?BaseCustomerInterface
    {
        return $this->customer;
    }

    /**
     * {@inheritdoc}
     */
    public function setCustomer(?BaseCustomerInterface $customer): void
    {
        if ($this->customer === $customer) {
            return;
        }

        $previousCustomer = $this->customer;
        $this->customer = $customer;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        if ($previousCustomer instanceof CustomerInterface) {
            $previousCustomer->setUser(null);
        }

        if ($customer instanceof CustomerInterface) {
            $customer->setUser($this);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getEmail(): ?string
    {
        return $this->customer->getEmail();
    }
    /**
     * {@inheritdoc}
     */
    public function setEmail(?string $email): void
    {
        $this->customer->setEmail($email);
    }

    /**
     * {@inheritdoc}
     */
    public function getEmailCanonical(): ?string
    {
        return $this->customer->getEmailCanonical();
    }

    /**
     * {@inheritdoc}
     */
    public function setEmailCanonical(?string $emailCanonical): void
    {
        $this->customer->setEmailCanonical($emailCanonical);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Sylius\Component\Core\Model;
15
16			use Sylius\Component\Customer\Model\CustomerInterface as BaseCustomerInterface;
17			use Sylius\Component\User\Model\User as BaseUser;
18			use Webmozart\Assert\Assert;
19
20			/**
21			* @author Paweł Jędrzejewski <[email protected]>
22			* @author Michał Marcinkowski <[email protected]>
23			*/
24			class ShopUser extends BaseUser implements ShopUserInterface
25			{
26			/**
27			* @var CustomerInterface
28			*/
29			protected $customer;
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function getCustomer(): ?BaseCustomerInterface
35			{
36			return $this->customer;
37			}
38
39			/**
40			* {@inheritdoc}
41			*/
42			public function setCustomer(?BaseCustomerInterface $customer): void
43			{
44			if ($this->customer === $customer) {
45			return;
46			}
47
48			$previousCustomer = $this->customer;
49			$this->customer = $customer;
			0 ignored issues – show Documentation Bug introduced 2017-09-12 12:20 UTC by Report Bug Copy Issue Report It seems like `$customer` can also be of type `object<Sylius\Component\...odel\CustomerInterface>`. However, the property `$customer` is declared as type `object<Sylius\Component\...odel\CustomerInterface>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
50
51			if ($previousCustomer instanceof CustomerInterface) {
52			$previousCustomer->setUser(null);
53			}
54
55			if ($customer instanceof CustomerInterface) {
56			$customer->setUser($this);
57			}
58			}
59
60			/**
61			* {@inheritdoc}
62			*/
63			public function getEmail(): ?string
64			{
65			return $this->customer->getEmail();
66			}
67			/**
68			* {@inheritdoc}
69			*/
70			public function setEmail(?string $email): void
71			{
72			$this->customer->setEmail($email);
73			}
74
75			/**
76			* {@inheritdoc}
77			*/
78			public function getEmailCanonical(): ?string
79			{
80			return $this->customer->getEmailCanonical();
81			}
82
83			/**
84			* {@inheritdoc}
85			*/
86			public function setEmailCanonical(?string $emailCanonical): void
87			{
88			$this->customer->setEmailCanonical($emailCanonical);
89			}
90			}
91

pamil / Sylius

Push — coding-style-checks ( 3cea25...3a6cef )

ShopUser A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like