Completed
Push — symfony3 ( 8912ef...405d0c )
by Kamil
29:17 queued 09:55
created
src/Sylius/Bundle/CoreBundle/Fixture/Factory/TaxonExampleFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
     }
111 111
 
112 112
     /**
113
-     * @return array
113
+     * @return \Generator
114 114
      */
115 115
     private function getLocales()
116 116
     {
Please login to merge, or discard this patch.
Bundle/CoreBundle/Test/Services/PaymentMethodNameToGatewayConverter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
      *
68 68
      * @throws \RuntimeException
69 69
      *
70
-     * @return string
70
+     * @return integer
71 71
      */
72 72
     private function tryToMapPaymentMethodName($paymentMethodName)
73 73
     {
Please login to merge, or discard this patch.
src/Sylius/Bundle/GridBundle/Doctrine/ORM/ExpressionBuilder.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -187,6 +187,7 @@
 block discarded – undo
187 187
 
188 188
     /**
189 189
      * {@inheritdoc}
190
+     * @param string $field
190 191
      */
191 192
     private function getFieldName($field)
192 193
     {
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $parameterName = $this->getParameterName($field);
66 66
         $this->queryBuilder->setParameter($parameterName, $value);
67 67
 
68
-        return $this->queryBuilder->expr()->eq($this->getFieldName($field), ':'.$parameterName);
68
+        return $this->queryBuilder->expr()->eq($this->getFieldName($field), ':' . $parameterName);
69 69
     }
70 70
 
71 71
     /**
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         $parameterName = $this->getParameterName($field);
77 77
         $this->queryBuilder->setParameter($parameterName, $value);
78 78
 
79
-        return $this->queryBuilder->expr()->neq($this->getFieldName($field), ':'.$parameterName);
79
+        return $this->queryBuilder->expr()->neq($this->getFieldName($field), ':' . $parameterName);
80 80
     }
81 81
 
82 82
     /**
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
         $parameterName = $this->getParameterName($field);
88 88
         $this->queryBuilder->setParameter($parameterName, $value);
89 89
 
90
-        $this->queryBuilder->andWhere($this->getFieldName($field).' < :'.$parameterName);
90
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' < :' . $parameterName);
91 91
     }
92 92
 
93 93
     /**
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         $parameterName = $this->getParameterName($field);
99 99
         $this->queryBuilder->setParameter($parameterName, $value);
100 100
 
101
-        $this->queryBuilder->andWhere($this->getFieldName($field).' <= :'.$parameterName);
101
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' <= :' . $parameterName);
102 102
     }
103 103
 
104 104
     /**
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         $parameterName = $this->getParameterName($field);
110 110
         $this->queryBuilder->setParameter($parameterName, $value);
111 111
 
112
-        $this->queryBuilder->andWhere($this->getFieldName($field).' > :'.$parameterName);
112
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' > :' . $parameterName);
113 113
     }
114 114
 
115 115
     /**
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
         $parameterName = $this->getParameterName($field);
121 121
         $this->queryBuilder->setParameter($parameterName, $value);
122 122
 
123
-        $this->queryBuilder->andWhere($this->getFieldName($field).' >= :'.$parameterName);
123
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' >= :' . $parameterName);
124 124
     }
125 125
 
126 126
     /**
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
     private function getFieldName($field)
194 194
     {
195 195
         if (false === strpos($field, '.')) {
196
-            return $this->queryBuilder->getRootAlias().'.'.$field;
196
+            return $this->queryBuilder->getRootAlias() . '.' . $field;
197 197
         }
198 198
 
199 199
         return $field;
Please login to merge, or discard this patch.
src/Sylius/Bundle/ResourceBundle/Controller/RedirectHandler.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -80,6 +80,7 @@
 block discarded – undo
80 80
 
81 81
     /**
82 82
      * {@inheritdoc}
83
+     * @param string|null $url
83 84
      */
84 85
     public function redirect(RequestConfiguration $configuration, $url, $status = 302)
85 86
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,11 +85,11 @@
 block discarded – undo
85 85
     {
86 86
         if ($configuration->isHeaderRedirection()) {
87 87
             return new Response('', 200, [
88
-                'X-SYLIUS-LOCATION' => $url.$configuration->getRedirectHash(),
88
+                'X-SYLIUS-LOCATION' => $url . $configuration->getRedirectHash(),
89 89
             ]);
90 90
         }
91 91
 
92
-        return new RedirectResponse($url.$configuration->getRedirectHash(), $status);
92
+        return new RedirectResponse($url . $configuration->getRedirectHash(), $status);
93 93
     }
94 94
 
95 95
     /**
Please login to merge, or discard this patch.
Bundle/ResourceBundle/EventListener/ORMMappedSuperClassSubscriber.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
 
71 71
     /**
72 72
      * @param ClassMetadataInfo $metadata
73
-     * @param $configuration
73
+     * @param \Doctrine\ORM\Configuration $configuration
74 74
      */
75 75
     private function setAssociationMappings(ClassMetadataInfo $metadata, $configuration)
76 76
     {
Please login to merge, or discard this patch.
src/Sylius/Bundle/ResourceBundle/EventListener/ORMTranslatableListener.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@
 block discarded – undo
153 153
      * Check if a unique constraint has been defined.
154 154
      *
155 155
      * @param ClassMetadata $metadata
156
-     * @param array         $columns
156
+     * @param string[]         $columns
157 157
      *
158 158
      * @return bool
159 159
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
         }
135 135
 
136 136
         /** @var MetadataInterface $translationResourceMetadata */
137
-        $translationResourceMetadata = $this->resourceMetadataRegistry->get($resourceMetadata->getAlias().'_translation');
137
+        $translationResourceMetadata = $this->resourceMetadataRegistry->get($resourceMetadata->getAlias() . '_translation');
138 138
 
139 139
         $metadata->mapOneToMany([
140 140
             'fieldName' => 'translations',
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
         if (!$this->hasUniqueConstraint($metadata, $columns)) {
195 195
             $constraints = isset($metadata->table['uniqueConstraints']) ? $metadata->table['uniqueConstraints'] : [];
196 196
 
197
-            $constraints[$metadata->getTableName().'_uniq_trans'] = [
197
+            $constraints[$metadata->getTableName() . '_uniq_trans'] = [
198 198
                 'columns' => $columns,
199 199
             ];
200 200
 
Please login to merge, or discard this patch.
src/Sylius/Bundle/ResourceBundle/Validator/EnabledValidator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
     }
41 41
 
42 42
     /**
43
-     * @param mixed $value
43
+     * @param ToggleableInterface $value
44 44
      */
45 45
     private function ensureValueImplementsToggleableInterface($value)
46 46
     {
Please login to merge, or discard this patch.
src/Sylius/Bundle/ReviewBundle/DependencyInjection/Configuration.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@
 block discarded – undo
16 16
 use Sylius\Bundle\ReviewBundle\Doctrine\ORM\ReviewRepository;
17 17
 use Sylius\Bundle\ReviewBundle\Form\Type\ReviewType;
18 18
 use Sylius\Component\Resource\Factory\Factory;
19
-use Sylius\Component\Review\Model\ReviewerInterface;
20 19
 use Sylius\Component\Review\Model\ReviewInterface;
20
+use Sylius\Component\Review\Model\ReviewerInterface;
21 21
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
22 22
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
23 23
 use Symfony\Component\Config\Definition\ConfigurationInterface;
Please login to merge, or discard this patch.
src/Sylius/Bundle/ReviewBundle/Remover/ReviewerReviewsRemover.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
      * @param ReviewInterface $review
76 76
      * @param ReviewableInterface[] $reviewSubjectsToRecalculate
77 77
      *
78
-     * @return array
78
+     * @return ReviewableInterface[]
79 79
      */
80 80
     private function removeReviewsAndExtractSubject(ReviewInterface $review, array $reviewSubjectsToRecalculate)
81 81
     {
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,9 +12,9 @@
 block discarded – undo
12 12
 namespace spec\Sylius\Component\Review\Model;
13 13
 
14 14
 use PhpSpec\ObjectBehavior;
15
+use Sylius\Component\Review\Model\ReviewInterface;
15 16
 use Sylius\Component\Review\Model\ReviewableInterface;
16 17
 use Sylius\Component\Review\Model\ReviewerInterface;
17
-use Sylius\Component\Review\Model\ReviewInterface;
18 18
 
19 19
 /**
20 20
  * @author Mateusz Zalewski <[email protected]>
Please login to merge, or discard this patch.