MetadataContainer::getMetadata() - Code Metrics - Inspection of "Merge pull request #3956 from pamil/theme-composer..." - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90ccc1...22512f )

by Kamil

created 2016-01-27 14:17 UTC

MetadataContainer::getMetadata() A

↳ Parent: MetadataContainer

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	8
rs	9.4285
c	1
b	0
f	0
cc	3
eloc	4
nc	3
nop	0

<?php

namespace Sylius\Bundle\MetadataBundle\Model;

use Sylius\Component\Metadata\Model\MetadataInterface;
use Sylius\Component\Metadata\Model\MetadataContainer as BaseMetadataContainer;
use Sylius\Component\Metadata\Model\MetadataContainerInterface;

/**
 * @author Kamil Kokot <[email protected]>
 */
class MetadataContainer extends BaseMetadataContainer implements MetadataContainerInterface
{
    /**
     * @var MetadataInterface
     */
    protected $metadataAsObject;

    /**
     * {@inheritdoc}
     */
    public function getMetadata()
    {
        if (null !== $this->metadataAsObject) {
            return $this->metadataAsObject;
        }

        return unserialize($this->metadata) ?: null;
    }

    /**
     * {@inheritdoc}
     */
    public function setMetadata(MetadataInterface $metadata)
    {
        $this->metadataAsObject = $metadata;
    }

    public function serializeMetadata()
    {
        $this->metadata = serialize($this->metadataAsObject);

    }
}


1			<?php
2
3			namespace Sylius\Bundle\MetadataBundle\Model;
4
5			use Sylius\Component\Metadata\Model\MetadataInterface;
6			use Sylius\Component\Metadata\Model\MetadataContainer as BaseMetadataContainer;
7			use Sylius\Component\Metadata\Model\MetadataContainerInterface;
8
9			/**
10			* @author Kamil Kokot <[email protected]>
11			*/
12			class MetadataContainer extends BaseMetadataContainer implements MetadataContainerInterface
13			{
14			/**
15			* @var MetadataInterface
16			*/
17			protected $metadataAsObject;
18
19			/**
20			* {@inheritdoc}
21			*/
22			public function getMetadata()
23			{
24			if (null !== $this->metadataAsObject) {
25			return $this->metadataAsObject;
26			}
27
28			return unserialize($this->metadata) ?: null;
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function setMetadata(MetadataInterface $metadata)
35			{
36			$this->metadataAsObject = $metadata;
37			}
38
39			public function serializeMetadata()
40			{
41			$this->metadata = serialize($this->metadataAsObject);
			0 ignored issues – show Documentation Bug introduced 2016-01-27 14:52 UTC by Report Bug Copy Issue Report It seems like `serialize($this->metadataAsObject)` of type `string` is incompatible with the declared type `object<Sylius\Component\...odel\MetadataInterface>` of property `$metadata`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
42			}
43			}
44

pamil / Sylius

Push — master ( 90ccc1...22512f )

MetadataContainer::getMetadata() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like