Completed
Push — assert-overflow ( 0688b3...fbf83a )
by Kamil
66:00 queued 44:43
created
src/Sylius/Component/Core/Payment/RandomInvoiceNumberGenerator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,6 +25,6 @@
 block discarded – undo
25 25
      */
26 26
     public function generate(OrderInterface $order, PaymentInterface $payment)
27 27
     {
28
-        return mt_rand(1, 100000).'-'.mt_rand(1, 100000);
28
+        return mt_rand(1, 100000) . '-' . mt_rand(1, 100000);
29 29
     }
30 30
 }
Please login to merge, or discard this patch.
tests/Controller/ProductApiTest.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
85 85
         $products = $this->loadFixturesFromFile('resources/products.yml');
86 86
 
87
-        $this->client->request('GET', '/api/v1/products/'.$products['product1']->getId(), [], [], static::$authorizedHeaderWithAccept);
87
+        $this->client->request('GET', '/api/v1/products/' . $products['product1']->getId(), [], [], static::$authorizedHeaderWithAccept);
88 88
 
89 89
         $response = $this->client->getResponse();
90 90
         $this->assertResponse($response, 'product/show_response', Response::HTTP_OK);
@@ -111,12 +111,12 @@  discard block
 block discarded – undo
111 111
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
112 112
         $products = $this->loadFixturesFromFile('resources/products.yml');
113 113
 
114
-        $this->client->request('DELETE', '/api/v1/products/'.$products['product1']->getId(), [], [], static::$authorizedHeaderWithContentType, []);
114
+        $this->client->request('DELETE', '/api/v1/products/' . $products['product1']->getId(), [], [], static::$authorizedHeaderWithContentType, []);
115 115
 
116 116
         $response = $this->client->getResponse();
117 117
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
118 118
 
119
-        $this->client->request('GET', '/api/v1/products/'.$products['product1']->getId(), [], [], static::$authorizedHeaderWithAccept);
119
+        $this->client->request('GET', '/api/v1/products/' . $products['product1']->getId(), [], [], static::$authorizedHeaderWithAccept);
120 120
 
121 121
         $response = $this->client->getResponse();
122 122
         $this->assertResponse($response, 'error/not_found_response', Response::HTTP_NOT_FOUND);
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
             }
187 187
         }
188 188
 EOT;
189
-        $this->client->request('PUT', '/api/v1/products/'. $products["product3"]->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
189
+        $this->client->request('PUT', '/api/v1/products/' . $products["product3"]->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
190 190
         $response = $this->client->getResponse();
191 191
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
192 192
     }
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
             }
211 211
         }
212 212
 EOT;
213
-        $this->client->request('PATCH', '/api/v1/products/'. $products["product1"]->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
213
+        $this->client->request('PATCH', '/api/v1/products/' . $products["product1"]->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
214 214
         $response = $this->client->getResponse();
215 215
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
216 216
     }
Please login to merge, or discard this patch.
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
                 }
146 146
             }
147 147
         }
148
-EOT;
148
+eot;
149 149
 
150 150
         $this->client->request('POST', '/api/v1/products/', [], [], static::$authorizedHeaderWithContentType, $data);
151 151
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
                 }
186 186
             }
187 187
         }
188
-EOT;
188
+eot;
189 189
         $this->client->request('PUT', '/api/v1/products/'. $products["product3"]->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
190 190
         $response = $this->client->getResponse();
191 191
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
                 }
210 210
             }
211 211
         }
212
-EOT;
212
+eot;
213 213
         $this->client->request('PATCH', '/api/v1/products/'. $products["product1"]->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
214 214
         $response = $this->client->getResponse();
215 215
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Ui/Admin/ManagingProductsContext.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -248,6 +248,7 @@
 block discarded – undo
248 248
      * @Then the product :productName should appear in the store
249 249
      * @Then the product :productName should be in the shop
250 250
      * @Then this product should still be named :productName
251
+     * @param string $productName
251 252
      */
252 253
     public function theProductShouldAppearInTheShop($productName)
253 254
     {
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,13 +16,13 @@
 block discarded – undo
16 16
 use Sylius\Behat\NotificationType;
17 17
 use Sylius\Behat\Page\Admin\Crud\CreatePageInterface;
18 18
 use Sylius\Behat\Page\Admin\Crud\UpdatePageInterface;
19
+use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
19 20
 use Sylius\Behat\Page\Admin\Product\CreateConfigurableProductPageInterface;
20 21
 use Sylius\Behat\Page\Admin\Product\CreateSimpleProductPageInterface;
21 22
 use Sylius\Behat\Page\Admin\Product\IndexPageInterface;
22 23
 use Sylius\Behat\Page\Admin\Product\IndexPerTaxonPageInterface;
23 24
 use Sylius\Behat\Page\Admin\Product\UpdateConfigurableProductPageInterface;
24 25
 use Sylius\Behat\Page\Admin\Product\UpdateSimpleProductPageInterface;
25
-use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
26 26
 use Sylius\Behat\Service\NotificationCheckerInterface;
27 27
 use Sylius\Behat\Service\Resolver\CurrentPageResolverInterface;
28 28
 use Sylius\Behat\Service\SharedStorageInterface;
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Account/LoginPageInterface.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -25,15 +25,20 @@
 block discarded – undo
25 25
      */
26 26
     public function hasValidationErrorWith($message);
27 27
 
28
+    /**
29
+     * @return void
30
+     */
28 31
     public function logIn();
29 32
 
30 33
     /**
31 34
      * @param string $password
35
+     * @return void
32 36
      */
33 37
     public function specifyPassword($password);
34 38
 
35 39
     /**
36 40
      * @param string $username
41
+     * @return void
37 42
      */
38 43
     public function specifyUsername($username);
39 44
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Administrator/CreatePageInterface.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -18,25 +18,32 @@
 block discarded – undo
18 18
  */
19 19
 interface CreatePageInterface extends BaseCreatePageInterface
20 20
 {
21
+    /**
22
+     * @return void
23
+     */
21 24
     public function enable();
22 25
 
23 26
     /**
24 27
      * @param string $username
28
+     * @return void
25 29
      */
26 30
     public function specifyUsername($username);
27 31
 
28 32
     /**
29 33
      * @param string $email
34
+     * @return void
30 35
      */
31 36
     public function specifyEmail($email);
32 37
 
33 38
     /**
34 39
      * @param string $password
40
+     * @return void
35 41
      */
36 42
     public function specifyPassword($password);
37 43
 
38 44
     /**
39 45
      * @param string $localeCode
46
+     * @return void
40 47
      */
41 48
     public function specifyLocale($localeCode);
42 49
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Administrator/UpdatePageInterface.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -20,21 +20,25 @@
 block discarded – undo
20 20
 {
21 21
     /**
22 22
      * @param string $username
23
+     * @return void
23 24
      */
24 25
     public function changeUsername($username);
25 26
 
26 27
     /**
27 28
      * @param string $email
29
+     * @return void
28 30
      */
29 31
     public function changeEmail($email);
30 32
 
31 33
     /**
32 34
      * @param string $password
35
+     * @return void
33 36
      */
34 37
     public function changePassword($password);
35 38
 
36 39
     /**
37 40
      * @param string $localeCode
41
+     * @return void
38 42
      */
39 43
     public function changeLocale($localeCode);
40 44
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Channel/UpdatePageInterface.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -19,17 +19,25 @@  discard block
 block discarded – undo
19 19
  */
20 20
 interface UpdatePageInterface extends BaseUpdatePageInterface
21 21
 {
22
+    /**
23
+     * @return void
24
+     */
22 25
     public function enable();
23 26
 
27
+    /**
28
+     * @return void
29
+     */
24 30
     public function disable();
25 31
 
26 32
     /**
27 33
      * @param string $themeName
34
+     * @return void
28 35
      */
29 36
     public function setTheme($themeName);
30 37
 
31 38
     /**
32 39
      * @throws ElementNotFoundException
40
+     * @return void
33 41
      */
34 42
     public function unsetTheme();
35 43
 
@@ -40,6 +48,7 @@  discard block
 block discarded – undo
40 48
 
41 49
     /**
42 50
      * @param string $language
51
+     * @return void
43 52
      */
44 53
     public function chooseLocale($language);
45 54
 
@@ -52,6 +61,7 @@  discard block
 block discarded – undo
52 61
 
53 62
     /**
54 63
      * @param string $currencyCode
64
+     * @return void
55 65
      */
56 66
     public function chooseCurrency($currencyCode);
57 67
 
@@ -64,11 +74,13 @@  discard block
 block discarded – undo
64 74
 
65 75
     /**
66 76
      * @param string $taxZone
77
+     * @return void
67 78
      */
68 79
     public function chooseDefaultTaxZone($taxZone);
69 80
 
70 81
     /**
71 82
      * @param string $taxCalculationStrategy
83
+     * @return void
72 84
      */
73 85
     public function chooseTaxCalculationStrategy($taxCalculationStrategy);
74 86
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Crud/IndexPageInterface.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -43,6 +43,7 @@  discard block
 block discarded – undo
43 43
 
44 44
     /**
45 45
      * @param string $fieldName
46
+     * @return void
46 47
      */
47 48
     public function sortBy($fieldName);
48 49
 
@@ -65,5 +66,8 @@  discard block
 block discarded – undo
65 66
      */
66 67
     public function countItems();
67 68
 
69
+    /**
70
+     * @return void
71
+     */
68 72
     public function filter();
69 73
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Currency/UpdatePageInterface.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -18,7 +18,14 @@  discard block
 block discarded – undo
18 18
  */
19 19
 interface UpdatePageInterface extends BaseUpdatePageInterface
20 20
 {
21
+    /**
22
+     * @return void
23
+     */
21 24
     public function enable();
25
+
26
+    /**
27
+     * @return void
28
+     */
22 29
     public function disable();
23 30
 
24 31
     /**
@@ -33,6 +40,7 @@  discard block
 block discarded – undo
33 40
 
34 41
     /**
35 42
      * @param string $exchangeRate
43
+     * @return void
36 44
      */
37 45
     public function changeExchangeRate($exchangeRate);
38 46
 
Please login to merge, or discard this patch.