Completed
Push — assert-overflow ( 0688b3...fbf83a )
by Kamil
66:00 queued 44:43
created
Core/spec/Resolver/ZoneAndChannelBasedShippingMethodsResolverSpec.php 1 patch
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,16 +14,16 @@
 block discarded – undo
14 14
 use PhpSpec\ObjectBehavior;
15 15
 use Sylius\Component\Addressing\Matcher\ZoneMatcherInterface;
16 16
 use Sylius\Component\Addressing\Model\ZoneInterface;
17
-use Sylius\Component\Core\Model\Scope;
18 17
 use Sylius\Component\Core\Model\AddressInterface;
19 18
 use Sylius\Component\Core\Model\ChannelInterface;
20 19
 use Sylius\Component\Core\Model\OrderInterface;
20
+use Sylius\Component\Core\Model\Scope;
21 21
 use Sylius\Component\Core\Model\ShipmentInterface;
22 22
 use Sylius\Component\Core\Model\ShippingMethodInterface;
23
+use Sylius\Component\Core\Repository\ShippingMethodRepositoryInterface;
23 24
 use Sylius\Component\Core\Resolver\ZoneAndChannelBasedShippingMethodsResolver;
24 25
 use Sylius\Component\Shipping\Checker\ShippingMethodEligibilityCheckerInterface;
25 26
 use Sylius\Component\Shipping\Model\ShippingSubjectInterface;
26
-use Sylius\Component\Core\Repository\ShippingMethodRepositoryInterface;
27 27
 use Sylius\Component\Shipping\Resolver\ShippingMethodsResolverInterface;
28 28
 
29 29
 /**
Please login to merge, or discard this patch.
app/migrations/Version20161219160441.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         $this->addSql('CREATE TABLE sylius_product_association_type_translation (id INT AUTO_INCREMENT NOT NULL, translatable_id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, locale VARCHAR(255) NOT NULL, INDEX IDX_4F618E52C2AC5D3 (translatable_id), UNIQUE INDEX sylius_product_association_type_translation_uniq_trans (translatable_id, locale), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB');
38 38
         $this->addSql('ALTER TABLE sylius_product_association_type_translation ADD CONSTRAINT FK_4F618E52C2AC5D3 FOREIGN KEY (translatable_id) REFERENCES sylius_product_association_type (id) ON DELETE CASCADE');
39
-        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "'.$defaultLocale.'" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
39
+        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "' . $defaultLocale . '" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
40 40
         $this->addSql('ALTER TABLE sylius_product_association_type DROP name');
41 41
     }
42 42
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
         $defaultLocale = $this->container->getParameter('locale');
51 51
 
52 52
         $this->addSql('ALTER TABLE sylius_product_association_type ADD name VARCHAR(255) NOT NULL COLLATE utf8_unicode_ci');
53
-        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "'.$defaultLocale.'")');
53
+        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "' . $defaultLocale . '")');
54 54
         $this->addSql('DROP TABLE sylius_product_association_type_translation');
55 55
     }
56 56
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Shop/Checkout/AddressPage.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -429,6 +429,8 @@
 block discarded – undo
429 429
     }
430 430
 
431 431
     /**
432
+     * @param integer $timeout
433
+     * @param string $elementName
432 434
      * @return bool
433 435
      */
434 436
     private function waitForElement($timeout, $elementName)
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Customer/ShowPage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -172,7 +172,7 @@
 block discarded – undo
172 172
             ->getText()
173 173
         ;
174 174
 
175
-        return (int) preg_replace('/[^0-9]/', '',$overallOrders);
175
+        return (int) preg_replace('/[^0-9]/', '', $overallOrders);
176 176
     }
177 177
 
178 178
     /**
Please login to merge, or discard this patch.
Sylius/Component/Core/spec/Customer/Statistics/CustomerStatisticsSpec.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@  discard block
 block discarded – undo
46 46
         $this->getAllOrdersCount()->shouldReturn(0);
47 47
     }
48 48
 
49
-    function it_has_number_of_all_orders(ChannelInterface $channel) {
49
+    function it_has_number_of_all_orders(ChannelInterface $channel)
50
+    {
50 51
         $firstStatistics = new PerChannelCustomerStatistics(110, 120, $channel->getWrappedObject());
51 52
         $secondStatistics = new PerChannelCustomerStatistics(13, 120, $channel->getWrappedObject());
52 53
 
@@ -55,7 +56,8 @@  discard block
 block discarded – undo
55 56
         $this->getAllOrdersCount()->shouldReturn(123);
56 57
     }
57 58
 
58
-    function it_has_an_array_of_statistics_per_channel(ChannelInterface $channel) {
59
+    function it_has_an_array_of_statistics_per_channel(ChannelInterface $channel)
60
+    {
59 61
         $firstStatistics = new PerChannelCustomerStatistics(110, 120, $channel->getWrappedObject());
60 62
         $secondStatistics = new PerChannelCustomerStatistics(13, 120, $channel->getWrappedObject());
61 63
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/ProductVariant/UpdatePageInterface.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -27,11 +27,18 @@  discard block
 block discarded – undo
27 27
     
28 28
     /**
29 29
      * @param int $price
30
+     * @return void
30 31
      */
31 32
     public function specifyPrice($price);
32 33
 
34
+    /**
35
+     * @return void
36
+     */
33 37
     public function disableTracking();
34 38
 
39
+    /**
40
+     * @return void
41
+     */
35 42
     public function enableTracking();
36 43
 
37 44
     /**
@@ -63,6 +70,7 @@  discard block
 block discarded – undo
63 70
 
64 71
     /**
65 72
      * @param int $amount
73
+     * @return void
66 74
      */
67 75
     public function specifyCurrentStock($amount);
68 76
 }
Please login to merge, or discard this patch.
src/Sylius/Bundle/CoreBundle/Fixture/Factory/AddressExampleFactory.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@
 block discarded – undo
223 223
             return;
224 224
         }
225 225
 
226
-        if (null !== $options['province_name']){
226
+        if (null !== $options['province_name']) {
227 227
             $this->provideProvince($options, $address);
228 228
         }
229 229
     }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@
 block discarded – undo
223 223
             return;
224 224
         }
225 225
 
226
-        if (null !== $options['province_name']){
226
+        if (null !== $options['province_name']) {
227 227
             $this->provideProvince($options, $address);
228 228
         }
229 229
     }
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Setup/OrderContext.php 2 patches
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -271,7 +271,8 @@
 block discarded – undo
271 271
     /**
272 272
      * @Given /^the customer chose ("[^"]+" shipping method)$/
273 273
      */
274
-    public function theCustomerChoseShippingMethod(ShippingMethodInterface $shippingMethod) {
274
+    public function theCustomerChoseShippingMethod(ShippingMethodInterface $shippingMethod)
275
+    {
275 276
         /** @var OrderInterface $order */
276 277
         $order = $this->sharedStorage->get('order');
277 278
 
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 
388 388
             $this->itemQuantityModifier->modify($item, 1);
389 389
 
390
-            $order = $this->createOrder($customer, '#00000'.$i);
390
+            $order = $this->createOrder($customer, '#00000' . $i);
391 391
             $order->addItem($item);
392 392
 
393 393
             $this->checkoutUsing($order, $shippingMethod, clone $address, $paymentMethod);
@@ -486,7 +486,7 @@  discard block
 block discarded – undo
486 486
         $total = $this->getPriceFromString($total);
487 487
 
488 488
         for ($i = 0; $i < $numberOfOrders; $i++) {
489
-            $order = $this->createOrder($customers[rand(0, $numberOfCustomers - 1)], '#'.uniqid());
489
+            $order = $this->createOrder($customers[rand(0, $numberOfCustomers - 1)], '#' . uniqid());
490 490
             $order->setState(OrderInterface::STATE_NEW); // Temporary, we should use checkout to place these orders.
491 491
             $this->applyPaymentTransitionOnOrder($order, PaymentTransitions::TRANSITION_COMPLETE);
492 492
 
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
         $total = $this->getPriceFromString($total);
514 514
 
515 515
         for ($i = 0; $i < $numberOfOrders; $i++) {
516
-            $order = $this->createOrder($customers[rand(0, $numberOfCustomers - 1)], '#'.uniqid(), $product->getChannels()->first());
516
+            $order = $this->createOrder($customers[rand(0, $numberOfCustomers - 1)], '#' . uniqid(), $product->getChannels()->first());
517 517
             $order->setState(OrderInterface::STATE_NEW);
518 518
             $this->applyPaymentTransitionOnOrder($order, PaymentTransitions::TRANSITION_COMPLETE);
519 519
 
@@ -738,7 +738,7 @@  discard block
 block discarded – undo
738 738
             $customer = $this->customerFactory->createNew();
739 739
             $customer->setEmail(sprintf('john%[email protected]', uniqid()));
740 740
             $customer->setFirstname('John');
741
-            $customer->setLastname('Doe'.$i);
741
+            $customer->setLastname('Doe' . $i);
742 742
 
743 743
             $customers[] = $customer;
744 744
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Shop/Order/ThankYouPage.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
     /**
51 51
      * {@inheritdoc}
52 52
      */
53
-    public function hasInstructions() 
53
+    public function hasInstructions()
54 54
     {
55 55
         return null !== $this->getDocument()->find('css', '#sylius-payment-method-instructions');
56 56
     }
Please login to merge, or discard this patch.