Inspection of "Add an upgrade note about added repository methods" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.1-product-review-api ( dd6922...5c1424 )

by Kamil

created 2018-01-05 12:08 UTC

Status

Doc Comments +22 added lines patch added patch discarded remove patch

@@ -22,16 +22,19 @@  discard block
 block discarded – undo
 {
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
     /**
      * @param string $ruleName
+     * @return void
      */
     public function addRule($ruleName);
 
@@ -39,6 +42,7 @@  discard block
 block discarded – undo
      * @param string $option
      * @param string $value
      * @param bool $multiple
+     * @return void
      */
     public function selectRuleOption($option, $value, $multiple = false);
 
@@ -46,12 +50,14 @@  discard block
 block discarded – undo
      * @param string $option
      * @param string|string[] $value
      * @param bool $multiple
+     * @return void
      */
     public function selectAutocompleteRuleOption($option, $value, $multiple = false);
 
     /**
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillRuleOption($option, $value);
 
@@ -59,11 +65,13 @@  discard block
 block discarded – undo
      * @param string $channelName
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillRuleOptionForChannel($channelName, $option, $value);
 
     /**
      * @param string $actionName
+     * @return void
      */
     public function addAction($actionName);
 
@@ -71,12 +79,14 @@  discard block
 block discarded – undo
      * @param string $option
      * @param string $value
      * @param bool $multiple
+     * @return void
      */
     public function selectActionOption($option, $value, $multiple = false);
 
     /**
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillActionOption($option, $value);
 
@@ -84,30 +94,41 @@  discard block
 block discarded – undo
      * @param string $channelName
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillActionOptionForChannel($channelName, $option, $value);
 
     /**
      * @param string $limit
+     * @return void
      */
     public function fillUsageLimit($limit);
 
+    /**
+     * @return void
+     */
     public function makeExclusive();
 
+    /**
+     * @return void
+     */
     public function checkCouponBased();
 
     /**
      * @param string $name
+     * @return void
      */
     public function checkChannel($name);
 
     /**
      * @param \DateTimeInterface $dateTime
+     * @return void
      */
     public function setStartsAt(\DateTimeInterface $dateTime);
 
     /**
      * @param \DateTimeInterface $dateTime
+     * @return void
      */
     public function setEndsAt(\DateTimeInterface $dateTime);
 
@@ -122,6 +143,7 @@  discard block
 block discarded – undo
      * @param string $option
      * @param string|string[] $value
      * @param bool $multiple
+     * @return void
      */
     public function selectAutoCompleteFilterOption($option, $value, $multiple = false);
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Admin\Promotion;
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/PromotionCoupon/CreatePageInterface.php 2 patches

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -20,21 +20,25 @@
 block discarded – undo
 {
     /**
      * @param int $limit
+     * @return void
      */
     public function setCustomerUsageLimit($limit);
 
     /**
      * @param \DateTimeInterface $date
+     * @return void
      */
     public function setExpiresAt(\DateTimeInterface $date);
 
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param int $limit
+     * @return void
      */
     public function setUsageLimit($limit);
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Admin\PromotionCoupon;
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/PromotionCoupon/GeneratePageInterface.php 2 patches

Doc Comments +7 added lines patch added patch discarded remove patch

@@ -39,25 +39,32 @@
 block discarded – undo
      */
     public function checkGenerationValidation($message);
 
+    /**
+     * @return void
+     */
     public function generate();
 
     /**
      * @param int $amount
+     * @return void
      */
     public function specifyAmount($amount);
 
     /**
      * @param int $codeLength
+     * @return void
      */
     public function specifyCodeLength($codeLength);
 
     /**
      * @param \DateTimeInterface $date
+     * @return void
      */
     public function setExpiresAt(\DateTimeInterface $date);
 
     /**
      * @param int $limit
+     * @return void
      */
     public function setUsageLimit($limit);
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Admin\PromotionCoupon;
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/PromotionCoupon/UpdatePageInterface.php 2 patches

Doc Comments +3 added lines patch added patch discarded remove patch

@@ -25,16 +25,19 @@
 block discarded – undo
 
     /**
      * @param int $limit
+     * @return void
      */
     public function setCustomerUsageLimit($limit);
 
     /**
      * @param \DateTimeInterface $date
+     * @return void
      */
     public function setExpiresAt(\DateTimeInterface $date);
 
     /**
      * @param int $limit
+     * @return void
      */
     public function setUsageLimit($limit);
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Admin\PromotionCoupon;
 

Please login to merge, or discard this patch.

app/AppCache.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 use Symfony\Bundle\FrameworkBundle\HttpCache\HttpCache;
 

Please login to merge, or discard this patch.

app/AppKernel.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 use Sylius\Bundle\CoreBundle\Application\Kernel;
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Shop/ProductReview/IndexPageInterface.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Shop\ProductReview;
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Shop/Order/ShowPage.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Shop\Order;
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Shop/Contact/ContactPage.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Shop\Contact;
 

Please login to merge, or discard this patch.

		@@ -22,16 +22,19 @@ discard block
		block discarded – undo
22	22	{
23	23	/**
24	24	* @param string $code
	25	+ * @return void
25	26	*/
26	27	public function specifyCode($code);
27	28
28	29	/**
29	30	* @param string $name
	31	+ * @return void
30	32	*/
31	33	public function nameIt($name);
32	34
33	35	/**
34	36	* @param string $ruleName
	37	+ * @return void
35	38	*/
36	39	public function addRule($ruleName);
37	40
		@@ -39,6 +42,7 @@ discard block
		block discarded – undo
39	42	* @param string $option
40	43	* @param string $value
41	44	* @param bool $multiple
	45	+ * @return void
42	46	*/
43	47	public function selectRuleOption($option, $value, $multiple = false);
44	48
		@@ -46,12 +50,14 @@ discard block
		block discarded – undo
46	50	* @param string $option
47	51	* @param string\|string[] $value
48	52	* @param bool $multiple
	53	+ * @return void
49	54	*/
50	55	public function selectAutocompleteRuleOption($option, $value, $multiple = false);
51	56
52	57	/**
53	58	* @param string $option
54	59	* @param string $value
	60	+ * @return void
55	61	*/
56	62	public function fillRuleOption($option, $value);
57	63
		@@ -59,11 +65,13 @@ discard block
		block discarded – undo
59	65	* @param string $channelName
60	66	* @param string $option
61	67	* @param string $value
	68	+ * @return void
62	69	*/
63	70	public function fillRuleOptionForChannel($channelName, $option, $value);
64	71
65	72	/**
66	73	* @param string $actionName
	74	+ * @return void
67	75	*/
68	76	public function addAction($actionName);
69	77
		@@ -71,12 +79,14 @@ discard block
		block discarded – undo
71	79	* @param string $option
72	80	* @param string $value
73	81	* @param bool $multiple
	82	+ * @return void
74	83	*/
75	84	public function selectActionOption($option, $value, $multiple = false);
76	85
77	86	/**
78	87	* @param string $option
79	88	* @param string $value
	89	+ * @return void
80	90	*/
81	91	public function fillActionOption($option, $value);
82	92
		@@ -84,30 +94,41 @@ discard block
		block discarded – undo
84	94	* @param string $channelName
85	95	* @param string $option
86	96	* @param string $value
	97	+ * @return void
87	98	*/
88	99	public function fillActionOptionForChannel($channelName, $option, $value);
89	100
90	101	/**
91	102	* @param string $limit
	103	+ * @return void
92	104	*/
93	105	public function fillUsageLimit($limit);
94	106
	107	+ /**
	108	+ * @return void
	109	+ */
95	110	public function makeExclusive();
96	111
	112	+ /**
	113	+ * @return void
	114	+ */
97	115	public function checkCouponBased();
98	116
99	117	/**
100	118	* @param string $name
	119	+ * @return void
101	120	*/
102	121	public function checkChannel($name);
103	122
104	123	/**
105	124	* @param \DateTimeInterface $dateTime
	125	+ * @return void
106	126	*/
107	127	public function setStartsAt(\DateTimeInterface $dateTime);
108	128
109	129	/**
110	130	* @param \DateTimeInterface $dateTime
	131	+ * @return void
111	132	*/
112	133	public function setEndsAt(\DateTimeInterface $dateTime);
113	134
		@@ -122,6 +143,7 @@ discard block
		block discarded – undo
122	143	* @param string $option
123	144	* @param string\|string[] $value
124	145	* @param bool $multiple
	146	+ * @return void
125	147	*/
126	148	public function selectAutoCompleteFilterOption($option, $value, $multiple = false);
127	149	}

		@@ -9,7 +9,7 @@
		block discarded – undo
9	9	* file that was distributed with this source code.
10	10	*/
11	11
12		-declare(strict_types=1);
	12	+declare(strict_types = 1);
13	13
14	14	namespace Sylius\Behat\Page\Admin\Promotion;
15	15

		@@ -20,21 +20,25 @@
		block discarded – undo
20	20	{
21	21	/**
22	22	* @param int $limit
	23	+ * @return void
23	24	*/
24	25	public function setCustomerUsageLimit($limit);
25	26
26	27	/**
27	28	* @param \DateTimeInterface $date
	29	+ * @return void
28	30	*/
29	31	public function setExpiresAt(\DateTimeInterface $date);
30	32
31	33	/**
32	34	* @param string $code
	35	+ * @return void
33	36	*/
34	37	public function specifyCode($code);
35	38
36	39	/**
37	40	* @param int $limit
	41	+ * @return void
38	42	*/
39	43	public function setUsageLimit($limit);
40	44	}

		@@ -39,25 +39,32 @@
		block discarded – undo
39	39	*/
40	40	public function checkGenerationValidation($message);
41	41
	42	+ /**
	43	+ * @return void
	44	+ */
42	45	public function generate();
43	46
44	47	/**
45	48	* @param int $amount
	49	+ * @return void
46	50	*/
47	51	public function specifyAmount($amount);
48	52
49	53	/**
50	54	* @param int $codeLength
	55	+ * @return void
51	56	*/
52	57	public function specifyCodeLength($codeLength);
53	58
54	59	/**
55	60	* @param \DateTimeInterface $date
	61	+ * @return void
56	62	*/
57	63	public function setExpiresAt(\DateTimeInterface $date);
58	64
59	65	/**
60	66	* @param int $limit
	67	+ * @return void
61	68	*/
62	69	public function setUsageLimit($limit);
63	70	}

		@@ -25,16 +25,19 @@
		block discarded – undo
25	25
26	26	/**
27	27	* @param int $limit
	28	+ * @return void
28	29	*/
29	30	public function setCustomerUsageLimit($limit);
30	31
31	32	/**
32	33	* @param \DateTimeInterface $date
	34	+ * @return void
33	35	*/
34	36	public function setExpiresAt(\DateTimeInterface $date);
35	37
36	38	/**
37	39	* @param int $limit
	40	+ * @return void
38	41	*/
39	42	public function setUsageLimit($limit);
40	43	}

pamil / Sylius

Push — 1.1-product-review-api ( dd6922...5c1424 )

Status

Category

Doc Comments +22 added lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +7 added lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch