Completed
Push — remove-codeowners ( c2a3b4 )
by Kamil
35:29 queued 21:05
created
src/Sylius/Bundle/FixturesBundle/spec/Suite/SuiteSpec.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -84,6 +84,7 @@
 block discarded – undo
84 84
 
85 85
     /**
86 86
      * @param Collaborator[] ...$collaborators
87
+     * @param FixtureInterface $collaborators
87 88
      *
88 89
      * @return \Generator
89 90
      */
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/ShippingMethod/UpdatePageInterface.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -31,10 +31,19 @@
 block discarded – undo
31 31
      */
32 32
     public function isAvailableInChannel($channelName);
33 33
 
34
+    /**
35
+     * @return void
36
+     */
34 37
     public function enable();
35 38
 
39
+    /**
40
+     * @return void
41
+     */
36 42
     public function disable();
37 43
 
44
+    /**
45
+     * @return void
46
+     */
38 47
     public function removeZone();
39 48
 
40 49
     /**
Please login to merge, or discard this patch.
app/migrations/Version20161214153137.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 
34 34
         $this->addSql('CREATE TABLE sylius_product_variant_translation (id INT AUTO_INCREMENT NOT NULL, translatable_id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, locale VARCHAR(255) NOT NULL, INDEX IDX_8DC18EDC2C2AC5D3 (translatable_id), UNIQUE INDEX sylius_product_variant_translation_uniq_trans (translatable_id, locale), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB');
35 35
         $this->addSql('ALTER TABLE sylius_product_variant_translation ADD CONSTRAINT FK_8DC18EDC2C2AC5D3 FOREIGN KEY (translatable_id) REFERENCES sylius_product_variant (id) ON DELETE CASCADE');
36
-        $this->addSql('INSERT INTO sylius_product_variant_translation (translatable_id, name, locale) SELECT id, name, "'.$defaultLocale.'" from sylius_product_variant WHERE sylius_product_variant.name IS NOT null');
36
+        $this->addSql('INSERT INTO sylius_product_variant_translation (translatable_id, name, locale) SELECT id, name, "' . $defaultLocale . '" from sylius_product_variant WHERE sylius_product_variant.name IS NOT null');
37 37
         $this->addSql('ALTER TABLE sylius_product_variant DROP name');
38 38
     }
39 39
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $this->abortIf($this->connection->getDatabasePlatform()->getName() != 'mysql', 'Migration can only be executed safely on \'mysql\'.');
48 48
 
49 49
         $this->addSql('ALTER TABLE sylius_product_variant ADD name VARCHAR(255) DEFAULT NULL COLLATE utf8_unicode_ci');
50
-        $this->addSql('UPDATE sylius_product_variant SET name = (SELECT name FROM sylius_product_variant_translation WHERE sylius_product_variant_translation.translatable_id = sylius_product_variant.id AND sylius_product_variant_translation.locale = "'.$defaultLocale.'")');
50
+        $this->addSql('UPDATE sylius_product_variant SET name = (SELECT name FROM sylius_product_variant_translation WHERE sylius_product_variant_translation.translatable_id = sylius_product_variant.id AND sylius_product_variant_translation.locale = "' . $defaultLocale . '")');
51 51
         $this->addSql('DROP TABLE sylius_product_variant_translation');
52 52
     }
53 53
 }
Please login to merge, or discard this patch.
app/migrations/Version20161219160441.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         $this->addSql('CREATE TABLE sylius_product_association_type_translation (id INT AUTO_INCREMENT NOT NULL, translatable_id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, locale VARCHAR(255) NOT NULL, INDEX IDX_4F618E52C2AC5D3 (translatable_id), UNIQUE INDEX sylius_product_association_type_translation_uniq_trans (translatable_id, locale), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB');
38 38
         $this->addSql('ALTER TABLE sylius_product_association_type_translation ADD CONSTRAINT FK_4F618E52C2AC5D3 FOREIGN KEY (translatable_id) REFERENCES sylius_product_association_type (id) ON DELETE CASCADE');
39
-        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "'.$defaultLocale.'" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
39
+        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "' . $defaultLocale . '" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
40 40
         $this->addSql('ALTER TABLE sylius_product_association_type DROP name');
41 41
     }
42 42
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
         $defaultLocale = $this->container->getParameter('locale');
51 51
 
52 52
         $this->addSql('ALTER TABLE sylius_product_association_type ADD name VARCHAR(255) NOT NULL COLLATE utf8_unicode_ci');
53
-        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "'.$defaultLocale.'")');
53
+        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "' . $defaultLocale . '")');
54 54
         $this->addSql('DROP TABLE sylius_product_association_type_translation');
55 55
     }
56 56
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Shop/Checkout/AddressPage.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -429,6 +429,8 @@
 block discarded – undo
429 429
     }
430 430
 
431 431
     /**
432
+     * @param integer $timeout
433
+     * @param string $elementName
432 434
      * @return bool
433 435
      */
434 436
     private function waitForElement($timeout, $elementName)
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Ui/Admin/ManagingProductsContext.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,13 +16,13 @@
 block discarded – undo
16 16
 use Sylius\Behat\NotificationType;
17 17
 use Sylius\Behat\Page\Admin\Crud\CreatePageInterface;
18 18
 use Sylius\Behat\Page\Admin\Crud\UpdatePageInterface;
19
+use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
19 20
 use Sylius\Behat\Page\Admin\Product\CreateConfigurableProductPageInterface;
20 21
 use Sylius\Behat\Page\Admin\Product\CreateSimpleProductPageInterface;
21 22
 use Sylius\Behat\Page\Admin\Product\IndexPageInterface;
22 23
 use Sylius\Behat\Page\Admin\Product\IndexPerTaxonPageInterface;
23 24
 use Sylius\Behat\Page\Admin\Product\UpdateConfigurableProductPageInterface;
24 25
 use Sylius\Behat\Page\Admin\Product\UpdateSimpleProductPageInterface;
25
-use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
26 26
 use Sylius\Behat\Page\SymfonyPageInterface;
27 27
 use Sylius\Behat\Service\NotificationCheckerInterface;
28 28
 use Sylius\Behat\Service\Resolver\CurrentPageResolverInterface;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -259,6 +259,7 @@
 block discarded – undo
259 259
      * @Then the product :productName should appear in the store
260 260
      * @Then the product :productName should be in the shop
261 261
      * @Then this product should still be named :productName
262
+     * @param string|null $productName
262 263
      */
263 264
     public function theProductShouldAppearInTheShop($productName)
264 265
     {
Please login to merge, or discard this patch.
app/migrations/Version20170109143010.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
         $defaultLocale = $this->container->getParameter('locale');
36 36
 
37 37
         $this->addSql('ALTER TABLE sylius_product_attribute_value ADD locale_code VARCHAR(255) NOT NULL');
38
-        $this->addSql('UPDATE sylius_product_attribute_value SET locale_code = "'.$defaultLocale.'"');
38
+        $this->addSql('UPDATE sylius_product_attribute_value SET locale_code = "' . $defaultLocale . '"');
39 39
     }
40 40
 
41 41
     /**
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Account/LoginPageInterface.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -25,15 +25,20 @@
 block discarded – undo
25 25
      */
26 26
     public function hasValidationErrorWith($message);
27 27
 
28
+    /**
29
+     * @return void
30
+     */
28 31
     public function logIn();
29 32
 
30 33
     /**
31 34
      * @param string $password
35
+     * @return void
32 36
      */
33 37
     public function specifyPassword($password);
34 38
 
35 39
     /**
36 40
      * @param string $username
41
+     * @return void
37 42
      */
38 43
     public function specifyUsername($username);
39 44
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Administrator/UpdatePageInterface.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -20,21 +20,25 @@
 block discarded – undo
20 20
 {
21 21
     /**
22 22
      * @param string $username
23
+     * @return void
23 24
      */
24 25
     public function changeUsername($username);
25 26
 
26 27
     /**
27 28
      * @param string $email
29
+     * @return void
28 30
      */
29 31
     public function changeEmail($email);
30 32
 
31 33
     /**
32 34
      * @param string $password
35
+     * @return void
33 36
      */
34 37
     public function changePassword($password);
35 38
 
36 39
     /**
37 40
      * @param string $localeCode
41
+     * @return void
38 42
      */
39 43
     public function changeLocale($localeCode);
40 44
 }
Please login to merge, or discard this patch.