Conditions | 1 |
Paths | 1 |
Total Lines | 67 |
Code Lines | 44 |
Lines | 0 |
Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
131 | private function configureConfigurationSubMenu(ItemInterface $menu) |
||
132 | { |
||
133 | $configurationSubMenu = $menu |
||
134 | ->addChild('configuration') |
||
135 | ->setLabel('sylius.menu.admin.main.configuration.header') |
||
136 | ; |
||
137 | |||
138 | $configurationSubMenu |
||
139 | ->addChild('channels', ['route' => 'sylius_admin_channel_index']) |
||
140 | ->setLabel('sylius.menu.admin.main.configuration.channels') |
||
141 | ->setLabelAttribute('icon', 'share alternate') |
||
142 | ; |
||
143 | |||
144 | $configurationSubMenu |
||
145 | ->addChild('countries', ['route' => 'sylius_admin_country_index']) |
||
146 | ->setLabel('sylius.menu.admin.main.configuration.countries') |
||
147 | ->setLabelAttribute('icon', 'flag') |
||
148 | ; |
||
149 | |||
150 | $configurationSubMenu |
||
151 | ->addChild('zones', ['route' => 'sylius_admin_zone_index']) |
||
152 | ->setLabel('sylius.menu.admin.main.configuration.zones') |
||
153 | ->setLabelAttribute('icon', 'world') |
||
154 | ; |
||
155 | |||
156 | $configurationSubMenu |
||
157 | ->addChild('currencies', ['route' => 'sylius_admin_currency_index']) |
||
158 | ->setLabel('sylius.menu.admin.main.configuration.currencies') |
||
159 | ->setLabelAttribute('icon', 'dollar') |
||
160 | ; |
||
161 | |||
162 | $configurationSubMenu |
||
163 | ->addChild('locales', ['route' => 'sylius_admin_locale_index']) |
||
164 | ->setLabel('sylius.menu.admin.main.configuration.locales') |
||
165 | ->setLabelAttribute('icon', 'translate') |
||
166 | ; |
||
167 | |||
168 | $configurationSubMenu |
||
169 | ->addChild('payment_methods', ['route' => 'sylius_admin_payment_method_index']) |
||
170 | ->setLabel('sylius.menu.admin.main.configuration.payment_methods') |
||
171 | ->setLabelAttribute('icon', 'payment') |
||
172 | ; |
||
173 | |||
174 | $configurationSubMenu |
||
175 | ->addChild('shipping_methods', ['route' => 'sylius_admin_shipping_method_index']) |
||
176 | ->setLabel('sylius.menu.admin.main.configuration.shipping_methods') |
||
177 | ->setLabelAttribute('icon', 'shipping') |
||
178 | ; |
||
179 | |||
180 | $configurationSubMenu |
||
181 | ->addChild('tax_categories', ['route' => 'sylius_admin_tax_category_index']) |
||
182 | ->setLabel('sylius.menu.admin.main.configuration.tax_categories') |
||
183 | ->setLabelAttribute('icon', 'tags') |
||
184 | ; |
||
185 | |||
186 | $configurationSubMenu |
||
187 | ->addChild('tax_rates', ['route' => 'sylius_admin_tax_rate_index']) |
||
188 | ->setLabel('sylius.menu.admin.main.configuration.tax_rates') |
||
189 | ->setLabelAttribute('icon', 'money') |
||
190 | ; |
||
191 | |||
192 | $configurationSubMenu |
||
193 | ->addChild('channels', ['route' => 'sylius_admin_channel_index']) |
||
194 | ->setLabel('sylius.menu.admin.main.configuration.channels') |
||
195 | ->setLabelAttribute('icon', 'random') |
||
196 | ; |
||
197 | } |
||
198 | } |
||
199 |