Completed
Push — to-be-a-hat-or-not-to-be-kuhwa ( 7c7f7b...b72886 )
by Kamil
20:35
created
web/app_dev.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,11 +21,11 @@
 block discarded – undo
21 21
     || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1', '113.0.0.1'], true) || php_sapi_name() === 'cli-server')
22 22
 ) {
23 23
     header('HTTP/1.0 403 Forbidden');
24
-    exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
24
+    exit('You are not allowed to access this file. Check ' . basename(__FILE__) . ' for more information.');
25 25
 }
26 26
 
27
-require_once __DIR__.'/../app/bootstrap.php.cache';
28
-require_once __DIR__.'/../app/AppKernel.php';
27
+require_once __DIR__ . '/../app/bootstrap.php.cache';
28
+require_once __DIR__ . '/../app/AppKernel.php';
29 29
 
30 30
 $kernel = new AppKernel('test_cached', false);
31 31
 $kernel->loadClassCache();
Please login to merge, or discard this patch.
web/app_test.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,11 +21,11 @@
 block discarded – undo
21 21
     || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1', '113.0.0.1'], true) || php_sapi_name() === 'cli-server')
22 22
 ) {
23 23
     header('HTTP/1.0 403 Forbidden');
24
-    exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
24
+    exit('You are not allowed to access this file. Check ' . basename(__FILE__) . ' for more information.');
25 25
 }
26 26
 
27
-require_once __DIR__.'/../app/bootstrap.php.cache';
28
-require_once __DIR__.'/../app/AppKernel.php';
27
+require_once __DIR__ . '/../app/bootstrap.php.cache';
28
+require_once __DIR__ . '/../app/AppKernel.php';
29 29
 
30 30
 $kernel = new AppKernel('test_cached', false);
31 31
 $kernel->loadClassCache();
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Setup/ProductContext.php 2 patches
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,6 +15,7 @@  discard block
 block discarded – undo
15 15
 use Behat\Gherkin\Node\TableNode;
16 16
 use Behat\Mink\Element\NodeElement;
17 17
 use Doctrine\Common\Persistence\ObjectManager;
18
+use Sylius\Behat\Service\SharedStorageInterface;
18 19
 use Sylius\Component\Attribute\Factory\AttributeFactoryInterface;
19 20
 use Sylius\Component\Core\Formatter\StringInflector;
20 21
 use Sylius\Component\Core\Model\ChannelInterface;
@@ -23,16 +24,15 @@  discard block
 block discarded – undo
23 24
 use Sylius\Component\Core\Model\ProductTranslationInterface;
24 25
 use Sylius\Component\Core\Model\ProductVariantInterface;
25 26
 use Sylius\Component\Core\Repository\ProductRepositoryInterface;
26
-use Sylius\Behat\Service\SharedStorageInterface;
27 27
 use Sylius\Component\Core\Uploader\ImageUploaderInterface;
28 28
 use Sylius\Component\Product\Factory\ProductFactoryInterface;
29 29
 use Sylius\Component\Product\Model\ProductAttributeInterface;
30 30
 use Sylius\Component\Product\Model\ProductAttributeValueInterface;
31 31
 use Sylius\Component\Product\Model\ProductOptionInterface;
32 32
 use Sylius\Component\Product\Model\ProductOptionValueInterface;
33
+use Sylius\Component\Product\Resolver\ProductVariantResolverInterface;
33 34
 use Sylius\Component\Resource\Factory\FactoryInterface;
34 35
 use Sylius\Component\Taxation\Model\TaxCategoryInterface;
35
-use Sylius\Component\Product\Resolver\ProductVariantResolverInterface;
36 36
 use Symfony\Component\HttpFoundation\File\UploadedFile;
37 37
 
38 38
 /**
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
     {
170 170
         $product = $this->createProduct($productName, $price);
171 171
 
172
-        $product->setDescription('Awesome '.$productName);
172
+        $product->setDescription('Awesome ' . $productName);
173 173
 
174 174
         if ($this->sharedStorage->has('channel')) {
175 175
             $product->addChannel($this->sharedStorage->get('channel'));
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
 
221 221
         $product->setName($productName);
222 222
         $product->setCode($this->convertToCode($productName));
223
-        $product->setDescription('Awesome '.$productName);
223
+        $product->setDescription('Awesome ' . $productName);
224 224
 
225 225
         if ($this->sharedStorage->has('channel')) {
226 226
             $channel = $this->sharedStorage->get('channel');
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      */
323 323
     public function thisProductHasAttributeWithValue(ProductInterface $product, $productAttributeType, $productAttributeName, $value)
324 324
     {
325
-        $attribute = $this->createProductAttribute($productAttributeType,$productAttributeName);
325
+        $attribute = $this->createProductAttribute($productAttributeType, $productAttributeName);
326 326
         $attributeValue = $this->createProductAttributeValue($value, $attribute);
327 327
         $product->addAttribute($attributeValue);
328 328
 
@@ -334,8 +334,8 @@  discard block
 block discarded – undo
334 334
      */
335 335
     public function thisProductHasPercentAttributeWithValue(ProductInterface $product, $productAttributeName, $value)
336 336
     {
337
-        $attribute = $this->createProductAttribute('percent',$productAttributeName);
338
-        $attributeValue = $this->createProductAttributeValue($value/100, $attribute);
337
+        $attribute = $this->createProductAttribute('percent', $productAttributeName);
338
+        $attributeValue = $this->createProductAttributeValue($value / 100, $attribute);
339 339
         $product->addAttribute($attributeValue);
340 340
 
341 341
         $this->objectManager->flush();
@@ -532,7 +532,7 @@  discard block
 block discarded – undo
532 532
 
533 533
         /** @var ImageInterface $productImage */
534 534
         $productImage = $this->productImageFactory->createNew();
535
-        $productImage->setFile(new UploadedFile($filesPath.$imagePath, basename($imagePath)));
535
+        $productImage->setFile(new UploadedFile($filesPath . $imagePath, basename($imagePath)));
536 536
         $productImage->setCode($imageCode);
537 537
         $this->imageUploader->upload($productImage);
538 538
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Transform/OrderContext.php 1 patch
Unused Use Statements   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,9 +12,8 @@
 block discarded – undo
12 12
 namespace Sylius\Behat\Context\Transform;
13 13
 
14 14
 use Behat\Behat\Context\Context;
15
-use Sylius\Component\Core\Model\OrderInterface;
16
-use Sylius\Component\Core\Repository\OrderRepositoryInterface;
17 15
 use Sylius\Component\Core\Repository\CustomerRepositoryInterface;
16
+use Sylius\Component\Core\Repository\OrderRepositoryInterface;
18 17
 use Webmozart\Assert\Assert;
19 18
 
20 19
 /**
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Transform/ProductVariantContext.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 
14 14
 use Behat\Behat\Context\Context;
15 15
 use Sylius\Component\Core\Repository\ProductRepositoryInterface;
16
-use Sylius\Component\Core\Repository\ProductVariantRepositoryInterface;
17 16
 use Sylius\Component\Resource\Repository\RepositoryInterface;
18 17
 use Webmozart\Assert\Assert;
19 18
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Ui/Admin/ManagingProductsContext.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -205,6 +205,7 @@
 block discarded – undo
205 205
      * @Then the product :productName should appear in the shop
206 206
      * @Then the product :productName should be in the shop
207 207
      * @Then this product should still be named :productName
208
+     * @param string $productName
208 209
      */
209 210
     public function theProductShouldAppearInTheShop($productName)
210 211
     {
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,16 +15,16 @@
 block discarded – undo
15 15
 use Sylius\Behat\NotificationType;
16 16
 use Sylius\Behat\Page\Admin\Crud\CreatePageInterface;
17 17
 use Sylius\Behat\Page\Admin\Crud\UpdatePageInterface;
18
+use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
18 19
 use Sylius\Behat\Page\Admin\Product\CreateConfigurableProductPageInterface;
19 20
 use Sylius\Behat\Page\Admin\Product\CreateSimpleProductPageInterface;
20 21
 use Sylius\Behat\Page\Admin\Product\IndexPageInterface;
21 22
 use Sylius\Behat\Page\Admin\Product\UpdateConfigurableProductPageInterface;
22 23
 use Sylius\Behat\Page\Admin\Product\UpdateSimpleProductPageInterface;
23
-use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
24 24
 use Sylius\Behat\Service\NotificationCheckerInterface;
25 25
 use Sylius\Behat\Service\Resolver\CurrentProductPageResolverInterface;
26
-use Sylius\Component\Core\Model\ProductInterface;
27 26
 use Sylius\Behat\Service\SharedStorageInterface;
27
+use Sylius\Component\Core\Model\ProductInterface;
28 28
 use Sylius\Component\Taxonomy\Model\TaxonInterface;
29 29
 use Webmozart\Assert\Assert;
30 30
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Ui/Admin/ManagingProductVariantsContext.php 3 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -150,6 +150,7 @@  discard block
 block discarded – undo
150 150
 
151 151
     /**
152 152
      * @Then the :productVariantCode variant of the :product product should appear in the shop
153
+     * @param string $productVariantCode
153 154
      */
154 155
     public function theProductVariantShouldAppearInTheShop($productVariantCode, ProductInterface $product)
155 156
     {
@@ -451,7 +452,7 @@  discard block
 block discarded – undo
451 452
 
452 453
     /**
453 454
      * @param string $element
454
-     * @param $message
455
+     * @param string $message
455 456
      */
456 457
     private function assertValidationMessage($element, $message)
457 458
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
     {
289 289
         Assert::true(
290 290
             $this->indexPage->isSingleResourceWithSpecificElementOnPage(['name' => $productVariantName], sprintf('td > div.ui.label:contains("%s")', $quantity)),
291
-            sprintf('The product variant %s should have %s items on hand, but it does not.',$productVariantName, $quantity)
291
+            sprintf('The product variant %s should have %s items on hand, but it does not.', $productVariantName, $quantity)
292 292
         );
293 293
     }
294 294
 
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
 
302 302
         Assert::true(
303 303
             $this->indexPage->isSingleResourceWithSpecificElementOnPage(['name' => $productVariantName], sprintf('td > div.ui.label:contains("%s")', $quantity)),
304
-            sprintf('The product variant %s should have %s items on hand, but it does not.',$productVariantName, $quantity)
304
+            sprintf('The product variant %s should have %s items on hand, but it does not.', $productVariantName, $quantity)
305 305
         );
306 306
     }
307 307
 
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,9 +15,9 @@
 block discarded – undo
15 15
 use Sylius\Behat\Page\Admin\Channel\IndexPageInterface;
16 16
 use Sylius\Behat\Page\Admin\Channel\UpdatePageInterface;
17 17
 use Sylius\Behat\Page\Shop\HomePageInterface;
18
+use Sylius\Behat\Service\SharedStorageInterface;
18 19
 use Sylius\Bundle\ThemeBundle\Model\ThemeInterface;
19 20
 use Sylius\Component\Core\Model\ChannelInterface;
20
-use Sylius\Behat\Service\SharedStorageInterface;
21 21
 use Webmozart\Assert\Assert;
22 22
 
23 23
 /**
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Ui/ThemeContext.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,9 +15,9 @@
 block discarded – undo
15 15
 use Sylius\Behat\Page\Admin\Channel\IndexPageInterface;
16 16
 use Sylius\Behat\Page\Admin\Channel\UpdatePageInterface;
17 17
 use Sylius\Behat\Page\Shop\HomePageInterface;
18
+use Sylius\Behat\Service\SharedStorageInterface;
18 19
 use Sylius\Bundle\ThemeBundle\Model\ThemeInterface;
19 20
 use Sylius\Component\Core\Model\ChannelInterface;
20
-use Sylius\Behat\Service\SharedStorageInterface;
21 21
 use Webmozart\Assert\Assert;
22 22
 
23 23
 /**
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Account/LoginPageInterface.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -25,15 +25,20 @@
 block discarded – undo
25 25
      */
26 26
     public function hasValidationErrorWith($message);
27 27
 
28
+    /**
29
+     * @return void
30
+     */
28 31
     public function logIn();
29 32
 
30 33
     /**
31 34
      * @param string $password
35
+     * @return void
32 36
      */
33 37
     public function specifyPassword($password);
34 38
 
35 39
     /**
36 40
      * @param string $userName
41
+     * @return void
37 42
      */
38 43
     public function specifyUserName($userName);
39 44
 }
Please login to merge, or discard this patch.