Sylius\Bundle\UiBundle\Twig\SortByExtension

Complexity

Total Complexity

6

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getFilters()	0	6	1
B	sortBy()	0	26	4
A	getName()	0	4	1

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sylius\Bundle\UiBundle\Twig;

use Doctrine\Common\Collections\Collection;
use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
use Symfony\Component\PropertyAccess\PropertyAccess;

/**
 * @author Jan Góralski <jan.goralski@lakion.com>
 */
class SortByExtension extends \Twig_Extension
{
    /**
     * {@inheritdoc}
     */
    public function getFilters()
    {
        return [
            new \Twig_SimpleFilter('sort_by', [$this, 'sortBy']),
        ];
    }

    /**
     * @param array|Collection $array
     * @param string $field
     * @param string $order
     *
     * @return array
     *
     * @throws NoSuchPropertyException
     */
    public function sortBy($array, $field, $order = 'ASC')
    {
        if ($array instanceof Collection) {
            $array = $array->toArray();
        }
        if (1 >= count($array)) {
            return $array;
        }

        /** "@usort" so it won't explode on php 5.6 */
        @usort($array, function ($firstElement, $secondElement) use ($field, $order) {

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $accessor = PropertyAccess::createPropertyAccessor();

            $firstProperty = $accessor->getValue($firstElement, $field);
            $secondProperty = $accessor->getValue($secondElement, $field);

            $result = strcasecmp($firstProperty, $secondProperty);
            if ('DESC' === $order) {
                $result *= -1;
            }

            return $result;
        });

        return $array;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'sort_by';
    }
}