Completed
Push — pull-request/8500 ( e49efc...54b484 )
by Kamil
36:05 queued 17:36
created
app/migrations/Version20161214153137.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 
34 34
         $this->addSql('CREATE TABLE sylius_product_variant_translation (id INT AUTO_INCREMENT NOT NULL, translatable_id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, locale VARCHAR(255) NOT NULL, INDEX IDX_8DC18EDC2C2AC5D3 (translatable_id), UNIQUE INDEX sylius_product_variant_translation_uniq_trans (translatable_id, locale), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB');
35 35
         $this->addSql('ALTER TABLE sylius_product_variant_translation ADD CONSTRAINT FK_8DC18EDC2C2AC5D3 FOREIGN KEY (translatable_id) REFERENCES sylius_product_variant (id) ON DELETE CASCADE');
36
-        $this->addSql('INSERT INTO sylius_product_variant_translation (translatable_id, name, locale) SELECT id, name, "'.$defaultLocale.'" from sylius_product_variant WHERE sylius_product_variant.name IS NOT null');
36
+        $this->addSql('INSERT INTO sylius_product_variant_translation (translatable_id, name, locale) SELECT id, name, "' . $defaultLocale . '" from sylius_product_variant WHERE sylius_product_variant.name IS NOT null');
37 37
         $this->addSql('ALTER TABLE sylius_product_variant DROP name');
38 38
     }
39 39
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $this->abortIf($this->connection->getDatabasePlatform()->getName() != 'mysql', 'Migration can only be executed safely on \'mysql\'.');
48 48
 
49 49
         $this->addSql('ALTER TABLE sylius_product_variant ADD name VARCHAR(255) DEFAULT NULL COLLATE utf8_unicode_ci');
50
-        $this->addSql('UPDATE sylius_product_variant SET name = (SELECT name FROM sylius_product_variant_translation WHERE sylius_product_variant_translation.translatable_id = sylius_product_variant.id AND sylius_product_variant_translation.locale = "'.$defaultLocale.'")');
50
+        $this->addSql('UPDATE sylius_product_variant SET name = (SELECT name FROM sylius_product_variant_translation WHERE sylius_product_variant_translation.translatable_id = sylius_product_variant.id AND sylius_product_variant_translation.locale = "' . $defaultLocale . '")');
51 51
         $this->addSql('DROP TABLE sylius_product_variant_translation');
52 52
     }
53 53
 }
Please login to merge, or discard this patch.
Component/Core/Resolver/ZoneAndChannelBasedShippingMethodsResolver.php 2 patches
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,12 +12,12 @@
 block discarded – undo
12 12
 namespace Sylius\Component\Core\Resolver;
13 13
 
14 14
 use Sylius\Component\Addressing\Matcher\ZoneMatcherInterface;
15
-use Sylius\Component\Core\Model\Scope;
16 15
 use Sylius\Component\Core\Model\OrderInterface;
16
+use Sylius\Component\Core\Model\Scope;
17 17
 use Sylius\Component\Core\Model\ShipmentInterface;
18
+use Sylius\Component\Core\Repository\ShippingMethodRepositoryInterface;
18 19
 use Sylius\Component\Shipping\Checker\ShippingMethodEligibilityCheckerInterface;
19 20
 use Sylius\Component\Shipping\Model\ShippingSubjectInterface;
20
-use Sylius\Component\Core\Repository\ShippingMethodRepositoryInterface;
21 21
 use Sylius\Component\Shipping\Resolver\ShippingMethodsResolverInterface;
22 22
 use Webmozart\Assert\Assert;
23 23
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Component\Core\Resolver;
15 15
 
Please login to merge, or discard this patch.
Core/spec/Resolver/ZoneAndChannelBasedShippingMethodsResolverSpec.php 2 patches
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,16 +14,16 @@
 block discarded – undo
14 14
 use PhpSpec\ObjectBehavior;
15 15
 use Sylius\Component\Addressing\Matcher\ZoneMatcherInterface;
16 16
 use Sylius\Component\Addressing\Model\ZoneInterface;
17
-use Sylius\Component\Core\Model\Scope;
18 17
 use Sylius\Component\Core\Model\AddressInterface;
19 18
 use Sylius\Component\Core\Model\ChannelInterface;
20 19
 use Sylius\Component\Core\Model\OrderInterface;
20
+use Sylius\Component\Core\Model\Scope;
21 21
 use Sylius\Component\Core\Model\ShipmentInterface;
22 22
 use Sylius\Component\Core\Model\ShippingMethodInterface;
23
+use Sylius\Component\Core\Repository\ShippingMethodRepositoryInterface;
23 24
 use Sylius\Component\Core\Resolver\ZoneAndChannelBasedShippingMethodsResolver;
24 25
 use Sylius\Component\Shipping\Checker\ShippingMethodEligibilityCheckerInterface;
25 26
 use Sylius\Component\Shipping\Model\ShippingSubjectInterface;
26
-use Sylius\Component\Core\Repository\ShippingMethodRepositoryInterface;
27 27
 use Sylius\Component\Shipping\Resolver\ShippingMethodsResolverInterface;
28 28
 
29 29
 /**
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace spec\Sylius\Component\Core\Resolver;
15 15
 
Please login to merge, or discard this patch.
app/migrations/Version20161219160441.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         $this->addSql('CREATE TABLE sylius_product_association_type_translation (id INT AUTO_INCREMENT NOT NULL, translatable_id INT NOT NULL, name VARCHAR(255) DEFAULT NULL, locale VARCHAR(255) NOT NULL, INDEX IDX_4F618E52C2AC5D3 (translatable_id), UNIQUE INDEX sylius_product_association_type_translation_uniq_trans (translatable_id, locale), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB');
38 38
         $this->addSql('ALTER TABLE sylius_product_association_type_translation ADD CONSTRAINT FK_4F618E52C2AC5D3 FOREIGN KEY (translatable_id) REFERENCES sylius_product_association_type (id) ON DELETE CASCADE');
39
-        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "'.$defaultLocale.'" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
39
+        $this->addSql('INSERT INTO sylius_product_association_type_translation (translatable_id, name, locale) SELECT id, name, "' . $defaultLocale . '" from sylius_product_association_type WHERE sylius_product_association_type.name IS NOT null');
40 40
         $this->addSql('ALTER TABLE sylius_product_association_type DROP name');
41 41
     }
42 42
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
         $defaultLocale = $this->container->getParameter('locale');
51 51
 
52 52
         $this->addSql('ALTER TABLE sylius_product_association_type ADD name VARCHAR(255) NOT NULL COLLATE utf8_unicode_ci');
53
-        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "'.$defaultLocale.'")');
53
+        $this->addSql('UPDATE sylius_product_association_type SET name = (SELECT name FROM sylius_product_association_type_translation WHERE sylius_product_association_type_translation.translatable_id = sylius_product_association_type.id AND sylius_product_association_type_translation.locale = "' . $defaultLocale . '")');
54 54
         $this->addSql('DROP TABLE sylius_product_association_type_translation');
55 55
     }
56 56
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Shop/Checkout/AddressPage.php 2 patches
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -429,6 +429,8 @@
 block discarded – undo
429 429
     }
430 430
 
431 431
     /**
432
+     * @param integer $timeout
433
+     * @param string $elementName
432 434
      * @return bool
433 435
      */
434 436
     private function waitForElement($timeout, $elementName)
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Behat\Page\Shop\Checkout;
15 15
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Context/Ui/Admin/ManagingProductsContext.php 3 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,13 +16,13 @@
 block discarded – undo
16 16
 use Sylius\Behat\NotificationType;
17 17
 use Sylius\Behat\Page\Admin\Crud\CreatePageInterface;
18 18
 use Sylius\Behat\Page\Admin\Crud\UpdatePageInterface;
19
+use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
19 20
 use Sylius\Behat\Page\Admin\Product\CreateConfigurableProductPageInterface;
20 21
 use Sylius\Behat\Page\Admin\Product\CreateSimpleProductPageInterface;
21 22
 use Sylius\Behat\Page\Admin\Product\IndexPageInterface;
22 23
 use Sylius\Behat\Page\Admin\Product\IndexPerTaxonPageInterface;
23 24
 use Sylius\Behat\Page\Admin\Product\UpdateConfigurableProductPageInterface;
24 25
 use Sylius\Behat\Page\Admin\Product\UpdateSimpleProductPageInterface;
25
-use Sylius\Behat\Page\Admin\ProductReview\IndexPageInterface as ProductReviewIndexPageInterface;
26 26
 use Sylius\Behat\Page\SymfonyPageInterface;
27 27
 use Sylius\Behat\Service\NotificationCheckerInterface;
28 28
 use Sylius\Behat\Service\Resolver\CurrentPageResolverInterface;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace Sylius\Behat\Context\Ui\Admin;
15 15
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -259,6 +259,7 @@
 block discarded – undo
259 259
      * @Then the product :productName should appear in the store
260 260
      * @Then the product :productName should be in the shop
261 261
      * @Then this product should still be named :productName
262
+     * @param string|null $productName
262 263
      */
263 264
     public function theProductShouldAppearInTheShop($productName)
264 265
     {
Please login to merge, or discard this patch.
Sylius/Component/Core/spec/Customer/Statistics/CustomerStatisticsSpec.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@  discard block
 block discarded – undo
46 46
         $this->getAllOrdersCount()->shouldReturn(0);
47 47
     }
48 48
 
49
-    function it_has_number_of_all_orders(ChannelInterface $channel) {
49
+    function it_has_number_of_all_orders(ChannelInterface $channel)
50
+    {
50 51
         $firstStatistics = new PerChannelCustomerStatistics(110, 120, $channel->getWrappedObject());
51 52
         $secondStatistics = new PerChannelCustomerStatistics(13, 120, $channel->getWrappedObject());
52 53
 
@@ -55,7 +56,8 @@  discard block
 block discarded – undo
55 56
         $this->getAllOrdersCount()->shouldReturn(123);
56 57
     }
57 58
 
58
-    function it_has_an_array_of_statistics_per_channel(ChannelInterface $channel) {
59
+    function it_has_an_array_of_statistics_per_channel(ChannelInterface $channel)
60
+    {
59 61
         $firstStatistics = new PerChannelCustomerStatistics(110, 120, $channel->getWrappedObject());
60 62
         $secondStatistics = new PerChannelCustomerStatistics(13, 120, $channel->getWrappedObject());
61 63
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace spec\Sylius\Component\Core\Customer\Statistics;
15 15
 
Please login to merge, or discard this patch.
Sylius/Bundle/ResourceBundle/test/src/Tests/Controller/ComicBookApiTest.php 3 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         }
73 73
 EOT;
74 74
 
75
-        $this->client->request('PUT', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
75
+        $this->client->request('PUT', '/v1/comic-books/' . $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
76 76
         $response = $this->client->getResponse();
77 77
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
78 78
     }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         }
93 93
 EOT;
94 94
 
95
-        $this->client->request('PATCH', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
95
+        $this->client->request('PATCH', '/v1/comic-books/' . $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
96 96
         $response = $this->client->getResponse();
97 97
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
98 98
     }
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     {
105 105
         $objects = $this->loadFixturesFromFile('comic_books.yml');
106 106
 
107
-        $this->client->request('DELETE', '/v1/comic-books/'. $objects["comic-book1"]->getId());
107
+        $this->client->request('DELETE', '/v1/comic-books/' . $objects["comic-book1"]->getId());
108 108
         $response = $this->client->getResponse();
109 109
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
110 110
     }
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
     {
117 117
         $objects = $this->loadFixturesFromFile('comic_books.yml');
118 118
 
119
-        $this->client->request('GET', '/v1/comic-books/'. $objects["comic-book1"]->getId());
119
+        $this->client->request('GET', '/v1/comic-books/' . $objects["comic-book1"]->getId());
120 120
         $response = $this->client->getResponse();
121 121
         $this->assertResponse($response, 'comic-books/show_response');
122 122
     }
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     {
129 129
         $objects = $this->loadFixturesFromFile('comic_books.yml');
130 130
 
131
-        $this->client->request('GET', '/v1.2/comic-books/'. $objects["comic-book1"]->getId());
131
+        $this->client->request('GET', '/v1.2/comic-books/' . $objects["comic-book1"]->getId());
132 132
         $response = $this->client->getResponse();
133 133
         $this->assertResponse($response, 'comic-books/versioned_show_response');
134 134
     }
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
         $objects = $this->loadFixturesFromFile('comic_books.yml');
86 86
 
87 87
         $data =
88
- <<<EOT
88
+    <<<EOT
89 89
         {
90 90
             "authorFirstName": "Joe",
91 91
             "authorLastName": "Kelly"
Please login to merge, or discard this patch.
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
             "authorFirstName": "Joe",
32 32
             "authorLastName": "Kelly"
33 33
         }
34
-EOT;
34
+eot;
35 35
 
36 36
         $this->client->request('POST', '/v1/comic-books/', [], [], ['CONTENT_TYPE' => 'application/json'], $data);
37 37
         $response = $this->client->getResponse();
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             "authorFirstName": "Joe",
50 50
             "authorLastName": "Kelly"
51 51
         }
52
-EOT;
52
+eot;
53 53
 
54 54
         $this->client->request('POST', '/v1.2/comic-books/', [], [], ['CONTENT_TYPE' => 'application/json'], $data);
55 55
         $response = $this->client->getResponse();
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
             "authorFirstName": "Joe",
71 71
             "authorLastName": "Kelly"
72 72
         }
73
-EOT;
73
+eot;
74 74
 
75 75
         $this->client->request('PUT', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
76 76
         $response = $this->client->getResponse();
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
             "authorFirstName": "Joe",
91 91
             "authorLastName": "Kelly"
92 92
         }
93
-EOT;
93
+eot;
94 94
 
95 95
         $this->client->request('PATCH', '/v1/comic-books/'. $objects["comic-book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
96 96
         $response = $this->client->getResponse();
Please login to merge, or discard this patch.
src/Sylius/Component/Core/spec/Model/OrderSpec.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,10 +23,10 @@
 block discarded – undo
23 23
 use Sylius\Component\Core\Model\ShipmentInterface;
24 24
 use Sylius\Component\Core\OrderCheckoutStates;
25 25
 use Sylius\Component\Core\OrderShippingStates;
26
+use Sylius\Component\Customer\Model\CustomerInterface;
26 27
 use Sylius\Component\Order\Model\Order as BaseOrder;
27 28
 use Sylius\Component\Order\Model\OrderInterface;
28 29
 use Sylius\Component\Promotion\Model\PromotionCouponInterface;
29
-use Sylius\Component\Customer\Model\CustomerInterface;
30 30
 
31 31
 /**
32 32
  * @author Paweł Jędrzejewski <[email protected]>
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
  * file that was distributed with this source code.
10 10
  */
11 11
 
12
-declare(strict_types=1);
12
+declare(strict_types = 1);
13 13
 
14 14
 namespace spec\Sylius\Component\Core\Model;
15 15
 
Please login to merge, or discard this patch.