Inspection of "Replace resource translations type with its FQCN" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — symfony3-fqcn ( 71214e )

by Kamil

created 2016-11-22 17:18 UTC

Status

Doc Comments +12 added lines patch added patch discarded remove patch

@@ -19,17 +19,25 @@  discard block
 block discarded – undo
  */
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
 
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $themeName
+     * @return void
      */
     public function setTheme($themeName);
 
     /**
      * @throws ElementNotFoundException
+     * @return void
      */
     public function unsetTheme();
 
@@ -40,6 +48,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $language
+     * @return void
      */
     public function chooseLocale($language);
 
@@ -52,6 +61,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $currencyCode
+     * @return void
      */
     public function chooseCurrency($currencyCode);
 
@@ -64,6 +74,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $shippingMethod
+     * @return void
      */
     public function chooseShippingMethod($shippingMethod);
 
@@ -76,6 +87,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $paymentMethod
+     * @return void
      */
     public function choosePaymentMethod($paymentMethod);
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Country/UpdatePageInterface.php 1 patch

Doc Comments +15 added lines patch added patch discarded remove patch

@@ -18,7 +18,14 @@  discard block
 block discarded – undo
  */
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
+
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
@@ -44,28 +51,36 @@  discard block
 block discarded – undo
      * @param string $name
      * @param string $code
      * @param string|null $abbreviation
+     * @return void
      */
     public function addProvince($name, $code, $abbreviation = null);
 
     /**
      * @param string $provinceName
+     * @return void
      */
     public function removeProvince($provinceName);
 
+    /**
+     * @return void
+     */
     public function clickAddProvinceButton();
 
     /**
      * @param string $provinceName
+     * @return void
      */
     public function nameProvince($provinceName);
 
     /**
      * @param string $provinceName
+     * @return void
      */
     public function removeProvinceName($provinceName);
 
     /**
      * @param string $provinceCode
+     * @return void
      */
     public function specifyProvinceCode($provinceCode);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Currency/UpdatePageInterface.php 1 patch

Doc Comments +8 added lines patch added patch discarded remove patch

@@ -18,11 +18,19 @@
 block discarded – undo
  */
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
+
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $exchangeRate
+     * @return void
      */
     public function changeExchangeRate($exchangeRate);
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Locale/UpdatePageInterface.php 1 patch

Doc Comments +7 added lines patch added patch discarded remove patch

@@ -18,6 +18,13 @@
 block discarded – undo
  */
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
+
+    /**
+     * @return void
+     */
     public function disable();
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/PaymentMethod/UpdatePageInterface.php 1 patch

Doc Comments +9 added lines patch added patch discarded remove patch

@@ -18,11 +18,19 @@  discard block
 block discarded – undo
  */
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
+
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $gateway
+     * @return void
      */
     public function chooseGateway($gateway);
 
@@ -39,6 +47,7 @@  discard block
 block discarded – undo
     /**
      * @param string $name
      * @param string $languageCode
+     * @return void
      */
     public function nameIt($name, $languageCode);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/ProductOption/CreatePageInterface.php 1 patch

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -20,23 +20,27 @@
 block discarded – undo
 {
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $name
      * @param string $language
+     * @return void
      */
     public function nameItIn($name, $language);
 
     /**
      * @param string $code
      * @param string $value
+     * @return void
      */
     public function addOptionValue($code, $value);
 
     /**
      * @param string $message
+     * @return boolean
      */
     public function checkValidationMessageForOptionValues($message);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/ProductOption/UpdatePageInterface.php 1 patch

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -26,22 +26,26 @@
 block discarded – undo
     /**
      * @param string $name
      * @param string $languageCode
+     * @return void
      */
     public function nameItIn($name, $languageCode);
 
     /**
      * @param string $optionValue
+     * @return boolean
      */
     public function isThereOptionValue($optionValue);
 
     /**
      * @param string $code
      * @param string $value
+     * @return void
      */
     public function addOptionValue($code, $value);
 
     /**
      * @param string $optionValue
+     * @return void
      */
     public function removeOptionValue($optionValue);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Promotion/UpdatePageInterface.php 1 patch

Doc Comments +13 added lines patch added patch discarded remove patch

@@ -21,6 +21,7 @@  discard block
 block discarded – undo
 {
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
@@ -38,35 +39,47 @@  discard block
 block discarded – undo
 
     /**
      * @param string $limit
+     * @return void
      */
     public function fillUsageLimit($limit);
 
+    /**
+     * @return void
+     */
     public function makeExclusive();
 
+    /**
+     * @return void
+     */
     public function checkCouponBased();
 
     /**
      * @param string $name
+     * @return void
      */
     public function checkChannel($name);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setStartsAt(\DateTime $dateTime);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setEndsAt(\DateTime $dateTime);
 
     /**
      * {@inheritdoc}
+     * @return boolean
      */
     public function hasStartsAt(\DateTime $dateTime);
 
     /**
      * {@inheritdoc}
+     * @return boolean
      */
     public function hasEndsAt(\DateTime $dateTime);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/PromotionCoupon/GeneratePageInterface.php 1 patch

Doc Comments +7 added lines patch added patch discarded remove patch

@@ -39,25 +39,32 @@
 block discarded – undo
      */
     public function checkGenerationValidation($message);
 
+    /**
+     * @return void
+     */
     public function generate();
 
     /**
      * @param int $amount
+     * @return void
      */
     public function specifyAmount($amount);
 
     /**
      * @param int $codeLength
+     * @return void
      */
     public function specifyCodeLength($codeLength);
 
     /**
      * @param \DateTime $date
+     * @return void
      */
     public function setExpiresAt(\DateTime $date);
 
     /**
      * @param int $limit
+     * @return void
      */
     public function setUsageLimit($limit);
 }

Please login to merge, or discard this patch.

		@@ -19,17 +19,25 @@ discard block
		block discarded – undo
19	19	*/
20	20	interface UpdatePageInterface extends BaseUpdatePageInterface
21	21	{
	22	+ /**
	23	+ * @return void
	24	+ */
22	25	public function enable();
23	26
	27	+ /**
	28	+ * @return void
	29	+ */
24	30	public function disable();
25	31
26	32	/**
27	33	* @param string $themeName
	34	+ * @return void
28	35	*/
29	36	public function setTheme($themeName);
30	37
31	38	/**
32	39	* @throws ElementNotFoundException
	40	+ * @return void
33	41	*/
34	42	public function unsetTheme();
35	43
		@@ -40,6 +48,7 @@ discard block
		block discarded – undo
40	48
41	49	/**
42	50	* @param string $language
	51	+ * @return void
43	52	*/
44	53	public function chooseLocale($language);
45	54
		@@ -52,6 +61,7 @@ discard block
		block discarded – undo
52	61
53	62	/**
54	63	* @param string $currencyCode
	64	+ * @return void
55	65	*/
56	66	public function chooseCurrency($currencyCode);
57	67
		@@ -64,6 +74,7 @@ discard block
		block discarded – undo
64	74
65	75	/**
66	76	* @param string $shippingMethod
	77	+ * @return void
67	78	*/
68	79	public function chooseShippingMethod($shippingMethod);
69	80
		@@ -76,6 +87,7 @@ discard block
		block discarded – undo
76	87
77	88	/**
78	89	* @param string $paymentMethod
	90	+ * @return void
79	91	*/
80	92	public function choosePaymentMethod($paymentMethod);
81	93

		@@ -18,7 +18,14 @@ discard block
		block discarded – undo
18	18	*/
19	19	interface UpdatePageInterface extends BaseUpdatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
	25	+
	26	+ /**
	27	+ * @return void
	28	+ */
22	29	public function disable();
23	30
24	31	/**
		@@ -44,28 +51,36 @@ discard block
		block discarded – undo
44	51	* @param string $name
45	52	* @param string $code
46	53	* @param string\|null $abbreviation
	54	+ * @return void
47	55	*/
48	56	public function addProvince($name, $code, $abbreviation = null);
49	57
50	58	/**
51	59	* @param string $provinceName
	60	+ * @return void
52	61	*/
53	62	public function removeProvince($provinceName);
54	63
	64	+ /**
	65	+ * @return void
	66	+ */
55	67	public function clickAddProvinceButton();
56	68
57	69	/**
58	70	* @param string $provinceName
	71	+ * @return void
59	72	*/
60	73	public function nameProvince($provinceName);
61	74
62	75	/**
63	76	* @param string $provinceName
	77	+ * @return void
64	78	*/
65	79	public function removeProvinceName($provinceName);
66	80
67	81	/**
68	82	* @param string $provinceCode
	83	+ * @return void
69	84	*/
70	85	public function specifyProvinceCode($provinceCode);
71	86	}

		@@ -18,11 +18,19 @@
		block discarded – undo
18	18	*/
19	19	interface UpdatePageInterface extends BaseUpdatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
	25	+
	26	+ /**
	27	+ * @return void
	28	+ */
22	29	public function disable();
23	30
24	31	/**
25	32	* @param string $exchangeRate
	33	+ * @return void
26	34	*/
27	35	public function changeExchangeRate($exchangeRate);
28	36

		@@ -18,6 +18,13 @@
		block discarded – undo
18	18	*/
19	19	interface UpdatePageInterface extends BaseUpdatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
	25	+
	26	+ /**
	27	+ * @return void
	28	+ */
22	29	public function disable();
23	30	}

		@@ -18,11 +18,19 @@ discard block
		block discarded – undo
18	18	*/
19	19	interface UpdatePageInterface extends BaseUpdatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
	25	+
	26	+ /**
	27	+ * @return void
	28	+ */
22	29	public function disable();
23	30
24	31	/**
25	32	* @param string $gateway
	33	+ * @return void
26	34	*/
27	35	public function chooseGateway($gateway);
28	36
		@@ -39,6 +47,7 @@ discard block
		block discarded – undo
39	47	/**
40	48	* @param string $name
41	49	* @param string $languageCode
	50	+ * @return void
42	51	*/
43	52	public function nameIt($name, $languageCode);
44	53	}

		@@ -20,23 +20,27 @@
		block discarded – undo
20	20	{
21	21	/**
22	22	* @param string $code
	23	+ * @return void
23	24	*/
24	25	public function specifyCode($code);
25	26
26	27	/**
27	28	* @param string $name
28	29	* @param string $language
	30	+ * @return void
29	31	*/
30	32	public function nameItIn($name, $language);
31	33
32	34	/**
33	35	* @param string $code
34	36	* @param string $value
	37	+ * @return void
35	38	*/
36	39	public function addOptionValue($code, $value);
37	40
38	41	/**
39	42	* @param string $message
	43	+ * @return boolean
40	44	*/
41	45	public function checkValidationMessageForOptionValues($message);
42	46	}

		@@ -26,22 +26,26 @@
		block discarded – undo
26	26	/**
27	27	* @param string $name
28	28	* @param string $languageCode
	29	+ * @return void
29	30	*/
30	31	public function nameItIn($name, $languageCode);
31	32
32	33	/**
33	34	* @param string $optionValue
	35	+ * @return boolean
34	36	*/
35	37	public function isThereOptionValue($optionValue);
36	38
37	39	/**
38	40	* @param string $code
39	41	* @param string $value
	42	+ * @return void
40	43	*/
41	44	public function addOptionValue($code, $value);
42	45
43	46	/**
44	47	* @param string $optionValue
	48	+ * @return void
45	49	*/
46	50	public function removeOptionValue($optionValue);
47	51	}

		@@ -21,6 +21,7 @@ discard block
		block discarded – undo
21	21	{
22	22	/**
23	23	* @param string $name
	24	+ * @return void
24	25	*/
25	26	public function nameIt($name);
26	27
		@@ -38,35 +39,47 @@ discard block
		block discarded – undo
38	39
39	40	/**
40	41	* @param string $limit
	42	+ * @return void
41	43	*/
42	44	public function fillUsageLimit($limit);
43	45
	46	+ /**
	47	+ * @return void
	48	+ */
44	49	public function makeExclusive();
45	50
	51	+ /**
	52	+ * @return void
	53	+ */
46	54	public function checkCouponBased();
47	55
48	56	/**
49	57	* @param string $name
	58	+ * @return void
50	59	*/
51	60	public function checkChannel($name);
52	61
53	62	/**
54	63	* @param \DateTime $dateTime
	64	+ * @return void
55	65	*/
56	66	public function setStartsAt(\DateTime $dateTime);
57	67
58	68	/**
59	69	* @param \DateTime $dateTime
	70	+ * @return void
60	71	*/
61	72	public function setEndsAt(\DateTime $dateTime);
62	73
63	74	/**
64	75	* {@inheritdoc}
	76	+ * @return boolean
65	77	*/
66	78	public function hasStartsAt(\DateTime $dateTime);
67	79
68	80	/**
69	81	* {@inheritdoc}
	82	+ * @return boolean
70	83	*/
71	84	public function hasEndsAt(\DateTime $dateTime);
72	85	}

		@@ -39,25 +39,32 @@
		block discarded – undo
39	39	*/
40	40	public function checkGenerationValidation($message);
41	41
	42	+ /**
	43	+ * @return void
	44	+ */
42	45	public function generate();
43	46
44	47	/**
45	48	* @param int $amount
	49	+ * @return void
46	50	*/
47	51	public function specifyAmount($amount);
48	52
49	53	/**
50	54	* @param int $codeLength
	55	+ * @return void
51	56	*/
52	57	public function specifyCodeLength($codeLength);
53	58
54	59	/**
55	60	* @param \DateTime $date
	61	+ * @return void
56	62	*/
57	63	public function setExpiresAt(\DateTime $date);
58	64
59	65	/**
60	66	* @param int $limit
	67	+ * @return void
61	68	*/
62	69	public function setUsageLimit($limit);
63	70	}

pamil / Sylius

Push — symfony3-fqcn ( 71214e )

Status

Category

Doc Comments +12 added lines patch added patch discarded remove patch

Doc Comments +15 added lines patch added patch discarded remove patch

Doc Comments +8 added lines patch added patch discarded remove patch

Doc Comments +7 added lines patch added patch discarded remove patch

Doc Comments +9 added lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Doc Comments +13 added lines patch added patch discarded remove patch

Doc Comments +7 added lines patch added patch discarded remove patch