Sylius\Bundle\CoreBundle\Validator\Constraints\UniqueReviewerEmailValidator

Complexity

Total Complexity

11

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
B	validate()	0	20	6
A	getAuthenticatedUserEmail()	0	18	4

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Sylius\Bundle\CoreBundle\Validator\Constraints;

use Sylius\Bundle\UserBundle\Doctrine\ORM\UserRepository;
use Sylius\Component\Review\Model\ReviewerInterface;
use Sylius\Component\User\Model\UserInterface;
use Sylius\Component\User\Repository\UserRepositoryInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;

/**
 * @author Mateusz Zalewski <mateusz.zalewski@lakion.com>
 * @author Grzegorz Sadowski <grzegorz.sadowski@lakion.com>
 */
class UniqueReviewerEmailValidator extends ConstraintValidator
{
    /**
     * @var UserRepository
     */
    private $userRepository;

    /**
     * @var TokenStorageInterface
     */
    private $tokenStorage;

    /**
     * @var AuthorizationCheckerInterface
     */
    private $authorizationChecker;

    /**
     * @param UserRepositoryInterface $userRepository
     * @param TokenStorageInterface $tokenStorage
     * @param AuthorizationCheckerInterface $authorizationChecker
     */
    public function __construct(
        UserRepositoryInterface $userRepository,
        TokenStorageInterface $tokenStorage,
        AuthorizationCheckerInterface $authorizationChecker
    ) {
        $this->userRepository = $userRepository;

$userRepository is of type object<Sylius\Component\User\Repository\UserRepositoryInterface>, but the property $userRepository was declared to be of type object<Sylius\Bundle\UserBundle\Doctrine\ORM\UserRepository>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->tokenStorage = $tokenStorage;
        $this->authorizationChecker = $authorizationChecker;
    }

    /**
     * {@inheritdoc}
     */
    public function validate($review, Constraint $constraint)
    {
        /* @var ReviewerInterface|null $customer */
        $customer = $review->getAuthor();

        $token = $this->tokenStorage->getToken();
        if (null !== $customer) {
            if ($customer->getEmail() === null) {
                return;
            }

            if ($customer->getEmail() === $this->getAuthenticatedUserEmail($token)) {

It seems like $token defined by $this->tokenStorage->getToken() on line 70 can be null; however, Sylius\Bundle\CoreBundle\Validator\Constraints\UniqueReviewerEmailValidator::getAuthenticatedUserEmail() does not accept null, maybe add an additional type check?

                return;
            }
        }

        if (null !== $customer && null !== $this->userRepository->findOneByEmail($customer->getEmail())) {
            $this->context->buildViolation($constraint->message)->atPath('author')->addViolation();
        }
    }

    /**
     * @param TokenInterface $token
     *
     * @return string|null
     */
    private function getAuthenticatedUserEmail(TokenInterface $token): ?string
    {
        if (null === $token) {
            return null;
        }

        if (!$this->authorizationChecker->isGranted('IS_AUTHENTICATED_REMEMBERED')) {
            return null;
        }

        $user = $token->getUser();
        if (!$user instanceof UserInterface) {
            return null;
        }

        return $user->getEmail();

    }
}