AddressComparator::normalizeAddress() - Code Metrics - Inspection of "[Addressing] Simplify AddressComparator" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — simplify-address-comparator ( 262042 )

by Kamil

created 2016-10-25 08:29 UTC

AddressComparator::normalizeAddress() A

↳ Parent: AddressComparator

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
rs	9.4285
cc	1
eloc	13
nc	1
nop	1

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sylius\Component\Addressing\Comparator;

use Sylius\Component\Addressing\Model\AddressInterface;

/**
 * @author Jan Góralski <[email protected]>
 */
final class AddressComparator implements AddressComparatorInterface
{
    /**
     * {@inheritdoc}
     */
    public function same(AddressInterface $firstAddress, AddressInterface $secondAddress)
    {
        return $this->normalizeAddress($firstAddress) === $this->normalizeAddress($secondAddress);
    }

    /**
     * @param AddressInterface $address
     *
     * @return array
     */
    private function normalizeAddress(AddressInterface $address)
    {
        return array_map(function ($value) {
            return trim(strtolower($value));
        }, [
            $address->getCity(),
            $address->getCompany(),
            $address->getCountryCode(),
            $address->getFirstName(),
            $address->getLastName(),
            $address->getPhoneNumber(),
            $address->getPostcode(),
            $address->getProvinceCode(),
            $address->getProvinceName(),
            $address->getStreet(),
        ]);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sylius\Component\Addressing\Comparator;
13
14			use Sylius\Component\Addressing\Model\AddressInterface;
15
16			/**
17			* @author Jan Góralski <[email protected]>
18			*/
19			final class AddressComparator implements AddressComparatorInterface
20			{
21			/**
22			* {@inheritdoc}
23			*/
24			public function same(AddressInterface $firstAddress, AddressInterface $secondAddress)
25			{
26			return $this->normalizeAddress($firstAddress) === $this->normalizeAddress($secondAddress);
27			}
28
29			/**
30			* @param AddressInterface $address
31			*
32			* @return array
33			*/
34			private function normalizeAddress(AddressInterface $address)
35			{
36			return array_map(function ($value) {
37			return trim(strtolower($value));
38			}, [
39			$address->getCity(),
40			$address->getCompany(),
41			$address->getCountryCode(),
42			$address->getFirstName(),
43			$address->getLastName(),
44			$address->getPhoneNumber(),
45			$address->getPostcode(),
46			$address->getProvinceCode(),
47			$address->getProvinceName(),
48			$address->getStreet(),
49			]);
50			}
51			}
52

pamil / Sylius

Push — simplify-address-comparator ( 262042 )

AddressComparator::normalizeAddress() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like