Inspection of "Apply coding standard fixes" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.3 ( af1b9f...c8d8d9 )

by Kamil

created 2018-11-14 12:19 UTC

Status

Doc Comments +9 added lines patch added patch discarded remove patch

@@ -6,11 +6,20 @@
 block discarded – undo
 
 interface ResolveNextRouteInterface
 {
+    /**
+     * @return string
+     */
     public function getRouteName(): ?string;
 
+    /**
+     * @return void
+     */
     public function setRouteName(string $routeName): void;
 
     public function getRouteParameters(): array;
 
+    /**
+     * @return void
+     */
     public function setRouteParameters(array $parameters): void;
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Product/IndexPerTaxonPageInterface.php 1 patch

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -30,8 +30,12 @@
 block discarded – undo
     /**
      * @param string $productName
      * @param int $position
+     * @return void
      */
     public function setPositionOfProduct($productName, $position);
 
+    /**
+     * @return void
+     */
     public function savePositions();
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/ProductVariant/IndexPageInterface.php 1 patch

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -38,8 +38,12 @@
 block discarded – undo
     /**
      * @param string $name
      * @param int $position
+     * @return void
      */
     public function setPosition($name, $position);
 
+    /**
+     * @return void
+     */
     public function savePositions();
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Context/Setup/ProductContext.php 1 patch

Doc Comments +1 added lines patch added patch discarded remove patch

@@ -198,6 +198,7 @@
 block discarded – undo
 
     /**
      * @Given /^(this product) is(?:| also) priced at ("[^"]+") in ("[^"]+" channel)$/
+     * @param integer $price
      */
     public function thisProductIsAlsoPricedAtInChannel(ProductInterface $product, $price, ChannelInterface $channel)
     {

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Administrator/CreatePageInterface.php 1 patch

Doc Comments +7 added lines patch added patch discarded remove patch

@@ -17,25 +17,32 @@
 block discarded – undo
 
 interface CreatePageInterface extends BaseCreatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
 
     /**
      * @param string $username
+     * @return void
      */
     public function specifyUsername($username);
 
     /**
      * @param string $email
+     * @return void
      */
     public function specifyEmail($email);
 
     /**
      * @param string $password
+     * @return void
      */
     public function specifyPassword($password);
 
     /**
      * @param string $localeCode
+     * @return void
      */
     public function specifyLocale($localeCode);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Channel/CreatePageInterface.php 1 patch

Doc Comments +24 added lines patch added patch discarded remove patch

@@ -17,71 +17,95 @@
 block discarded – undo
 
 interface CreatePageInterface extends BaseCreatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
 
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $description
+     * @return void
      */
     public function describeItAs($description);
 
     /**
      * @param string $hostname
+     * @return void
      */
     public function setHostname($hostname);
 
     /**
      * @param string $contactEmail
+     * @return void
      */
     public function setContactEmail($contactEmail);
 
     /**
      * @param string $color
+     * @return void
      */
     public function defineColor($color);
 
     /**
      * @param string $language
+     * @return void
      */
     public function chooseLocale($language);
 
     /**
      * @param string $currencyCode
+     * @return void
      */
     public function chooseCurrency($currencyCode);
 
     /**
      * @param string $taxZone
+     * @return void
      */
     public function chooseDefaultTaxZone($taxZone);
 
     /**
      * @param string $locale
+     * @return void
      */
     public function chooseDefaultLocale($locale);
 
     /**
      * @param string $currency
+     * @return void
      */
     public function chooseBaseCurrency($currency);
 
     /**
      * @param string $taxCalculationStrategy
+     * @return void
      */
     public function chooseTaxCalculationStrategy($taxCalculationStrategy);
 
+    /**
+     * @return void
+     */
     public function allowToSkipShippingStep();
 
+    /**
+     * @return void
+     */
     public function allowToSkipPaymentStep();
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Channel/UpdatePageInterface.php 1 patch

Doc Comments +12 added lines patch added patch discarded remove patch

@@ -18,17 +18,25 @@  discard block
 block discarded – undo
 
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
 
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $themeName
+     * @return void
      */
     public function setTheme($themeName);
 
     /**
      * @throws ElementNotFoundException
+     * @return void
      */
     public function unsetTheme();
 
@@ -39,6 +47,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $language
+     * @return void
      */
     public function chooseLocale($language);
 
@@ -51,6 +60,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $currencyCode
+     * @return void
      */
     public function chooseCurrency($currencyCode);
 
@@ -63,11 +73,13 @@  discard block
 block discarded – undo
 
     /**
      * @param string $taxZone
+     * @return void
      */
     public function chooseDefaultTaxZone($taxZone);
 
     /**
      * @param string $taxCalculationStrategy
+     * @return void
      */
     public function chooseTaxCalculationStrategy($taxCalculationStrategy);
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Country/UpdatePageInterface.php 1 patch

Doc Comments +14 added lines patch added patch discarded remove patch

@@ -17,8 +17,14 @@  discard block
 block discarded – undo
 
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
 
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
@@ -44,28 +50,36 @@  discard block
 block discarded – undo
      * @param string $name
      * @param string $code
      * @param string|null $abbreviation
+     * @return void
      */
     public function addProvince($name, $code, $abbreviation = null);
 
     /**
      * @param string $provinceName
+     * @return void
      */
     public function removeProvince($provinceName);
 
+    /**
+     * @return void
+     */
     public function clickAddProvinceButton();
 
     /**
      * @param string $provinceName
+     * @return void
      */
     public function nameProvince($provinceName);
 
     /**
      * @param string $provinceName
+     * @return void
      */
     public function removeProvinceName($provinceName);
 
     /**
      * @param string $provinceCode
+     * @return void
      */
     public function specifyProvinceCode($provinceCode);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Currency/UpdatePageInterface.php 1 patch

Doc Comments +7 added lines patch added patch discarded remove patch

@@ -17,8 +17,14 @@  discard block
 block discarded – undo
 
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
 
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
@@ -33,6 +39,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $exchangeRate
+     * @return void
      */
     public function changeExchangeRate($exchangeRate);
 

Please login to merge, or discard this patch.

		@@ -6,11 +6,20 @@
		block discarded – undo
6	6
7	7	interface ResolveNextRouteInterface
8	8	{
	9	+ /**
	10	+ * @return string
	11	+ */
9	12	public function getRouteName(): ?string;
10	13
	14	+ /**
	15	+ * @return void
	16	+ */
11	17	public function setRouteName(string $routeName): void;
12	18
13	19	public function getRouteParameters(): array;
14	20
	21	+ /**
	22	+ * @return void
	23	+ */
15	24	public function setRouteParameters(array $parameters): void;
16	25	}

		@@ -30,8 +30,12 @@
		block discarded – undo
30	30	/**
31	31	* @param string $productName
32	32	* @param int $position
	33	+ * @return void
33	34	*/
34	35	public function setPositionOfProduct($productName, $position);
35	36
	37	+ /**
	38	+ * @return void
	39	+ */
36	40	public function savePositions();
37	41	}

		@@ -38,8 +38,12 @@
		block discarded – undo
38	38	/**
39	39	* @param string $name
40	40	* @param int $position
	41	+ * @return void
41	42	*/
42	43	public function setPosition($name, $position);
43	44
	45	+ /**
	46	+ * @return void
	47	+ */
44	48	public function savePositions();
45	49	}

		@@ -198,6 +198,7 @@
		block discarded – undo
198	198
199	199	/**
200	200	* @Given /^(this product) is(?:\| also) priced at ("[^"]+") in ("[^"]+" channel)$/
	201	+ * @param integer $price
201	202	*/
202	203	public function thisProductIsAlsoPricedAtInChannel(ProductInterface $product, $price, ChannelInterface $channel)
203	204	{

		@@ -17,25 +17,32 @@
		block discarded – undo
17	17
18	18	interface CreatePageInterface extends BaseCreatePageInterface
19	19	{
	20	+ /**
	21	+ * @return void
	22	+ */
20	23	public function enable();
21	24
22	25	/**
23	26	* @param string $username
	27	+ * @return void
24	28	*/
25	29	public function specifyUsername($username);
26	30
27	31	/**
28	32	* @param string $email
	33	+ * @return void
29	34	*/
30	35	public function specifyEmail($email);
31	36
32	37	/**
33	38	* @param string $password
	39	+ * @return void
34	40	*/
35	41	public function specifyPassword($password);
36	42
37	43	/**
38	44	* @param string $localeCode
	45	+ * @return void
39	46	*/
40	47	public function specifyLocale($localeCode);
41	48	}

		@@ -17,71 +17,95 @@
		block discarded – undo
17	17
18	18	interface CreatePageInterface extends BaseCreatePageInterface
19	19	{
	20	+ /**
	21	+ * @return void
	22	+ */
20	23	public function enable();
21	24
	25	+ /**
	26	+ * @return void
	27	+ */
22	28	public function disable();
23	29
24	30	/**
25	31	* @param string $name
	32	+ * @return void
26	33	*/
27	34	public function nameIt($name);
28	35
29	36	/**
30	37	* @param string $code
	38	+ * @return void
31	39	*/
32	40	public function specifyCode($code);
33	41
34	42	/**
35	43	* @param string $description
	44	+ * @return void
36	45	*/
37	46	public function describeItAs($description);
38	47
39	48	/**
40	49	* @param string $hostname
	50	+ * @return void
41	51	*/
42	52	public function setHostname($hostname);
43	53
44	54	/**
45	55	* @param string $contactEmail
	56	+ * @return void
46	57	*/
47	58	public function setContactEmail($contactEmail);
48	59
49	60	/**
50	61	* @param string $color
	62	+ * @return void
51	63	*/
52	64	public function defineColor($color);
53	65
54	66	/**
55	67	* @param string $language
	68	+ * @return void
56	69	*/
57	70	public function chooseLocale($language);
58	71
59	72	/**
60	73	* @param string $currencyCode
	74	+ * @return void
61	75	*/
62	76	public function chooseCurrency($currencyCode);
63	77
64	78	/**
65	79	* @param string $taxZone
	80	+ * @return void
66	81	*/
67	82	public function chooseDefaultTaxZone($taxZone);
68	83
69	84	/**
70	85	* @param string $locale
	86	+ * @return void
71	87	*/
72	88	public function chooseDefaultLocale($locale);
73	89
74	90	/**
75	91	* @param string $currency
	92	+ * @return void
76	93	*/
77	94	public function chooseBaseCurrency($currency);
78	95
79	96	/**
80	97	* @param string $taxCalculationStrategy
	98	+ * @return void
81	99	*/
82	100	public function chooseTaxCalculationStrategy($taxCalculationStrategy);
83	101
	102	+ /**
	103	+ * @return void
	104	+ */
84	105	public function allowToSkipShippingStep();
85	106
	107	+ /**
	108	+ * @return void
	109	+ */
86	110	public function allowToSkipPaymentStep();
87	111	}

		@@ -18,17 +18,25 @@ discard block
		block discarded – undo
18	18
19	19	interface UpdatePageInterface extends BaseUpdatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
22	25
	26	+ /**
	27	+ * @return void
	28	+ */
23	29	public function disable();
24	30
25	31	/**
26	32	* @param string $themeName
	33	+ * @return void
27	34	*/
28	35	public function setTheme($themeName);
29	36
30	37	/**
31	38	* @throws ElementNotFoundException
	39	+ * @return void
32	40	*/
33	41	public function unsetTheme();
34	42
		@@ -39,6 +47,7 @@ discard block
		block discarded – undo
39	47
40	48	/**
41	49	* @param string $language
	50	+ * @return void
42	51	*/
43	52	public function chooseLocale($language);
44	53
		@@ -51,6 +60,7 @@ discard block
		block discarded – undo
51	60
52	61	/**
53	62	* @param string $currencyCode
	63	+ * @return void
54	64	*/
55	65	public function chooseCurrency($currencyCode);
56	66
		@@ -63,11 +73,13 @@ discard block
		block discarded – undo
63	73
64	74	/**
65	75	* @param string $taxZone
	76	+ * @return void
66	77	*/
67	78	public function chooseDefaultTaxZone($taxZone);
68	79
69	80	/**
70	81	* @param string $taxCalculationStrategy
	82	+ * @return void
71	83	*/
72	84	public function chooseTaxCalculationStrategy($taxCalculationStrategy);
73	85

		@@ -17,8 +17,14 @@ discard block
		block discarded – undo
17	17
18	18	interface UpdatePageInterface extends BaseUpdatePageInterface
19	19	{
	20	+ /**
	21	+ * @return void
	22	+ */
20	23	public function enable();
21	24
	25	+ /**
	26	+ * @return void
	27	+ */
22	28	public function disable();
23	29
24	30	/**
		@@ -44,28 +50,36 @@ discard block
		block discarded – undo
44	50	* @param string $name
45	51	* @param string $code
46	52	* @param string\|null $abbreviation
	53	+ * @return void
47	54	*/
48	55	public function addProvince($name, $code, $abbreviation = null);
49	56
50	57	/**
51	58	* @param string $provinceName
	59	+ * @return void
52	60	*/
53	61	public function removeProvince($provinceName);
54	62
	63	+ /**
	64	+ * @return void
	65	+ */
55	66	public function clickAddProvinceButton();
56	67
57	68	/**
58	69	* @param string $provinceName
	70	+ * @return void
59	71	*/
60	72	public function nameProvince($provinceName);
61	73
62	74	/**
63	75	* @param string $provinceName
	76	+ * @return void
64	77	*/
65	78	public function removeProvinceName($provinceName);
66	79
67	80	/**
68	81	* @param string $provinceCode
	82	+ * @return void
69	83	*/
70	84	public function specifyProvinceCode($provinceCode);
71	85	}

pamil / Sylius

Push — 1.3 ( af1b9f...c8d8d9 )

Status

Category

Doc Comments +9 added lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Doc Comments +1 added lines patch added patch discarded remove patch

Doc Comments +7 added lines patch added patch discarded remove patch

Doc Comments +24 added lines patch added patch discarded remove patch

Doc Comments +12 added lines patch added patch discarded remove patch

Doc Comments +14 added lines patch added patch discarded remove patch

Doc Comments +7 added lines patch added patch discarded remove patch