PerUnitRateCalculator::calculate() - Code Metrics - Inspection of "Merge pull request #6901 from lchrusciel/rebased-c..." - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cfaf77...b5ed7c )

by Kamil

created 2016-11-28 19:25 UTC

PerUnitRateCalculator::calculate() A

↳ Parent: PerUnitRateCalculator

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	2

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sylius\Component\Core\Shipping\Calculator;

use Sylius\Component\Core\Model\ShipmentInterface;
use Sylius\Component\Shipping\Calculator\CalculatorInterface;
use Sylius\Component\Shipping\Model\ShipmentInterface as BaseShipmentInterface;
use Webmozart\Assert\Assert;

/**
 * @author Grzegorz Sadowski <[email protected]>
 */
final class PerUnitRateCalculator implements CalculatorInterface
{
    /**
     * {@inheritdoc}
     */
    public function calculate(BaseShipmentInterface $subject, array $configuration)
    {
        Assert::isInstanceOf($subject, ShipmentInterface::class);

        $channelCode = $subject->getOrder()->getChannel()->getCode();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return (int) ($configuration[$channelCode]['amount'] * $subject->getShippingUnitCount());
    }

    /**
     * {@inheritdoc}
     */
    public function getType()
    {
        return 'per_unit_rate';
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sylius\Component\Core\Shipping\Calculator;
13
14			use Sylius\Component\Core\Model\ShipmentInterface;
15			use Sylius\Component\Shipping\Calculator\CalculatorInterface;
16			use Sylius\Component\Shipping\Model\ShipmentInterface as BaseShipmentInterface;
17			use Webmozart\Assert\Assert;
18
19			/**
20			* @author Grzegorz Sadowski <[email protected]>
21			*/
22			final class PerUnitRateCalculator implements CalculatorInterface
23			{
24			/**
25			* {@inheritdoc}
26			*/
27			public function calculate(BaseShipmentInterface $subject, array $configuration)
28			{
29			Assert::isInstanceOf($subject, ShipmentInterface::class);
30
31			$channelCode = $subject->getOrder()->getChannel()->getCode();
			0 ignored issues – show Bug introduced 2016-11-28 20:12 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Sylius\Component\Shipping\Model\ShipmentInterface` as the method `getOrder()` does only exist in the following implementations of said interface: `Sylius\Component\Core\Model\Shipment`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
32
33			return (int) ($configuration[$channelCode]['amount'] * $subject->getShippingUnitCount());
34			}
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function getType()
40			{
41			return 'per_unit_rate';
42			}
43			}
44

pamil / Sylius

Push — master ( cfaf77...b5ed7c )

PerUnitRateCalculator::calculate() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like