RequestListener::onKernelRequest() - Code Metrics - Inspection of "Improve tests organisation in ThemeBundle" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — tests-organisation ( e0cc56...d1374b )

by Kamil

created 2017-03-06 19:00 UTC

RequestListener::onKernelRequest() A

↳ Parent: RequestListener

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sylius\Bundle\ThemeBundle\Tests\Functional\TestBundle\Listener;

use Sylius\Bundle\ThemeBundle\Context\SettableThemeContext;
use Sylius\Bundle\ThemeBundle\Context\ThemeContextInterface;
use Sylius\Bundle\ThemeBundle\Repository\ThemeRepositoryInterface;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;

/**
 * @author Kamil Kokot <[email protected]>
 */
final class RequestListener
{
    /**
     * @var ThemeRepositoryInterface
     */
    private $themeRepository;

    /**
     * @var ThemeContextInterface
     */
    private $themeContext;

    /**
     * @param ThemeRepositoryInterface $themeRepository
     * @param SettableThemeContext $themeContext
     */
    public function __construct(ThemeRepositoryInterface $themeRepository, SettableThemeContext $themeContext)
    {
        $this->themeRepository = $themeRepository;
        $this->themeContext = $themeContext;
    }

    /**
     * @param GetResponseEvent $event
     */
    public function onKernelRequest(GetResponseEvent $event)
    {
        if (HttpKernelInterface::MASTER_REQUEST !== $event->getRequestType()) {
            // don't do anything if it's not the master request
            return;
        }

        $this->themeContext->setTheme($this->themeRepository->findOneByName('sylius/first-test-theme'));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Sylius\Bundle\ThemeBundle\Tests\Functional\TestBundle\Listener;
13
14			use Sylius\Bundle\ThemeBundle\Context\SettableThemeContext;
15			use Sylius\Bundle\ThemeBundle\Context\ThemeContextInterface;
16			use Sylius\Bundle\ThemeBundle\Repository\ThemeRepositoryInterface;
17			use Symfony\Component\HttpKernel\Event\GetResponseEvent;
18			use Symfony\Component\HttpKernel\HttpKernelInterface;
19
20			/**
21			* @author Kamil Kokot <[email protected]>
22			*/
23			final class RequestListener
24			{
25			/**
26			* @var ThemeRepositoryInterface
27			*/
28			private $themeRepository;
29
30			/**
31			* @var ThemeContextInterface
32			*/
33			private $themeContext;
34
35			/**
36			* @param ThemeRepositoryInterface $themeRepository
37			* @param SettableThemeContext $themeContext
38			*/
39			public function __construct(ThemeRepositoryInterface $themeRepository, SettableThemeContext $themeContext)
40			{
41			$this->themeRepository = $themeRepository;
42			$this->themeContext = $themeContext;
43			}
44
45			/**
46			* @param GetResponseEvent $event
47			*/
48			public function onKernelRequest(GetResponseEvent $event)
49			{
50			if (HttpKernelInterface::MASTER_REQUEST !== $event->getRequestType()) {
51			// don't do anything if it's not the master request
52			return;
53			}
54
55			$this->themeContext->setTheme($this->themeRepository->findOneByName('sylius/first-test-theme'));
			0 ignored issues – show Bug introduced 2016-06-24 14:31 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Sylius\Bundle\ThemeBundl...t\ThemeContextInterface` as the method `setTheme()` does only exist in the following implementations of said interface: `Sylius\Bundle\ThemeBundl...xt\SettableThemeContext`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
56			}
57			}
58

pamil / Sylius

Push — tests-organisation ( e0cc56...d1374b )

RequestListener::onKernelRequest() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like