Inspection of "[Product] Add missing methods to ProductInterface" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — product/missing-methods ( 0cfbf7 )

by Kamil

created 2016-10-24 09:57 UTC

Status

Doc Comments +7 added lines patch added patch discarded remove patch

@@ -18,6 +18,13 @@
 block discarded – undo
  */
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
+
+    /**
+     * @return void
+     */
     public function disable();
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Order/ShowPageInterface.php 1 patch

Doc Comments +10 added lines patch added patch discarded remove patch

		@@ -22,6 +22,7 @@ discard block
		block discarded – undo
22	22	{
23	23	/**
24	24	* @param string $customerName
	25	+ * @return boolean
25	26	*/
26	27	public function hasCustomer($customerName);
27	28
		@@ -56,6 +57,7 @@ discard block
		block discarded – undo
56	57
57	58	/**
58	59	* @param string $code
	60	+ * @return void
59	61	*/
60	62	public function specifyTrackingCode($code);
61	63
		@@ -68,6 +70,7 @@ discard block
		block discarded – undo
68	70
69	71	/**
70	72	* @param OrderInterface $order
	73	+ * @return void
71	74	*/
72	75	public function shipOrder(OrderInterface $order);
73	76
		@@ -87,6 +90,7 @@ discard block
		block discarded – undo
87	90
88	91	/**
89	92	* @param OrderInterface $order
	93	+ * @return void
90	94	*/
91	95	public function completeOrderLastPayment(OrderInterface $order);
92	96
		@@ -207,7 +211,13 @@ discard block
		block discarded – undo
207	211	*/
208	212	public function getOrderState();
209	213
	214	+ /**
	215	+ * @return void
	216	+ */
210	217	public function cancelOrder();
211	218
	219	+ /**
	220	+ * @return void
	221	+ */
212	222	public function deleteOrder();
213	223	}

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/PaymentMethod/UpdatePageInterface.php 1 patch

Doc Comments +9 added lines patch added patch discarded remove patch

@@ -18,11 +18,19 @@  discard block
 block discarded – undo
  */
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
+
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $gateway
+     * @return void
      */
     public function chooseGateway($gateway);
 
@@ -39,6 +47,7 @@  discard block
 block discarded – undo
     /**
      * @param string $name
      * @param string $languageCode
+     * @return void
      */
     public function nameIt($name, $languageCode);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/ProductOption/CreatePageInterface.php 1 patch

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -20,23 +20,27 @@
 block discarded – undo
 {
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $name
      * @param string $language
+     * @return void
      */
     public function nameItIn($name, $language);
 
     /**
      * @param string $code
      * @param string $value
+     * @return void
      */
     public function addOptionValue($code, $value);
 
     /**
      * @param string $message
+     * @return boolean
      */
     public function checkValidationMessageForOptionValues($message);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/ProductOption/UpdatePageInterface.php 1 patch

Doc Comments +4 added lines patch added patch discarded remove patch

@@ -26,22 +26,26 @@
 block discarded – undo
     /**
      * @param string $name
      * @param string $languageCode
+     * @return void
      */
     public function nameItIn($name, $languageCode);
 
     /**
      * @param string $optionValue
+     * @return boolean
      */
     public function isThereOptionValue($optionValue);
 
     /**
      * @param string $code
      * @param string $value
+     * @return void
      */
     public function addOptionValue($code, $value);
 
     /**
      * @param string $optionValue
+     * @return void
      */
     public function removeOptionValue($optionValue);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Promotion/CreatePageInterface.php 1 patch

Doc Comments +18 added lines patch added patch discarded remove patch

@@ -21,16 +21,19 @@  discard block
 block discarded – undo
 {
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
     /**
      * @param string $ruleName
+     * @return void
      */
     public function addRule($ruleName);
 
@@ -38,17 +41,20 @@  discard block
 block discarded – undo
      * @param string $option
      * @param string $value
      * @param bool $multiple
+     * @return void
      */
     public function selectRuleOption($option, $value, $multiple = false);
 
     /**
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillRuleOption($option, $value);
 
     /**
      * @param string $actionName
+     * @return void
      */
     public function addAction($actionName);
 
@@ -56,36 +62,48 @@  discard block
 block discarded – undo
      * @param string $option
      * @param string $value
      * @param bool $multiple
+     * @return void
      */
     public function selectActionOption($option, $value, $multiple = false);
 
     /**
      * @param string $option
      * @param string $value
+     * @return void
      */
     public function fillActionOption($option, $value);
 
     /**
      * @param string $limit
+     * @return void
      */
     public function fillUsageLimit($limit);
 
+    /**
+     * @return void
+     */
     public function makeExclusive();
 
+    /**
+     * @return void
+     */
     public function checkCouponBased();
 
     /**
      * @param string $name
+     * @return void
      */
     public function checkChannel($name);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setStartsAt(\DateTime $dateTime);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setEndsAt(\DateTime $dateTime);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Promotion/UpdatePageInterface.php 1 patch

Doc Comments +13 added lines patch added patch discarded remove patch

@@ -21,6 +21,7 @@  discard block
 block discarded – undo
 {
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
@@ -38,35 +39,47 @@  discard block
 block discarded – undo
 
     /**
      * @param string $limit
+     * @return void
      */
     public function fillUsageLimit($limit);
 
+    /**
+     * @return void
+     */
     public function makeExclusive();
 
+    /**
+     * @return void
+     */
     public function checkCouponBased();
 
     /**
      * @param string $name
+     * @return void
      */
     public function checkChannel($name);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setStartsAt(\DateTime $dateTime);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setEndsAt(\DateTime $dateTime);
 
     /**
      * {@inheritdoc}
+     * @return boolean
      */
     public function hasStartsAt(\DateTime $dateTime);
 
     /**
      * {@inheritdoc}
+     * @return boolean
      */
     public function hasEndsAt(\DateTime $dateTime);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/PromotionCoupon/GeneratePageInterface.php 1 patch

Doc Comments +7 added lines patch added patch discarded remove patch

@@ -39,25 +39,32 @@
 block discarded – undo
      */
     public function checkGenerationValidation($message);
 
+    /**
+     * @return void
+     */
     public function generate();
 
     /**
      * @param int $amount
+     * @return void
      */
     public function specifyAmount($amount);
 
     /**
      * @param int $codeLength
+     * @return void
      */
     public function specifyCodeLength($codeLength);
 
     /**
      * @param \DateTime $date
+     * @return void
      */
     public function setExpiresAt(\DateTime $date);
 
     /**
      * @param int $limit
+     * @return void
      */
     public function setUsageLimit($limit);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/ShippingMethod/UpdatePageInterface.php 1 patch

Doc Comments +6 added lines patch added patch discarded remove patch

@@ -23,7 +23,13 @@
 block discarded – undo
      */
     public function isCodeDisabled();
 
+    /**
+     * @return void
+     */
     public function enable();
 
+    /**
+     * @return void
+     */
     public function disable();
 }

Please login to merge, or discard this patch.

		@@ -18,6 +18,13 @@
		block discarded – undo
18	18	*/
19	19	interface UpdatePageInterface extends BaseUpdatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
	25	+
	26	+ /**
	27	+ * @return void
	28	+ */
22	29	public function disable();
23	30	}

		@@ -18,11 +18,19 @@ discard block
		block discarded – undo
18	18	*/
19	19	interface UpdatePageInterface extends BaseUpdatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
	25	+
	26	+ /**
	27	+ * @return void
	28	+ */
22	29	public function disable();
23	30
24	31	/**
25	32	* @param string $gateway
	33	+ * @return void
26	34	*/
27	35	public function chooseGateway($gateway);
28	36
		@@ -39,6 +47,7 @@ discard block
		block discarded – undo
39	47	/**
40	48	* @param string $name
41	49	* @param string $languageCode
	50	+ * @return void
42	51	*/
43	52	public function nameIt($name, $languageCode);
44	53	}

		@@ -20,23 +20,27 @@
		block discarded – undo
20	20	{
21	21	/**
22	22	* @param string $code
	23	+ * @return void
23	24	*/
24	25	public function specifyCode($code);
25	26
26	27	/**
27	28	* @param string $name
28	29	* @param string $language
	30	+ * @return void
29	31	*/
30	32	public function nameItIn($name, $language);
31	33
32	34	/**
33	35	* @param string $code
34	36	* @param string $value
	37	+ * @return void
35	38	*/
36	39	public function addOptionValue($code, $value);
37	40
38	41	/**
39	42	* @param string $message
	43	+ * @return boolean
40	44	*/
41	45	public function checkValidationMessageForOptionValues($message);
42	46	}

		@@ -26,22 +26,26 @@
		block discarded – undo
26	26	/**
27	27	* @param string $name
28	28	* @param string $languageCode
	29	+ * @return void
29	30	*/
30	31	public function nameItIn($name, $languageCode);
31	32
32	33	/**
33	34	* @param string $optionValue
	35	+ * @return boolean
34	36	*/
35	37	public function isThereOptionValue($optionValue);
36	38
37	39	/**
38	40	* @param string $code
39	41	* @param string $value
	42	+ * @return void
40	43	*/
41	44	public function addOptionValue($code, $value);
42	45
43	46	/**
44	47	* @param string $optionValue
	48	+ * @return void
45	49	*/
46	50	public function removeOptionValue($optionValue);
47	51	}

		@@ -21,16 +21,19 @@ discard block
		block discarded – undo
21	21	{
22	22	/**
23	23	* @param string $code
	24	+ * @return void
24	25	*/
25	26	public function specifyCode($code);
26	27
27	28	/**
28	29	* @param string $name
	30	+ * @return void
29	31	*/
30	32	public function nameIt($name);
31	33
32	34	/**
33	35	* @param string $ruleName
	36	+ * @return void
34	37	*/
35	38	public function addRule($ruleName);
36	39
		@@ -38,17 +41,20 @@ discard block
		block discarded – undo
38	41	* @param string $option
39	42	* @param string $value
40	43	* @param bool $multiple
	44	+ * @return void
41	45	*/
42	46	public function selectRuleOption($option, $value, $multiple = false);
43	47
44	48	/**
45	49	* @param string $option
46	50	* @param string $value
	51	+ * @return void
47	52	*/
48	53	public function fillRuleOption($option, $value);
49	54
50	55	/**
51	56	* @param string $actionName
	57	+ * @return void
52	58	*/
53	59	public function addAction($actionName);
54	60
		@@ -56,36 +62,48 @@ discard block
		block discarded – undo
56	62	* @param string $option
57	63	* @param string $value
58	64	* @param bool $multiple
	65	+ * @return void
59	66	*/
60	67	public function selectActionOption($option, $value, $multiple = false);
61	68
62	69	/**
63	70	* @param string $option
64	71	* @param string $value
	72	+ * @return void
65	73	*/
66	74	public function fillActionOption($option, $value);
67	75
68	76	/**
69	77	* @param string $limit
	78	+ * @return void
70	79	*/
71	80	public function fillUsageLimit($limit);
72	81
	82	+ /**
	83	+ * @return void
	84	+ */
73	85	public function makeExclusive();
74	86
	87	+ /**
	88	+ * @return void
	89	+ */
75	90	public function checkCouponBased();
76	91
77	92	/**
78	93	* @param string $name
	94	+ * @return void
79	95	*/
80	96	public function checkChannel($name);
81	97
82	98	/**
83	99	* @param \DateTime $dateTime
	100	+ * @return void
84	101	*/
85	102	public function setStartsAt(\DateTime $dateTime);
86	103
87	104	/**
88	105	* @param \DateTime $dateTime
	106	+ * @return void
89	107	*/
90	108	public function setEndsAt(\DateTime $dateTime);
91	109	}

		@@ -21,6 +21,7 @@ discard block
		block discarded – undo
21	21	{
22	22	/**
23	23	* @param string $name
	24	+ * @return void
24	25	*/
25	26	public function nameIt($name);
26	27
		@@ -38,35 +39,47 @@ discard block
		block discarded – undo
38	39
39	40	/**
40	41	* @param string $limit
	42	+ * @return void
41	43	*/
42	44	public function fillUsageLimit($limit);
43	45
	46	+ /**
	47	+ * @return void
	48	+ */
44	49	public function makeExclusive();
45	50
	51	+ /**
	52	+ * @return void
	53	+ */
46	54	public function checkCouponBased();
47	55
48	56	/**
49	57	* @param string $name
	58	+ * @return void
50	59	*/
51	60	public function checkChannel($name);
52	61
53	62	/**
54	63	* @param \DateTime $dateTime
	64	+ * @return void
55	65	*/
56	66	public function setStartsAt(\DateTime $dateTime);
57	67
58	68	/**
59	69	* @param \DateTime $dateTime
	70	+ * @return void
60	71	*/
61	72	public function setEndsAt(\DateTime $dateTime);
62	73
63	74	/**
64	75	* {@inheritdoc}
	76	+ * @return boolean
65	77	*/
66	78	public function hasStartsAt(\DateTime $dateTime);
67	79
68	80	/**
69	81	* {@inheritdoc}
	82	+ * @return boolean
70	83	*/
71	84	public function hasEndsAt(\DateTime $dateTime);
72	85	}

		@@ -39,25 +39,32 @@
		block discarded – undo
39	39	*/
40	40	public function checkGenerationValidation($message);
41	41
	42	+ /**
	43	+ * @return void
	44	+ */
42	45	public function generate();
43	46
44	47	/**
45	48	* @param int $amount
	49	+ * @return void
46	50	*/
47	51	public function specifyAmount($amount);
48	52
49	53	/**
50	54	* @param int $codeLength
	55	+ * @return void
51	56	*/
52	57	public function specifyCodeLength($codeLength);
53	58
54	59	/**
55	60	* @param \DateTime $date
	61	+ * @return void
56	62	*/
57	63	public function setExpiresAt(\DateTime $date);
58	64
59	65	/**
60	66	* @param int $limit
	67	+ * @return void
61	68	*/
62	69	public function setUsageLimit($limit);
63	70	}

		@@ -23,7 +23,13 @@
		block discarded – undo
23	23	*/
24	24	public function isCodeDisabled();
25	25
	26	+ /**
	27	+ * @return void
	28	+ */
26	29	public function enable();
27	30
	31	+ /**
	32	+ * @return void
	33	+ */
28	34	public function disable();
29	35	}

pamil / Sylius

Push — product/missing-methods ( 0cfbf7 )

Status

Category

Doc Comments +7 added lines patch added patch discarded remove patch

Doc Comments +10 added lines patch added patch discarded remove patch

Doc Comments +9 added lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Doc Comments +4 added lines patch added patch discarded remove patch

Doc Comments +18 added lines patch added patch discarded remove patch

Doc Comments +13 added lines patch added patch discarded remove patch

Doc Comments +7 added lines patch added patch discarded remove patch

Doc Comments +6 added lines patch added patch discarded remove patch