StringFilter::apply() - Code Metrics - Inspection of "Add missing license comments" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.0-coding-standard-2-header ( 51fb9c...ba11a9 )

by Kamil

created 2017-09-26 11:38 UTC

StringFilter::apply() C

↳ Parent: StringFilter

Complexity

Conditions	11
Paths	96

Size

Total Lines	40
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	40
c	0
b	0
f	0
rs	5.2653
cc	11
eloc	21
nc	96
nop	4

How to fix Complexity

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Sylius\Component\Grid\Filter;

use Sylius\Component\Grid\Data\DataSourceInterface;
use Sylius\Component\Grid\Data\ExpressionBuilderInterface;
use Sylius\Component\Grid\Filtering\FilterInterface;

/**
 * @author Paweł Jędrzejewski <[email protected]>
 */
final class StringFilter implements FilterInterface
{
    public const NAME = 'string';

    public const TYPE_EQUAL = 'equal';
    public const TYPE_NOT_EQUAL = 'not_equal';
    public const TYPE_EMPTY = 'empty';
    public const TYPE_NOT_EMPTY = 'not_empty';
    public const TYPE_CONTAINS = 'contains';
    public const TYPE_NOT_CONTAINS = 'not_contains';
    public const TYPE_STARTS_WITH = 'starts_with';
    public const TYPE_ENDS_WITH = 'ends_with';
    public const TYPE_IN = 'in';
    public const TYPE_NOT_IN = 'not_in';

    /**
     * {@inheritdoc}
     */
    public function apply(DataSourceInterface $dataSource, string $name, $data, array $options): void
    {
        $expressionBuilder = $dataSource->getExpressionBuilder();

        if (is_array($data) && !isset($data['type'])) {
            $data['type'] = $options['type'] ?? self::TYPE_CONTAINS;
        }

        if (!is_array($data)) {
            $data = ['type' => self::TYPE_CONTAINS, 'value' => $data];
        }

        $fields = array_key_exists('fields', $options) ? $options['fields'] : [$name];

        $type = $data['type'];
        $value = array_key_exists('value', $data) ? $data['value'] : null;

        if (!in_array($type, [self::TYPE_NOT_EMPTY, self::TYPE_EMPTY], true) && '' === trim($value)) {
            return;
        }

        if (1 === count($fields)) {
            $dataSource->restrict($this->getExpression($expressionBuilder, $type, current($fields), $value));

            return;
        }

        $expressions = [];
        foreach ($fields as $field) {
            $expressions[] = $this->getExpression($expressionBuilder, $type, $field, $value);
        }

        if (self::TYPE_NOT_EQUAL === $type) {
            $dataSource->restrict($expressionBuilder->andX(...$expressions));

            return;
        }

        $dataSource->restrict($expressionBuilder->orX(...$expressions));
    }

    /**
     * @param ExpressionBuilderInterface $expressionBuilder
     * @param string $type
     * @param string $field
     * @param mixed $value
     *
     * @return mixed
     *
     * @throws \InvalidArgumentException
     */
    private function getExpression(
        ExpressionBuilderInterface $expressionBuilder,
        string $type,
        string $field,
        $value
    ) {
        switch ($type) {
            case self::TYPE_EQUAL:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return $expressionBuilder->equals($field, $value);
            case self::TYPE_NOT_EQUAL:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return $expressionBuilder->notEquals($field, $value);
            case self::TYPE_EMPTY:
                return $expressionBuilder->isNull($field);
            case self::TYPE_NOT_EMPTY:
                return $expressionBuilder->isNotNull($field);
            case self::TYPE_CONTAINS:
                return $expressionBuilder->like($field, '%' . $value . '%');
            case self::TYPE_NOT_CONTAINS:
                return $expressionBuilder->notLike($field, '%' . $value . '%');
            case self::TYPE_STARTS_WITH:
                return $expressionBuilder->like($field, $value . '%');
            case self::TYPE_ENDS_WITH:
                return $expressionBuilder->like($field, '%' . $value);
            case self::TYPE_IN:
                return $expressionBuilder->in($field, array_map('trim', explode(',', $value)));
            case self::TYPE_NOT_IN:
                return $expressionBuilder->notIn($field, array_map('trim', explode(',', $value)));
            default:
                throw new \InvalidArgumentException(sprintf('Could not get an expression for type "%s"!', $type));
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Sylius\Component\Grid\Filter;
15
16			use Sylius\Component\Grid\Data\DataSourceInterface;
17			use Sylius\Component\Grid\Data\ExpressionBuilderInterface;
18			use Sylius\Component\Grid\Filtering\FilterInterface;
19
20			/**
21			* @author Paweł Jędrzejewski <[email protected]>
22			*/
23			final class StringFilter implements FilterInterface
24			{
25			public const NAME = 'string';
26
27			public const TYPE_EQUAL = 'equal';
28			public const TYPE_NOT_EQUAL = 'not_equal';
29			public const TYPE_EMPTY = 'empty';
30			public const TYPE_NOT_EMPTY = 'not_empty';
31			public const TYPE_CONTAINS = 'contains';
32			public const TYPE_NOT_CONTAINS = 'not_contains';
33			public const TYPE_STARTS_WITH = 'starts_with';
34			public const TYPE_ENDS_WITH = 'ends_with';
35			public const TYPE_IN = 'in';
36			public const TYPE_NOT_IN = 'not_in';
37
38			/**
39			* {@inheritdoc}
40			*/
41			public function apply(DataSourceInterface $dataSource, string $name, $data, array $options): void
42			{
43			$expressionBuilder = $dataSource->getExpressionBuilder();
44
45			if (is_array($data) && !isset($data['type'])) {
46			$data['type'] = $options['type'] ?? self::TYPE_CONTAINS;
47			}
48
49			if (!is_array($data)) {
50			$data = ['type' => self::TYPE_CONTAINS, 'value' => $data];
51			}
52
53			$fields = array_key_exists('fields', $options) ? $options['fields'] : [$name];
54
55			$type = $data['type'];
56			$value = array_key_exists('value', $data) ? $data['value'] : null;
57
58			if (!in_array($type, [self::TYPE_NOT_EMPTY, self::TYPE_EMPTY], true) && '' === trim($value)) {
59			return;
60			}
61
62			if (1 === count($fields)) {
63			$dataSource->restrict($this->getExpression($expressionBuilder, $type, current($fields), $value));
64
65			return;
66			}
67
68			$expressions = [];
69			foreach ($fields as $field) {
70			$expressions[] = $this->getExpression($expressionBuilder, $type, $field, $value);
71			}
72
73			if (self::TYPE_NOT_EQUAL === $type) {
74			$dataSource->restrict($expressionBuilder->andX(...$expressions));
75
76			return;
77			}
78
79			$dataSource->restrict($expressionBuilder->orX(...$expressions));
80			}
81
82			/**
83			* @param ExpressionBuilderInterface $expressionBuilder
84			* @param string $type
85			* @param string $field
86			* @param mixed $value
87			*
88			* @return mixed
89			*
90			* @throws \InvalidArgumentException
91			*/
92			private function getExpression(
93			ExpressionBuilderInterface $expressionBuilder,
94			string $type,
95			string $field,
96			$value
97			) {
98			switch ($type) {
99			case self::TYPE_EQUAL:
			0 ignored issues – show Coding Style introduced 2017-09-22 14:47 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
100			return $expressionBuilder->equals($field, $value);
101			case self::TYPE_NOT_EQUAL:
			0 ignored issues – show Coding Style introduced 2017-09-22 14:47 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
102			return $expressionBuilder->notEquals($field, $value);
103			case self::TYPE_EMPTY:
104			return $expressionBuilder->isNull($field);
105			case self::TYPE_NOT_EMPTY:
106			return $expressionBuilder->isNotNull($field);
107			case self::TYPE_CONTAINS:
108			return $expressionBuilder->like($field, '%' . $value . '%');
109			case self::TYPE_NOT_CONTAINS:
110			return $expressionBuilder->notLike($field, '%' . $value . '%');
111			case self::TYPE_STARTS_WITH:
112			return $expressionBuilder->like($field, $value . '%');
113			case self::TYPE_ENDS_WITH:
114			return $expressionBuilder->like($field, '%' . $value);
115			case self::TYPE_IN:
116			return $expressionBuilder->in($field, array_map('trim', explode(',', $value)));
117			case self::TYPE_NOT_IN:
118			return $expressionBuilder->notIn($field, array_map('trim', explode(',', $value)));
119			default:
120			throw new \InvalidArgumentException(sprintf('Could not get an expression for type "%s"!', $type));
121			}
122			}
123			}
124

pamil / Sylius

Push — 1.0-coding-standard-2-header ( 51fb9c...ba11a9 )

StringFilter::apply() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like