pamil / Sylius

src/Sylius/Bundle/AdminApiBundle/DependencyInjection/SyliusAdminApiExtension.php

Unused Use Statements -3 removed lines

@@ -11,15 +11,12 @@
 
 namespace Sylius\Bundle\AdminApiBundle\DependencyInjection;
 
-use Sylius\Bundle\AdminApiBundle\Controller\TokenController;
 use Sylius\Bundle\ResourceBundle\DependencyInjection\Extension\AbstractResourceExtension;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
 use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
-use Symfony\Component\DependencyInjection\Reference;
 
 /**
  * @author Paweł Jędrzejewski <pawel@sylius.org>

Spacing +2 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Bundle\AdminApiBundle\DependencyInjection;
 
@@ -34,7 +34,7 @@ 
     public function load(array $config, ContainerBuilder $container)
     {
         $config = $this->processConfiguration($this->getConfiguration([], $container), $config);
-        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
 
         $this->registerResources('sylius', $config['driver'], $config['resources'], $container);
 

src/Sylius/Bundle/AdminApiBundle/Fixture/Factory/ApiAccessTokenExampleFactory.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 namespace Sylius\Bundle\AdminApiBundle\Fixture\Factory;
 
-use FOS\OAuthServerBundle\Model\ClientManagerInterface;
 use Sylius\Bundle\AdminApiBundle\Model\AccessTokenInterface;
 use Sylius\Bundle\AdminApiBundle\Model\ClientInterface;
 use Sylius\Bundle\AdminApiBundle\Model\UserInterface;

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Bundle\AdminApiBundle\Fixture\Factory;
 

src/Sylius/Bundle/AdminApiBundle/Command/CreateClientCommand.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
             ->setHelp(<<<EOT
 The <info>%command.name%</info>command creates a new client.
 <info>php %command.full_name% [--redirect-uri=...] [--grant-type=...] name</info>
-EOT
+eot
             );
     }
 

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Bundle\AdminApiBundle\Command;
 

src/Sylius/Behat/Context/Setup/PromotionContext.php

Doc Comments +4 added lines, -2 removed lines

@@ -352,6 +352,7 @@ 
 
     /**
      * @Given /^([^"]+) gives ("[^"]+%") discount on shipping to every order$/
+     * @param integer $discount
      */
     public function itGivesPercentageDiscountOnShippingToEveryOrder(PromotionInterface $promotion, $discount)
     {
@@ -675,6 +676,7 @@ 
 
     /**
      * @Given /^([^"]+) gives ("[^"]+%") discount on shipping to every order over ("(?:€|£|\$)[^"]+")$/
+     * @param integer $discount
      */
     public function itGivesDiscountOnShippingToEveryOrderOver(
         PromotionInterface $promotion,
@@ -697,7 +699,7 @@ 
     }
 
     /**
-     * @param array $taxonCodes
+     * @param string[] $taxonCodes
      *
      * @return array
      */
@@ -707,7 +709,7 @@ 
     }
 
     /**
-     * @param array $productCodes
+     * @param string[] $productCodes
      *
      * @return array
      */

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Context\Setup;
 

src/Sylius/Behat/Page/Admin/Promotion/UpdatePageInterface.php

Doc Comments +14 added lines

@@ -22,6 +22,7 @@ 
 
     /**
      * @param int|null $priority
+     * @return void
      */
     public function setPriority($priority);
 
@@ -32,6 +33,7 @@ 
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
@@ -49,35 +51,47 @@ 
 
     /**
      * @param string $limit
+     * @return void
      */
     public function fillUsageLimit($limit);
 
+    /**
+     * @return void
+     */
     public function makeExclusive();
 
+    /**
+     * @return void
+     */
     public function checkCouponBased();
 
     /**
      * @param string $name
+     * @return void
      */
     public function checkChannel($name);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setStartsAt(\DateTime $dateTime);
 
     /**
      * @param \DateTime $dateTime
+     * @return void
      */
     public function setEndsAt(\DateTime $dateTime);
 
     /**
      * {@inheritdoc}
+     * @return boolean
      */
     public function hasStartsAt(\DateTime $dateTime);
 
     /**
      * {@inheritdoc}
+     * @return boolean
      */
     public function hasEndsAt(\DateTime $dateTime);
 }

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Admin\Promotion;
 

tests/Controller/AdminUserApiTest.php

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -76,7 +76,7 @@ 
             "plainPassword": "youShallNotPass",
             "localeCode": "en_US"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/users/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -103,7 +103,7 @@ 
             "localeCode": "en_US",
             "enabled": "true"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/users/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -233,7 +233,7 @@ 
             "localeCode": "fr_FR",
             "enabled": "true"
         }
-EOT;
+eot;
 
         $this->client->request('PUT', $this->getAdminUserUrl($users['admin1']), [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -273,7 +273,7 @@ 
             "firstName": "John",
             "lastName": "Doe"
         }
-EOT;
+eot;
 
         $this->client->request('PATCH', $this->getAdminUserUrl($users['admin1']), [], [], static::$authorizedHeaderWithContentType, $data);
 

Spacing +2 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Tests\Controller;
 
@@ -342,7 +342,7 @@ 
         $this->client->request('DELETE', $this->getAdminUserUrl($user['admin']), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
-        $this->assertResponse($response, 'admin_user/deletion_fail_response',  Response::HTTP_UNPROCESSABLE_ENTITY);
+        $this->assertResponse($response, 'admin_user/deletion_fail_response', Response::HTTP_UNPROCESSABLE_ENTITY);
     }
 
     /**

tests/Controller/PromotionApiTest.php

Upper-Lower-Casing +9 added lines, -9 removed lines

@@ -230,7 +230,7 @@ 
             "code": "christmas-promotion",
             "name": "Christmas Promotion"
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -255,7 +255,7 @@ 
                 "MOB"
             ]
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -283,7 +283,7 @@ 
                 "time": "11:00"
             }
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -323,7 +323,7 @@ 
                 }
             ]
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -387,7 +387,7 @@ 
                 }
             ]
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -409,7 +409,7 @@ 
             "name": "Christmas Promotion",
             "couponBased": true
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -431,7 +431,7 @@ 
             "exclusive": true,
             "priority": 0
         }
-EOT;
+eot;
         $this->client->request('POST', '/api/v1/promotions/', [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
@@ -453,7 +453,7 @@ 
             "name": "Monday promotion",
             "priority": 0
         }
-EOT;
+eot;
         $this->client->request('PUT', $this->getPromotionUrl($promotion), [], [], static::$authorizedHeaderWithContentType, $data);
         $response = $this->client->getResponse();
 
@@ -479,7 +479,7 @@ 
         {
             "exclusive": true
         }
-EOT;
+eot;
         $this->client->request('PATCH', $this->getPromotionUrl($promotion), [], [], static::$authorizedHeaderWithContentType, $data);
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Tests\Controller;
 

src/Sylius/Behat/Page/Admin/Product/UpdateSimpleProductPage.php

Doc Comments +1 added lines

@@ -199,6 +199,7 @@
 
     /**
      * {@inheritdoc}
+     * @param string $name
      */
     protected function getElement($name, array $parameters = [])
     {

Spacing +4 added lines, -4 removed lines

@@ -9,7 +9,7 @@ 
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Admin\Product;
 
@@ -213,7 +213,7 @@ 
             $imageForm->fillField('Type', $type);
         }
 
-        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath.$path);
+        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath . $path);
     }
 
     /**
@@ -224,7 +224,7 @@ 
         $filesPath = $this->getParameter('files_path');
 
         $imageForm = $this->getImageElementByType($type);
-        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath.$path);
+        $imageForm->find('css', 'input[type="file"]')->attachFile($filesPath . $path);
     }
 
     /**
@@ -500,7 +500,7 @@ 
     private function getImageElementByType($type)
     {
         $images = $this->getElement('images');
-        $typeInput = $images->find('css', 'input[value="'.$type.'"]');
+        $typeInput = $images->find('css', 'input[value="' . $type . '"]');
 
         if (null === $typeInput) {
             return null;

src/Sylius/Behat/Page/Admin/Promotion/CreatePage.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 namespace Sylius\Behat\Page\Admin\Promotion;
 
-use Behat\Mink\Driver\Selenium2Driver;
 use Behat\Mink\Element\NodeElement;
 use Behat\Mink\Exception\ElementNotFoundException;
 use Sylius\Behat\Behaviour\NamesIt;

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Sylius\Behat\Page\Admin\Promotion;