Conditions | 1 |
Paths | 1 |
Total Lines | 79 |
Code Lines | 52 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
173 | private function addConfigurationSubMenu(ItemInterface $menu) |
||
174 | { |
||
175 | $configuration = $menu |
||
176 | ->addChild('configuration') |
||
177 | ->setLabel('sylius.menu.admin.main.configuration.header') |
||
178 | ; |
||
179 | |||
180 | $configuration |
||
181 | ->addChild('channels', ['route' => 'sylius_admin_channel_index']) |
||
182 | ->setLabel('sylius.menu.admin.main.configuration.channels') |
||
183 | ->setLabelAttribute('icon', 'random') |
||
184 | ; |
||
185 | |||
186 | $configuration |
||
187 | ->addChild('countries', ['route' => 'sylius_admin_country_index']) |
||
188 | ->setLabel('sylius.menu.admin.main.configuration.countries') |
||
189 | ->setLabelAttribute('icon', 'flag') |
||
190 | ; |
||
191 | |||
192 | $configuration |
||
193 | ->addChild('zones', ['route' => 'sylius_admin_zone_index']) |
||
194 | ->setLabel('sylius.menu.admin.main.configuration.zones') |
||
195 | ->setLabelAttribute('icon', 'world') |
||
196 | ; |
||
197 | |||
198 | $configuration |
||
199 | ->addChild('currencies', ['route' => 'sylius_admin_currency_index']) |
||
200 | ->setLabel('sylius.menu.admin.main.configuration.currencies') |
||
201 | ->setLabelAttribute('icon', 'dollar') |
||
202 | ; |
||
203 | |||
204 | $configuration |
||
205 | ->addChild('exchange_rates', ['route' => 'sylius_admin_exchange_rate_index']) |
||
206 | ->setLabel('sylius.menu.admin.main.configuration.exchange_rates') |
||
207 | ->setLabelAttribute('icon', 'sliders') |
||
208 | ; |
||
209 | |||
210 | $configuration |
||
211 | ->addChild('locales', ['route' => 'sylius_admin_locale_index']) |
||
212 | ->setLabel('sylius.menu.admin.main.configuration.locales') |
||
213 | ->setLabelAttribute('icon', 'translate') |
||
214 | ; |
||
215 | |||
216 | $configuration |
||
217 | ->addChild('payment_methods', ['route' => 'sylius_admin_payment_method_index']) |
||
218 | ->setLabel('sylius.menu.admin.main.configuration.payment_methods') |
||
219 | ->setLabelAttribute('icon', 'payment') |
||
220 | ; |
||
221 | |||
222 | $configuration |
||
223 | ->addChild('shipping_methods', ['route' => 'sylius_admin_shipping_method_index']) |
||
224 | ->setLabel('sylius.menu.admin.main.configuration.shipping_methods') |
||
225 | ->setLabelAttribute('icon', 'shipping') |
||
226 | ; |
||
227 | |||
228 | $configuration |
||
229 | ->addChild('shipping_categories', ['route' => 'sylius_admin_shipping_category_index']) |
||
230 | ->setLabel('sylius.menu.admin.main.configuration.shipping_categories') |
||
231 | ->setLabelAttribute('icon', 'list layout') |
||
232 | ; |
||
233 | |||
234 | $configuration |
||
235 | ->addChild('tax_categories', ['route' => 'sylius_admin_tax_category_index']) |
||
236 | ->setLabel('sylius.menu.admin.main.configuration.tax_categories') |
||
237 | ->setLabelAttribute('icon', 'tags') |
||
238 | ; |
||
239 | |||
240 | $configuration |
||
241 | ->addChild('tax_rates', ['route' => 'sylius_admin_tax_rate_index']) |
||
242 | ->setLabel('sylius.menu.admin.main.configuration.tax_rates') |
||
243 | ->setLabelAttribute('icon', 'money') |
||
244 | ; |
||
245 | |||
246 | $configuration |
||
247 | ->addChild('admin_users', ['route' => 'sylius_admin_admin_user_index']) |
||
248 | ->setLabel('sylius.menu.admin.main.configuration.admin_users') |
||
249 | ->setLabelAttribute('icon', 'lock') |
||
250 | ; |
||
251 | } |
||
252 | } |
||
253 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.