Completed
Push — symfony3-optionsresolver ( 415f0a...368e3f )
by Kamil
17:18
created
CoreBundle/Form/Type/Pricing/ChannelAndCurrencyBasedConfigurationType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
          */
57 57
         foreach ($this->channelRepository->findAll() as $channel) {
58 58
             foreach ($this->currencyRepository->findAll() as $currency) {
59
-                $builder->add($channel->getCode().$options['delimiter'].$currency->getCode(), 'sylius_money', [
59
+                $builder->add($channel->getCode() . $options['delimiter'] . $currency->getCode(), 'sylius_money', [
60 60
                     'label' => sprintf('%s %s', $channel->getName(), $currency->getCode())
61 61
                 ]);
62 62
             }
Please login to merge, or discard this patch.
src/Sylius/Bundle/CoreBundle/Form/Type/Product/ProductVariantType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@
 block discarded – undo
117 117
         $view->vars['prototypes'] = [];
118 118
         foreach ($form->getConfig()->getAttribute('prototypes') as $group => $prototypes) {
119 119
             foreach ($prototypes as $type => $prototype) {
120
-                $view->vars['prototypes'][$group.'_'.$type] = $prototype->createView($view);
120
+                $view->vars['prototypes'][$group . '_' . $type] = $prototype->createView($view);
121 121
             }
122 122
         }
123 123
     }
Please login to merge, or discard this patch.
Core/spec/Taxation/Applicator/OrderShipmentTaxesApplicatorSpec.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@
 block discarded – undo
112 112
         $order->getShippingTotal()->willReturn(10);
113 113
         $order->getShipments()->willReturn(new ArrayCollection([]));
114 114
 
115
-        $this->shouldThrow(\LogicException::class)->during('apply', [$order, $zone]);;
115
+        $this->shouldThrow(\LogicException::class)->during('apply', [$order, $zone]); ;
116 116
     }
117 117
 
118 118
     function it_does_nothing_if_tax_rate_cannot_be_resolved(
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/ProductVariant/GeneratePageInterface.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -18,22 +18,28 @@
 block discarded – undo
18 18
  */
19 19
 interface GeneratePageInterface extends SymfonyPageInterface
20 20
 {
21
+    /**
22
+     * @return void
23
+     */
21 24
     public function generate();
22 25
 
23 26
     /**
24 27
      * @param int $nth
25 28
      * @param int $price
29
+     * @return void
26 30
      */
27 31
     public function specifyPrice($nth, $price);
28 32
 
29 33
     /**
30 34
      * @param int $nth
31 35
      * @param string $code
36
+     * @return void
32 37
      */
33 38
     public function nameCode($nth, $code);
34 39
 
35 40
     /**
36 41
      * @param int $nth
42
+     * @return void
37 43
      */
38 44
     public function removeVariant($nth);
39 45
 
Please login to merge, or discard this patch.
src/Sylius/Bundle/ProductBundle/DependencyInjection/Configuration.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,13 +13,13 @@
 block discarded – undo
13 13
 
14 14
 use Sylius\Bundle\ProductBundle\Form\Type\ProductAssociationType;
15 15
 use Sylius\Bundle\ProductBundle\Form\Type\ProductAssociationTypeType;
16
+use Sylius\Bundle\ProductBundle\Form\Type\ProductGenerateVariantsType;
16 17
 use Sylius\Bundle\ProductBundle\Form\Type\ProductOptionTranslationType;
17 18
 use Sylius\Bundle\ProductBundle\Form\Type\ProductOptionType;
18 19
 use Sylius\Bundle\ProductBundle\Form\Type\ProductOptionValueTranslationType;
19 20
 use Sylius\Bundle\ProductBundle\Form\Type\ProductOptionValueType;
20 21
 use Sylius\Bundle\ProductBundle\Form\Type\ProductTranslationType;
21 22
 use Sylius\Bundle\ProductBundle\Form\Type\ProductType;
22
-use Sylius\Bundle\ProductBundle\Form\Type\ProductGenerateVariantsType;
23 23
 use Sylius\Bundle\ProductBundle\Form\Type\ProductVariantGenerationType;
24 24
 use Sylius\Bundle\ProductBundle\Form\Type\ProductVariantType;
25 25
 use Sylius\Bundle\ResourceBundle\Controller\ResourceController;
Please login to merge, or discard this patch.
src/Sylius/Component/Product/Checker/ProductVariantsParityChecker.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 namespace Sylius\Behat\Page\Admin\Customer;
13 13
 
14 14
 use Sylius\Behat\Page\SymfonyPage;
15
-use Webmozart\Assert\Assert;
16 15
 
17 16
 /**
18 17
  * @author Magdalena Banasiak <[email protected]>
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
     {
50 50
         foreach ($variant->getOptionValues() as $option) {
51 51
             if (!$existingVariant->hasOptionValue($option)) {
52
-               return false;
52
+                return false;
53 53
             }
54 54
         }
55 55
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/Channel/CreatePageInterface.php 1 patch
Doc Comments   +17 added lines patch added patch discarded remove patch
@@ -18,62 +18,79 @@
 block discarded – undo
18 18
  */
19 19
 interface CreatePageInterface extends BaseCreatePageInterface
20 20
 {
21
+    /**
22
+     * @return void
23
+     */
21 24
     public function enable();
22 25
 
26
+    /**
27
+     * @return void
28
+     */
23 29
     public function disable();
24 30
 
25 31
     /**
26 32
      * @param string $name
33
+     * @return void
27 34
      */
28 35
     public function nameIt($name);
29 36
 
30 37
     /**
31 38
      * @param string $code
39
+     * @return void
32 40
      */
33 41
     public function specifyCode($code);
34 42
 
35 43
     /**
36 44
      * @param string $description
45
+     * @return void
37 46
      */
38 47
     public function describeItAs($description);
39 48
 
40 49
     /**
41 50
      * @param string $hostname
51
+     * @return void
42 52
      */
43 53
     public function setHostname($hostname);
44 54
 
45 55
     /**
46 56
      * @param string $color
57
+     * @return void
47 58
      */
48 59
     public function defineColor($color);
49 60
 
50 61
     /**
51 62
      * @param string $language
63
+     * @return void
52 64
      */
53 65
     public function chooseLocale($language);
54 66
 
55 67
     /**
56 68
      * @param string $currencyCode
69
+     * @return void
57 70
      */
58 71
     public function chooseCurrency($currencyCode);
59 72
 
60 73
     /**
61 74
      * @param string $taxZone
75
+     * @return void
62 76
      */
63 77
     public function chooseDefaultTaxZone($taxZone);
64 78
 
65 79
     /**
66 80
      * @param string $locale
81
+     * @return void
67 82
      */
68 83
     public function chooseDefaultLocale($locale);
69 84
 
70 85
     /**
71 86
      * @param string $currency
87
+     * @return void
72 88
      */
73 89
     public function chooseDefaultCurrency($currency);
74 90
 
75 91
     /**
76 92
      * @param string $taxCalculationStrategy
93
+     * @return void
77 94
      */
78 95
     public function chooseTaxCalculationStrategy($taxCalculationStrategy);
79 96
 }
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Admin/PaymentMethod/CreatePageInterface.php 1 patch
Doc Comments   +13 added lines patch added patch discarded remove patch
@@ -18,39 +18,52 @@
 block discarded – undo
18 18
  */
19 19
 interface CreatePageInterface extends BaseCreatePageInterface
20 20
 {
21
+    /**
22
+     * @return void
23
+     */
21 24
     public function enable();
25
+
26
+    /**
27
+     * @return void
28
+     */
22 29
     public function disable();
23 30
 
24 31
     /**
25 32
      * @param string $name
26 33
      * @param string $languageCode
34
+     * @return void
27 35
      */
28 36
     public function nameIt($name, $languageCode);
29 37
 
30 38
     /**
31 39
      * @param string $code
40
+     * @return void
32 41
      */
33 42
     public function specifyCode($code);
34 43
 
35 44
     /**
36 45
      * @param string $gateway
46
+     * @return void
37 47
      */
38 48
     public function chooseGateway($gateway);
39 49
 
40 50
     /**
41 51
      * @param string $channelName
52
+     * @return void
42 53
      */
43 54
     public function checkChannel($channelName);
44 55
 
45 56
     /**
46 57
      * @param string $description
47 58
      * @param string $languageCode
59
+     * @return void
48 60
      */
49 61
     public function describeIt($description, $languageCode);
50 62
 
51 63
     /**
52 64
      * @param string $instructions
53 65
      * @param string $languageCode
66
+     * @return void
54 67
      */
55 68
     public function setInstructions($instructions, $languageCode);
56 69
 
Please login to merge, or discard this patch.
src/Sylius/Behat/Page/Shop/HomePage.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,8 @@
 block discarded – undo
106 106
      * {@inheritdoc}
107 107
      */
108 108
     public function getLatestProductsNames()
109
-    {;
109
+    {
110
+;
110 111
         return array_map(
111 112
             function (NodeElement $element) { return $element->getText(); },
112 113
             $this->getDocument()->findAll('css', '.sylius-product-name')
Please login to merge, or discard this patch.